[ABD] Custom Code

[Lumpy Burgertushie]

I don't know much about how to create extensions at all, but I always wondered why you put all the html files in the store folder to begin with. I don't think other extensions do that , do they?


robert

[Sniper_E]

@ martti, I'm sorry your extension is having this problem with 3.1.6

I wish you good luck straighten it out and keeping this fine extension working.

[martti]

I don't know much about how to create extensions at all, but I always wondered why you put all the html files in the store folder to begin with. I don't think other extensions do that , do they?


robert

Because the store folder is writeable and the ext folder is not. And the files in the store/customcode directory is user content/data and isn't clearly part of the extension code itself.

[KillBill.]

I don't know much about how to create extensions at all, but I always wondered why you put all the html files in the store folder to begin with. I don't think other extensions do that , do they?


robert

Because the store folder is writeable and the ext folder is not. And the files in the store/customcode directory is user content/data and isn't clearly part of the extension code itself.

Idea change ext code:

1. you create new folder ext/marttiphpbb/customcode/styles/all/template/customcode
2. add info this folder change chmod 777
3. you change event/ all html include path
example
this
<!-- INCLUDE ../../../../../../store/customcode/overall_footer_after.html -->
replace
<!-- INCLUDE customcode/overall_footer_after.html -->

[david63]

Idea change ext code:

1. you create new folder ext/marttiphpbb/customcode/styles/all/template/customcode
2. add info this folder change chmod 777
3. you change event/ all html include path

That idea, whilst good, would not get past validation.

It is not allowed to add/delete/modify files within an extension. The way that it is handled at the moment is, as I understand it, the correct way. The issue is to resolve the Twig change (which may be a bug)

[Raul [ThE KuKa]]

Users,
This extension not works on 3.1.6 version, please disable extension BEFORE update to 3.1.6 version please.

[martti]

Users,
This extension not works on 3.1.6 version, please disable extension BEFORE update to 3.1.6 version please.

This warning is put in the first post now.

[Mauron]

Go in PhpMyAdmin, in table phpbb_ext, in column ext_name search the line marttiphpbb/customcode, in the column ext_active for the corresponding line found change the value 1 to 0.

If you are not logged in the ACP then delete the styles directory from the extension first. (under ext/marttiphpbb/customcode/) Then the board should work again.

Both these solutions don't work (I'm using a local test board anyway, so MEH).

[martti]

Go in PhpMyAdmin, in table phpbb_ext, in column ext_name search the line marttiphpbb/customcode, in the column ext_active for the corresponding line found change the value 1 to 0.

If you are not logged in the ACP then delete the styles directory from the extension first. (under ext/marttiphpbb/customcode/) Then the board should work again.

Both these solutions don't work (I'm using a local test board anyway, so MEH).

Also delete the contents of the cache directory.

[Mauron]

Also delete the contents of the cache directory.

Thanks, it worked now.

For reference, I didn't delete all the cache but the one file the error pointed out:

Code: Select all

Fatal error: Uncaught exception 'Twig_Error_Loader' with message 'Unable to find template "@marttiphpbb_customcode/event/overall_header_head_append.html" (looked into: ) in "overall_header.html" at line 63.' in xxx\yyy\phpBB\vendor\twig\twig\lib\Twig\Loader\Filesystem.php:195 Stack trace: #0 xxx\yyy\phpBB\phpbb\template\twig\loader.php(107): Twig_Loader_Filesystem->findTemplate('@marttiphpbb_cu...') #1 xxx\yyy\phpBB\vendor\twig\twig\lib\Twig\Loader\Filesystem.php(138): phpbb\template\twig\loader->findTemplate('@marttiphpbb_cu...') #2 xxx\yyy\phpBB\vendor\twig\twig\lib\Twig\Environment.php(266): Twig_Loader_Filesystem->getCacheKey('@marttiphpbb_cu...') #3 xxx\yyy\phpBB\vendor\twig\twig\lib\Twig\Environment.php(324): Twig_Environment->getTemplateClass('@marttiphpbb_cu...', NULL) #4 xxx\yyy\phpBB\phpbb\template\twig\environment.php(166): Twig_Environment->loadTemplate('@marttiphpbb_cu...', NULL) #5 xxx\yyy\phpBB\cache\twig\c\e\ce0d92172b651115f5888a88e54bb33c8a2c8244acaaa909db6bdfacd0ffc390.php(26 in xxx\yyy\phpBB\vendor\twig\twig\lib\Twig\Loader\Filesystem.php on line 195

So I went and just deleted phpBB\cache\twig\c\e\ce0d92172b651115f5888a88e54bb33c8a2c8244acaaa909db6bdfacd0ffc390.php.

[martti]

Idea change ext code:

1. you create new folder ext/marttiphpbb/customcode/styles/all/template/customcode
2. add info this folder change chmod 777
3. you change event/ all html include path
example
this
<!-- INCLUDE ../../../../../../store/customcode/overall_footer_after.html -->
replace
<!-- INCLUDE customcode/overall_footer_after.html -->

The disadvantages are:

• It is not plug and play.
• Data in the repository code. (You have to pay attention not to delete your custom code when updating).
• Can not be validated.

For anyone that is using the Custom Code extension I propose the following solution/alternative:

Create your own private extension by modifying this little extension: https://github.com/marttiphpbb/phpbb-ex ... mplatecode

In the ext/marttiphpbb/inserttemplatecode/style/all/template/event directory you can put then any template events you like.
If you have created content with the Custom Code extension, you can copy the contents of the store/customcode directory and move it to ext/marttiphpbb/inserttemplatecode/style/all/template/event.
(If you had included other files with <!-- INCLUDE ../../../../../../ you have to remove the prefix ../../../../../../ to and put the included files in ext/marttiphpbb/inserttemplatecode/style/all/template)

Don't forget to clear the cache when you have edited something. Tip: whilst editing you can switch on the option Recompile stale style components in ACP > Load Settings. Then you don't need to clear the cache each time you change something. But for the sake of performance switch off this option after editing.

The disadvantage is that you loose the editor of the Custom Code extension in the ACP. But on the other hand it is more flexible as you can easily insert any template event possible. You are not limited by the set template events that was provided by the Custom Code extension.
You can use my extension Template Event Locations to see markers in the board of all template events available.


Here are 2 extra little extensions that provide extra template variables (these were used in the previous examples):

• Group Template Variables
• Parameter Template Variables -> replaces this functionality that was available in the Custom Code extension.

[MarieNatalie]

This extension does not work on the phpBB 3.1.6 version, please disable extension BEFORE update to 3.1.6 version.

Could you please tell us... just disable or and DELETE data?

Thanks in advance

[martti]

This extension does not work on the phpBB 3.1.6 version, please disable extension BEFORE update to 3.1.6 version.

Could you please tell us... just disable or and DELETE data?

Thanks in advance

Disable.

[Solidjeuh]

I noticed in phpbb update that auto update still is merging files
So would it not be easyer to just edit the code files like before?
Or am I mistaking?

[martti]

I noticed in phpbb update that auto update still is merging files
So would it not be easyer to just edit the code files like before?
Or am I mistaking?

It's always better to have a clean separation between the core and anything else, imho.