[ABD] AddonForThanksForPosts

Any abandoned Extensions will be moved to this forum.

WARNING: Extensions in this forum are not currently being supported or maintained by the original Extension author. Proceed at your own risk.
Forum rules
IMPORTANT: Extension Development Forum rules

WARNING: Extensions in this forum are not currently being supported nor updated by the original Extension author. Proceed at your own risk.
User avatar
Alg
Registered User
Posts: 76
Joined: Thu Aug 07, 2014 7:13 pm
Location: Israel
Contact:

[ABD] AddonForThanksForPosts

Post by Alg »

Extension Name:AddonForThanksForPosts

This extension is add-on for extension: Thanks for posts and must be used only if the main extension installed and turned on

Extension Description:: Adds ajax functionality to main extension to update result of set/delete likes without reloading the page

Requirements:
  • phpBB 3.1.0-RC4 (or current 3.1.0-dev) or later
Development repository: https://github.com/alg5/AddonForThanksForPosts

Download URL: Download button named "Download ZIP" can be found at the development repository page.
Installation: Extension files should be extracted to /ext/alg/AddonForThanksForPosts/ folder. Then the extension should be enabled in ACP as usually.

Precaution: As the ext is still in development, major changes still can be applied which could require full extension purging and reinstallation, so use it on your own risk.

Attention! By demands of the validators team the extension has been renamed from AddonForThanksForPosts to addonforthanksforposts.
The last version that has the name AddonForThanksForPosts - 2.0.7
The first version that has the name addonforthanksforposts - 2.0.8
The correct order for updating to the up to date versionin the case you have a version below 2.0.8:
1. Disable the extension.
2. Delete the extension data (This is a MUST step).
3. Delete the AddonForThanksForPosts folder on the server (recommended).
4. Install the latest version of the extension from the repository.
5. Turn on the extension.
Last edited by Alg on Sat Sep 10, 2016 11:21 am, edited 2 times in total.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5859
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: [dev]AddonForThanksForPosts

Post by MattF »

In your composer.json you should add the Thanks for Posts as a requirement.

Code: Select all

    "require": {
        "php": ">=5.3.3",
        "gfksx/ThanksForPosts": "2.0.*"
    },
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: [dev]AddonForThanksForPosts

Post by PayBas »

Or he/she could work together with rxu and submit a pull request to it ;).
rxu
Extensions Development Team
Posts: 3711
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Contact:

Re: [dev]AddonForThanksForPosts

Post by rxu »

PayBas wrote:Or he/she could work together with rxu and submit a pull request to it
She does :) And there was a pull request, which was proposed to be an addon after reviewing it by me to avoid messing up the stuff.
Actually, this addon works pretty fine and has a check in ext.php for main ext installed. Although current extension system can't prevent things like disabling extension having another dependent extensions, which causes board crash. Hope this will be fixed in 3.2 somehow.

Also, I was under impression that "require" dependencies are applicable only for packages contained in Packagist , aren't they?
User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: [dev]AddonForThanksForPosts

Post by PayBas »

If the execution of code depends on an extension being enabled, you could indeed check if your add-on extension should be able to be enabled.

But you could also check if the dependency is still available at every execution (in the listener for instance). This way, if someone disables the "parent" extension after they have enabled the "child"... nothing breaks.
rxu
Extensions Development Team
Posts: 3711
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Contact:

Re: [dev]AddonForThanksForPosts

Post by rxu »

The problem is that if you disable "parent" ext you get the board broken regardless of using "child" ext. You just disable "parent" ext, then go to the board index and got the error.
User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: [dev]AddonForThanksForPosts

Post by PayBas »

rxu wrote:The problem is that if you disable "parent" ext you get the board broken regardless of using "child" ext. You just disable "parent" ext, then go to the board index and got the error.
If you define it as a service, then probably yes ;).
rxu
Extensions Development Team
Posts: 3711
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Contact:

Re: [dev]AddonForThanksForPosts

Post by rxu »

Sure, "parent" ext has a helper class which is defined as a service and is used by "child" ext :)
User avatar
advocatus
Registered User
Posts: 290
Joined: Tue Aug 12, 2014 11:58 am
Location: Ontario, Canada.
Contact:

Re: [dev]AddonForThanksForPosts

Post by advocatus »

I'm testing Thanks For Posts (with this Add On) on a local host. When the Add On is enabled, Thanks aren't being saved. When a post is Thanked, the indicator on the top right appears saying that the post has been Thanked, but when I refresh, it's not Thanked any more.

Disabling this extension allows Thanks For Posts to work correctly again.
Hi, I'm advocatus and I own www.forumgames.in.
User avatar
Alg
Registered User
Posts: 76
Joined: Thu Aug 07, 2014 7:13 pm
Location: Israel
Contact:

Re: [dev]AddonForThanksForPosts

Post by Alg »

advocatus, is this actually yet?
User avatar
advocatus
Registered User
Posts: 290
Joined: Tue Aug 12, 2014 11:58 am
Location: Ontario, Canada.
Contact:

Re: [dev]AddonForThanksForPosts

Post by advocatus »

I'm not sure what you're asking me, but I don't have access to the setup I was using any more. I'm not able to reproduce or give you any trouble shooting information any more. Sorry.
Hi, I'm advocatus and I own www.forumgames.in.
playgoods
Registered User
Posts: 60
Joined: Wed Jun 16, 2010 1:05 pm

Re: [dev]AddonForThanksForPosts

Post by playgoods »

I see that a 2.0.3 version has been released.

What are the changes?
User avatar
Alg
Registered User
Posts: 76
Joined: Thu Aug 07, 2014 7:13 pm
Location: Israel
Contact:

Re: [dev]AddonForThanksForPosts

Post by Alg »

playgoodsI , I made fix for compatibility with the extension "topic as article"
Holger
Registered User
Posts: 1883
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [dev]AddonForThanksForPosts

Post by Holger »

I got a big problem with this great addon after upgrading to PL1, I dont know if it has to do with the PL1.
My users got logged out all the time.
When disabeling the addon the issue is gone.
Cin-
Registered User
Posts: 55
Joined: Fri Feb 06, 2015 2:06 pm

Re: [dev]AddonForThanksForPosts

Post by Cin- »

Hi Alg,

Any plans on updating it for phpBB 3.2?

rxu made his mod already phpBB 3.2 compatible. Maybe you can copy the changes?

https://github.com/rxu/thanks_for_posts ... f494fd7d6a
Locked

Return to “Abandoned Extensions”