Reason on editing

For support and discussion related to templates, themes, and imagesets in phpBB 3.0.
Anti-Spam Guide
TJK
Registered User
Posts: 97
Joined: Sat Dec 26, 2015 9:10 pm
Name: Tolaso J Kos
Contact:

Reason on editing

Post by TJK » Mon Dec 28, 2015 10:25 am

I am reposting the question as suggested by stevemaury here.

I am running a subsilver edition of phpbb3 -xand- and I would like to display the "reason" every time a moderator edits a post and leaves a message for the reason. While this is done in prosilver , in subsilver this is not done.

Is there something that can be done about it? What files do I need to edit?

Thank you in advance.

This is what I actually want the post to look like after editing and a reason is given:

Last edited by: ....
Reason: ....

Well the last edited by is by default appearing but the reason is missing. Any help appreciated.

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Reason on editing

Post by RMcGirr83 » Mon Dec 28, 2015 11:37 am

It isn't because of the style. Code would need to be added to the PHP code.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
mrgoldy
Jr. Extension Validator
Posts: 1182
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: Reason on editing

Post by mrgoldy » Mon Dec 28, 2015 2:15 pm

It should be possible if the 'Edit reason' was filled in? That's already there in PHP coding.. So styles could use that, could you provide a link to the 'xand' style?

TJK
Registered User
Posts: 97
Joined: Sat Dec 26, 2015 9:10 pm
Name: Tolaso J Kos
Contact:

Re: Reason on editing

Post by TJK » Mon Dec 28, 2015 5:05 pm

posey wrote: could you provide a link to the 'xand' style?
This is the "xand" style based on subsilver2.
RMcGirr83 wrote:It isn't because of the style. Code would need to be added to the PHP code.
Okay , that sounds like an answer but what file should I edit? Would that be the .php files or the templates and css files within the ACP? Also, what kind of code should be added? I am kind of a little new to php so I don't have that much experience.

Thanks for the answer anyway.

User avatar
Lumpy Burgertushie
Registered User
Posts: 66850
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: Reason on editing

Post by Lumpy Burgertushie » Mon Dec 28, 2015 5:26 pm

I can't reproduce the problem.

I just installed xand on my test board.
when I click on the edit icon, I get the standard page. I edit the post. I put in my reason for editing.
I click submit.
I return to the post and both the time edited and the reason edited are there just as they should be.

the proper code is in both subsilver2 and in xand.

it does work as it should.

the only thing that should keep it from working is if you changed the code in the html files or if you do not have the proper permissions to see and/or use the edit function.


robert

EDIT: are you sure that you have all the editing settings correct in the admin panel under the Post Settings section?
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

If a tree falls in the forest and nobody is there, does it make a sound?

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Reason on editing

Post by RMcGirr83 » Tue Dec 29, 2015 1:15 am

I believe the OP wants the reason to be mandatory.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
Lumpy Burgertushie
Registered User
Posts: 66850
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: Reason on editing

Post by Lumpy Burgertushie » Tue Dec 29, 2015 5:22 am

I understood it that he just wants it to work in his style which is what he said is not happening.


robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

If a tree falls in the forest and nobody is there, does it make a sound?

TJK
Registered User
Posts: 97
Joined: Sat Dec 26, 2015 9:10 pm
Name: Tolaso J Kos
Contact:

Re: Reason on editing

Post by TJK » Wed Dec 30, 2015 3:19 pm

Lumpy Burgertushie wrote: when I click on the edit icon, I get the standard page. I edit the post. I put in my reason for editing.
I click submit.
I return to the post and both the time edited and the reason edited are there just as they should be. the proper code is in both subsilver2 and in xand.

it does work as it should.
No, you misunderstood me...
I did not say that the reason is not showing up. The reason, if entered , will show up as it should. That is not the problem.

The problem that the word reason won't show up. For example in prosilver when an edit reason is entered at the bottom of the edited message you see:
----------
Last edited by <username> <date>
Reason: Some reason
while in subsilver you see the following:
Last edited by <username> <date>
Some reason
That is the word Reason is not displayed at all. That is what I would like to add. Every time a moderator leaves a message this word to be displayed. And the question is if this is possible. I guess the answer is positive but I don't know what files to edit.
Lumpy Burgertushie wrote: are you sure that you have all the editing settings correct in the admin panel under the Post Settings section?
Yes, I have not changed anything of that and all in all I have not altered anything of the html and css files that concern the editing procedure.

User avatar
Brf
Support Team Member
Support Team Member
Posts: 51882
Joined: Tue May 10, 2005 7:47 pm
Location: {postrow.POSTER_FROM}
Contact:

Re: Reason on editing

Post by Brf » Wed Dec 30, 2015 3:30 pm

You mean subsilver2's viewtopic_body.html does not have
{L_REASON}{L_COLON} before {postrow.EDIT_REASON}

User avatar
Lumpy Burgertushie
Registered User
Posts: 66850
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: Reason on editing

Post by Lumpy Burgertushie » Wed Dec 30, 2015 3:53 pm

brf, apparently, the answer to your question is no, it does not.

subsilver2 ( and xand as well ) have this line:

<td class="row2"><span class="genmed">{postrow.EDIT_REASON}</span></td>

prosilver has this one:
<!-- IF postrow.EDIT_REASON --><br /><strong>{L_REASON}:</strong> <em>{postrow.EDIT_REASON}</em><!-- ENDIF -->

very strange.

OP: you can fix this by editing that file.

find:
<td class="row2"><span class="genmed">{postrow.EDIT_REASON}</span></td>

change it to:
<td class="row2"><span class="genmed"><strong>{L_REASON}:</strong> {postrow.EDIT_REASON}</span></td>

robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

If a tree falls in the forest and nobody is there, does it make a sound?

TJK
Registered User
Posts: 97
Joined: Sat Dec 26, 2015 9:10 pm
Name: Tolaso J Kos
Contact:

Re: Reason on editing

Post by TJK » Wed Dec 30, 2015 8:19 pm

Thank you Lumpy Burgertushie. That solved the problem.
Something else. How do the letters next to the word reason appear in italicezed format just like prosilver? Can this be done or not?

User avatar
Lumpy Burgertushie
Registered User
Posts: 66850
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: Reason on editing

Post by Lumpy Burgertushie » Wed Dec 30, 2015 9:19 pm

change that line to this:
<td class="row2"><span class="genmed"><strong>{L_REASON}:</strong> <em>{postrow.EDIT_REASON}</em></span></td>

notice the <em> tags that surround the EDIT_REASON variable

robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

If a tree falls in the forest and nobody is there, does it make a sound?

TJK
Registered User
Posts: 97
Joined: Sat Dec 26, 2015 9:10 pm
Name: Tolaso J Kos
Contact:

Re: Reason on editing

Post by TJK » Wed Dec 30, 2015 10:18 pm

Thank you.. This works as it should.

TJK
Registered User
Posts: 97
Joined: Sat Dec 26, 2015 9:10 pm
Name: Tolaso J Kos
Contact:

Re: Reason on editing

Post by TJK » Thu Jan 28, 2016 6:43 am

Hmm... something else. How do we add the dashed lines just before the

Last edited by:
Reason:

like in prosilver?

I guess it has something to do with what brf said:
Brf wrote:You mean subsilver2's viewtopic_body.html does not have
{L_REASON}{L_COLON} before {postrow.EDIT_REASON}

User avatar
Lumpy Burgertushie
Registered User
Posts: 66850
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: Reason on editing

Post by Lumpy Burgertushie » Thu Jan 28, 2016 7:17 am

open stylesheet.css add the following to the bottom of the file:

Code: Select all

/* Post noticies */
.notice {
	font-family: "Lucida Grande", Verdana, Helvetica, Arial, sans-serif;
	width: 10%;
	margin-top: 1.5em;
	padding-top: 0.2em;
	font-size: 1em;
	border-top: 1px dashed ;
	clear: left;
	line-height: 130%;
}
open viewtopic_body.html

find:

Code: Select all

<!-- IF postrow.EDIT_REASON -->
							<br /><br />
on a new line after, add:

Code: Select all

<div class="notice"></div>
save and upload back, purge cache and refresh browser.

you can adjust the css to make the dashed line look as you wish.


robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

If a tree falls in the forest and nobody is there, does it make a sound?

Locked

Return to “[3.0.x] Styles Support & Discussion”