Submission for review when archive is too big

Discussion forum for Extension Writers regarding Extension Development.
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Submission for review when archive is too big

Post by MarkDHamill »

As I documented here:

https://tracker.phpbb.com/browse/WEBSITE-1287?filter=-2

I can't upload my Smartfeed extension for review because the archive is too big. This is because it bundles in SimplePie, a third party library.

What's the appropriate way to get a review? I'm thinking I should just remove SimplePie from the archive and in the notes to the review team provide instructions on how to fetch the SimplePie library.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
Sajaki
Registered User
Posts: 1390
Joined: Mon Mar 02, 2009 1:41 pm
Location: Amsterdam
Contact:

Re: Submission for review when archive is too big

Post by Sajaki »

just add it to your composer file ?

Code: Select all

"require": {
        "simplepie/simplepie": "1.3.1"
    }
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 28619
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Submission for review when archive is too big

Post by Paul »

You should provide a full working package. I poked the website team to get this solved.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 18316
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: Submission for review when archive is too big

Post by DavidIQ »

We're looking into it. Stand by.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Submission for review when archive is too big

Post by MarkDHamill »

Awesome! I've been dragging my feet on this for a few months hoping the issue would get noticed. Sounds like a simple tech fix, probably just increase PHP's max_execution_time.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Submission for review when archive is too big

Post by MarkDHamill »

Sajaki wrote:just add it to your composer file ?

Code: Select all

"require": {
        "simplepie/simplepie": "1.3.1"
    }
Already there:

Code: Select all

	"require": {
		"php": ">=5.3.3,<7.0",
		"composer/installers": "~1.0",
		"simplepie/simplepie": ">= 1.3.1,<1.4"
	},
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
david63
Registered User
Posts: 20646
Joined: Thu Dec 19, 2002 8:08 am

Re: Submission for review when archive is too big

Post by david63 »

Just to digress slightly - sorry Mark.

Are there any plans, if it is even possible, that where there are composer dependencies for an extension that the install routine can add the "vendor" files automatically?
David
Remember: You only know what you know and - you don't know what you don't know!

I now no longer support any of my extensions but they will start to become available here
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 28619
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Submission for review when archive is too big

Post by Paul »

david63 wrote:Just to digress slightly - sorry Mark.

Are there any plans, if it is even possible, that where there are composer dependencies for an extension that the install routine can add the "vendor" files automatically?
Yes. It is planned for 3.3.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 18316
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: Submission for review when archive is too big

Post by DavidIQ »

MarkDHamill wrote:Awesome! I've been dragging my feet on this for a few months hoping the issue would get noticed. Sounds like a simple tech fix, probably just increase PHP's max_execution_time.
This is actually a little more complicated due to our server infrastructure. Might take a few days so I'll ping you on the ticket once I/we have something in place for you.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5859
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: Submission for review when archive is too big

Post by MattF »

Sajaki wrote:just add it to your composer file ?

Code: Select all

"require": {
        "simplepie/simplepie": "1.3.1"
    }
This is not a solution. This means the only way to get it would be to run composer install from the command line (how many people on shared webhosts even have SSH?).

A released extension should, just as phpBB does, include already in its package any external libraries.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco
Contact:

Re: Submission for review when archive is too big

Post by 3Di »

Yes, as discussed here with Mark

viewtopic.php?p=14505611#p14505611
MarkDHamill wrote:This is because it bundles in SimplePie
On a side note, I don't see in your extension you are checking for the SimplePie mandatory requisites, we already discussed this point about 4 months ago into the topic I above linked. I.e.: (cURL etc..).

That's your choice, preventing though the installation of your extension if those requisites aren't satisfied sounds to me like a good idea, in order to avoid maybe multiple support requests for nothing... nonetheless.
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Submission for review when archive is too big

Post by MarkDHamill »

The bug is still open so I'm guessing it's not addressed. Since I need to put out a new version of Smartfeed, I'll pull SimplePie out of the archive and make a note in the README.md. Yes, composer.json is updated to require SimplePie:

Code: Select all

	"require": {
		"php": ">=5.3.3,<=7.1",
		"composer/installers": "~1.0",
		"simplepie/simplepie": ">= 1.3.1,<1.4"
	},
The new version has been tested with Rhea and is backward compatible with 3.1.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 28619
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Submission for review when archive is too big

Post by Paul »

All dependencies need to be included in the package, we won't be able to approve extensions that have missing dependencies. I again poked the people to get their attention to this.
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Submission for review when archive is too big

Post by MarkDHamill »

I'm happy to do so when they fix the server issue. Thank you for helping.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 18316
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: Submission for review when archive is too big

Post by DavidIQ »

Are you able to attach your complete extension package to this topic without error?
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.
Post Reply

Return to “Extension Writers Discussion”