[CDB] Mark Post Unread

[kasimi]

Sorry, I had forgotten that you had already reported an issue with 3.2. The new version 1.1.0 is compatible with phpBB 3.2.x and is now available in the first post. Hoping for feedback so that it can be submitted for validation.

[pierredu]

Thanks for the update.

Question 1:
Why did you use the file icon and not the asterisk icon (fa-asterisk) as in version 3.1.x ?

Error message while using the feature :

Code: Select all

SQL ERROR [ mysqli ]

Duplicate entry '699-144225' for key 'PRIMARY' [1062]

SQL

INSERT INTO phpbb3_topics_track (user_id, topic_id, forum_id, mark_time) VALUES ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398')

[kasimi]

Thanks for testing!

Why did you use the file icon and not the asterisk icon (fa-asterisk) as in version 3.1.x ?

The file icon matches the "Search unread" icon in the Quick links menu.

Error message while using the feature

Can you test this fix? I removed these two lines in the latest version, looks like they are needed after all.
https://github.com/kasimi/phpbb-ext-mar ... 5031278165

[pierredu]

Still the same error with both lines added, even after emptying the cache.

[wojtek64]

Hi,

I installing this extension on phpBB forum release 3.2.0 and also get sql error of duplicate key in table _topic_track when click mark post as unread.

After little investigation, I found error in file include/core.php in line 245.
You inserting to topic track table marks for other topics from this forum, but inserting records with bad topic_id

Code: Select all

240			while ($row = $this->db->sql_fetchrow($result))
241			{
242				
243				$sql_insert_ary[] = array(
244					'user_id'	=> $user_id,
245					'topic_id'	=> $topic_id,
246					'forum_id'	=> $forum_id,
247					'mark_time'	=> $forum_tracking_info,
248				);
249			}

Line 245 need modification to:

Code: Select all

                                    'topic_id'  => $row['topic_id'];

After this update all working good. Posts marked withouth errors.

best regarrds
Wojtek Musiał

[pierredu]

Fine, congrats for the debugging work.
The line should be 'topic_id' => $row['topic_id'], and not 'topic_id' => $row['topic_id']; (comma and not semicolon).

[wojtek64]

Fine, congrats for the debugging work.
The line should be 'topic_id' => $row['topic_id'], and not 'topic_id' => $row['topic_id']; (comma and not semicolon).

Ofcorse! My mistake when writing post.

[kasimi]

Line 245 need modification to:

Code: Select all

                                    'topic_id'  => $row['topic_id'];

Thanks for finding the fix wojtek.

The package for version 1.1.0 has been updated.

[BBBenj]

Thanks for your great job!

Is there a way to change the icon, please?

[kasimi]

For phpBB 3.2.x, change the fa-file in this line to any FA icon you want.

For phpBB 3.1.x it's more complicated. You would have to add your icon file to the theme/images folder, include a CSS file and add some rules to it, similar to the core icons.

[kasimi]

Version 1.1.1 is now available.

In earlier versions there was a bug that allowed users without m_approve permission to find out if a certain post was soft- or hard-deleted. Furthermore users were able to find out if a post was moved to a forum where they don't have read permission.

Please update to the latest version!

[Galixte de EzCom]

Hi,

this topic should be locked, it’s in CDB: https://www.phpbb.com/customise/db/exte ... st_unread/.