[CDB] Mark Post Unread

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 3632
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: [3.1][3.2][RC] Mark Post Unread

Post by kasimi » Wed Jan 25, 2017 7:51 pm

Sorry, I had forgotten that you had already reported an issue with 3.2. The new version 1.1.0 is compatible with phpBB 3.2.x and is now available in the first post. Hoping for feedback so that it can be submitted for validation.

User avatar
pierredu
Registered User
Posts: 917
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.1][3.2][RC] Mark Post Unread

Post by pierredu » Thu Jan 26, 2017 1:43 pm

Thanks for the update.

Question 1:
Why did you use the file icon and not the asterisk icon (fa-asterisk) as in version 3.1.x ?

Error message while using the feature :

Code: Select all

SQL ERROR [ mysqli ]

Duplicate entry '699-144225' for key 'PRIMARY' [1062]

SQL

INSERT INTO phpbb3_topics_track (user_id, topic_id, forum_id, mark_time) VALUES ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398'), ('699', '144225', '56', '1467987398')

User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 3632
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: [3.1][3.2][RC] Mark Post Unread

Post by kasimi » Thu Jan 26, 2017 2:07 pm

Thanks for testing!

pierredu wrote:
Thu Jan 26, 2017 1:43 pm
Why did you use the file icon and not the asterisk icon (fa-asterisk) as in version 3.1.x ?
The file icon matches the "Search unread" icon in the Quick links menu.

pierredu wrote:
Thu Jan 26, 2017 1:43 pm
Error message while using the feature
Can you test this fix? I removed these two lines in the latest version, looks like they are needed after all.
https://github.com/kasimi/phpbb-ext-mar ... 5031278165

User avatar
pierredu
Registered User
Posts: 917
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.1][3.2][RC] Mark Post Unread

Post by pierredu » Thu Jan 26, 2017 2:40 pm

Still the same error with both lines added, even after emptying the cache.

wojtek64
Registered User
Posts: 4
Joined: Mon Feb 06, 2017 8:30 am
Name: Wojtek Musiał

Re: [3.1][3.2][RC] Mark Post Unread

Post by wojtek64 » Mon Feb 06, 2017 8:53 am

Hi,

I installing this extension on phpBB forum release 3.2.0 and also get sql error of duplicate key in table _topic_track when click mark post as unread.

After little investigation, I found error in file include/core.php in line 245.
You inserting to topic track table marks for other topics from this forum, but inserting records with bad topic_id ;)

Code: Select all

240			while ($row = $this->db->sql_fetchrow($result))
241			{
242				
243				$sql_insert_ary[] = array(
244					'user_id'	=> $user_id,
245					'topic_id'	=> $topic_id,
246					'forum_id'	=> $forum_id,
247					'mark_time'	=> $forum_tracking_info,
248				);
249			}
Line 245 need modification to:

Code: Select all

                                    'topic_id'  => $row['topic_id'];
After this update all working good. Posts marked withouth errors.

best regarrds
Wojtek Musiał
Wojtek Musiał

User avatar
pierredu
Registered User
Posts: 917
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.1][3.2][RC] Mark Post Unread

Post by pierredu » Mon Feb 06, 2017 2:03 pm

Fine, congrats for the debugging work.
The line should be 'topic_id' => $row['topic_id'], and not 'topic_id' => $row['topic_id']; (comma and not semicolon).

wojtek64
Registered User
Posts: 4
Joined: Mon Feb 06, 2017 8:30 am
Name: Wojtek Musiał

Re: [3.1][3.2][RC] Mark Post Unread

Post by wojtek64 » Mon Feb 06, 2017 2:07 pm

pierredu wrote:
Mon Feb 06, 2017 2:03 pm
Fine, congrats for the debugging work.
The line should be 'topic_id' => $row['topic_id'], and not 'topic_id' => $row['topic_id']; (comma and not semicolon).
Ofcorse! My mistake when writing post.
Wojtek Musiał

User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 3632
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: [3.1][3.2][RC] Mark Post Unread

Post by kasimi » Wed Feb 15, 2017 12:07 pm

wojtek64 wrote:
Mon Feb 06, 2017 8:53 am
Line 245 need modification to:

Code: Select all

                                    'topic_id'  => $row['topic_id'];
Thanks for finding the fix wojtek. :)

The package for version 1.1.0 has been updated.

User avatar
BBBenj
Registered User
Posts: 19
Joined: Mon Jun 02, 2014 8:05 pm

Re: [3.1][3.2][RC] Mark Post Unread

Post by BBBenj » Mon Mar 20, 2017 3:10 pm

Thanks for your great job!

Is there a way to change the icon, please?

User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 3632
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: [3.1][3.2][RC] Mark Post Unread

Post by kasimi » Wed Mar 22, 2017 11:26 am

For phpBB 3.2.x, change the fa-file in this line to any FA icon you want.

For phpBB 3.1.x it's more complicated. You would have to add your icon file to the theme/images folder, include a CSS file and add some rules to it, similar to the core icons.

User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 3632
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: [3.1][3.2][RC] Mark Post Unread

Post by kasimi » Thu Apr 27, 2017 3:00 pm

Version 1.1.1 is now available.

In earlier versions there was a bug that allowed users without m_approve permission to find out if a certain post was soft- or hard-deleted. Furthermore users were able to find out if a post was moved to a forum where they don't have read permission.

Please update to the latest version!

User avatar
Galixte de EzCom
Registered User
Posts: 975
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [3.1][3.2][RC] Mark Post Unread

Post by Galixte de EzCom » Fri Sep 29, 2017 10:38 pm

Hi,

this topic should be locked, it’s in CDB: https://www.phpbb.com/customise/db/exte ... st_unread/.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.

Locked

Return to “Extensions in Development”

Who is online

Users browsing this forum: Baidu [Spider], nou nou and 14 guests