bug-i wrote: ↑Sat Oct 07, 2017 6:03 am
First of all: Thanks for bugfixing and including the new link. As far as I can see it works like it should now. Great job!
Great, thanks.
bug-i wrote: ↑Sat Oct 07, 2017 6:03 am
minor bug for hall of fame: I have some users, that do not have the trophy or a own userpic under "Top Posters ever", and I think I know why: These are users that do not have made a post in the last month, but from their history have made in total enough posts to show up under "Top Posters ever"
And what do they show instead? Did you try to page reload (F5)? I can't reproduce with my test-bed this situation, I have 500 users and each of them shows the trophy despite they made or not a post in the last month, so your help catching the issue is needed. By PM a link to your board and the number of page where the issue happens, ofcourse you need to set TPOTM permissions to the Guest group if you don't want to gimme a test account. I will investigate with my dev tools, no need to access the ACP at all.
bug-i wrote: ↑Sat Oct 07, 2017 6:03 am
question: is it a feature or bug that the tiny trophy at the main page has a different color than earlier? Now its not the standard-prosilver blue anymore.
The trophy is only one image reduced on the fly via CSS and owns a own colour, no CSS implied for that colour has been coded, hence no it is always the same. Edit: see my edit below.
bug-i wrote: ↑Sat Oct 07, 2017 6:03 am
Anyway, I am ok with the way it works now but also see some differences between A) the way it works, B) the current description and C) what I initially intended. In case you are still interested in my opinion let me know, I would be happy to support you further in this development.
No probs about the misunderstanding because I opted for the "minus malis", I got your points but sincerely I was to ahead with the coded option to trash it and forget. Coding what you would like is not a simple stuff, implies do do some calculations based on timezones for each user which are stored not as decimals anymore like it was in 3.0.xx but strings (like Europe/Paris) in the DB - no worth the effort for a cosmethical tooltip IMHO. So I made an absolute UTC+00:00 date format for it in order to make everyone happy or leave them to set anothe date() constraint in the native phpBB's preferences. The option has been set to No as per default. That's not something onto which I will get back agin changing that code, I hope you'll understand my point of view .
And last but NOT least, I discovered the SQL queries aren't anymore avoided during the cache time, that means those are continously running despite the settings in ACP. I can say "were running" because I have already fixed everything here in local, it's under exhaustive testing prior to release the new package with the fix, which I hope is the last one.
And yes, please keep on testing if you like, by my developer point of view that's very important and much appreciated. Thanks.
Eine schöne Tag noch.
Edit: about the tiny trophy over there in the navbar that's a fontawesome icon instead, not an image.
And yes, I modified it for viewtopic which inherits the grey, that's why. And now paints also the hall of fame's link on the nav bar. I will fix that. The navbar already show that icon on the appropriated blue.
I took a note and will be included in the next package.
That's in tpotm.css line 11:
color: blue;
that should be changed to
color: #105289;