Disapearing attachments after update to 3.2.2

[Tarantino]

Thanks for all the info. My problem was worse xD After update to 3.2.1, the attachments were deleted from the files folder

And I didnt make a backup

[1024KBUser]

EXACT same bug here too!

Relatively new setup (1 week old), was on 3.2.1 and upgraded to 3.2.2.

Saw this bug when I edited a post with attachments. Preview shows them but they then disappear.

[1024KBUser]

Any update on this ? How long for a fix ?

[mrix2000]

Hello yes had what I thought was a totally faultless upgrade to now get the issue from more then one member that when they upload more than one image attachment only 1 remains I have set in admin to allow 4 image attachments but when I upload more than one myself only one remains.
Hope this can be fixed as my site is image attachment heavy.
Thanks all
mrix

[Bab72de]

This also seems to affect post editing. When you edit a post with multiple attachments only one attachment is shown in the Attachments tab.

[thecaretaker1]

Temporarily, I've reverted back to the previous version of my forum until a fix is found. Checking the bug tracker, it says unassigned. So I assume that until somebody picks this job up, it will remain a problem. Maybe if you all vote for this issue it will get noticed sooner. Only 3 votes so far and 4 watching
https://tracker.phpbb.com/browse/PHPBB3-15506

[WelshPaul]

See post below...

[WelshPaul]

The cause is actually in the includes/functions_posting.php file:

Find:

Code: Select all

$attachrow_template_vars = array();

Replace with:

Code: Select all

// $attachrow_template_vars = array();

Seems to be working now! Can anyone test this please?

[Tarantino]

Great job! That fix it indeed!

[Marc]

Thanks for the input. The actual fix is slightly different from the temporary fix but the pointer certainly helped with tracking this down.

Pull request that will go into 3.2.3:
https://github.com/phpbb/phpbb/pull/5082

[canonknipser]

Official solution: https://github.com/phpbb/phpbb/pull/5082/files

Edit: Marc was quicker

[thecaretaker1]

Fantastic job. That did indeed fix it. Thanks to everyone involved.

[1024KBUser]

OK since I dont have shell access I manually changed functions_posting.php, Is this correct ?

Code: Select all

		($config['display_order']) ? krsort($attachment_data) : ksort($attachment_data);

		$attachrow_template_vars = [];

		foreach ($attachment_data as $count => $attach_row)
		{
			$hidden = '';
			// $attachrow_template_vars = array();
			$attach_row['real_filename'] = utf8_basename($attach_row['real_filename']);

			foreach ($attach_row as $key => $value)
			{
				$hidden .= '<input type="hidden" name="attachment_data[' . $count . '][' . $key . ']" value="' . $value . '" />';
			}

[</Solidjeuh>]

OK since I dont have shell access I manually changed functions_posting.php, Is this correct ?

Code: Select all

		($config['display_order']) ? krsort($attachment_data) : ksort($attachment_data);

		$attachrow_template_vars = [];

		foreach ($attachment_data as $count => $attach_row)
		{
			$hidden = '';
			// $attachrow_template_vars = array();
			$attach_row['real_filename'] = utf8_basename($attach_row['real_filename']);

			foreach ($attach_row as $key => $value)
			{
				$hidden .= '<input type="hidden" name="attachment_data[' . $count . '][' . $key . ']" value="' . $value . '" />';
			}

No, see: https://github.com/phpbb/phpbb/pull/5082/files

Code: Select all

		// We display the posted attachments within the desired order.
		($config['display_order']) ? krsort($attachment_data) : ksort($attachment_data);
		$attachrow_template_vars = [];

		foreach ($attachment_data as $count => $attach_row)
		{
			$hidden = '';
			$attach_row['real_filename'] = utf8_basename($attach_row['real_filename']);

			foreach ($attach_row as $key => $value)
			{
				$hidden .= '<input type="hidden" name="attachment_data[' . $count . '][' . $key . ']" value="' . $value . '" />';
			}

[1024KBUser]

Looks the same to me.