[CDB] Prime Links

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

[CDB] Prime Links

Post by primehalo » Sat Feb 03, 2018 11:24 pm

I've updated Prime Links to use an ACP module to set options and was hoping to find people to help me test it. I've tested it on phpBB 3.2 but it should also still be compatible with phpBB 3.1.

Extension Name: Prime Links
Author: primehalo

Description:
Modifies the attributes of links within posts (and/or private messages) based on whether the links are internal or external. This allows setting different classes so internal and external links look different, setting a target so links open in a new window, setting a nofollow, prefixing URLs such as to add an anonymizer or monetizer, and more.

Version: 1.1.1

Repository: https://github.com/primehalo/primelinks

Download: http://www.absoluteanime.com/_phpbb-ext ... elinks.zip

Change Log:
## [1.1.0 BETA 3] - 2018-02-09
### Added
- Applied external link attributes to member website links on the viewtopic page, excluding the class attribute because the links here are represented as icons.

### Changed
- For assigning template variables to the member list page, I switched from using a core event that was new to phpBB 3.2 to one that existed since phpBB 3.1.7 so that this extension can still be compatible with phpBB 3.1.

## [1.1.0 BETA 2]
### Added
- Applied external link attributes to member website links on the memberlist page.
- URL prefix option for internal links

### Changed
- Moved the JavaScript code from separate HTML files into a single HTML file
- Switched from phpBB template syntax to Twig template syntax

### Fixed
- A warning about the regular expression /e modifier not being supported in php 7.

Screenshots:
Image
Last edited by primehalo on Sat Apr 21, 2018 5:00 am, edited 8 times in total.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
spaceace
Registered User
Posts: 1796
Joined: Wed Jan 30, 2008 8:50 pm
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by spaceace » Sat Feb 03, 2018 11:51 pm

awesome :D

i will see what i come up with

nice to see you post here again ;)

User avatar
spaceace
Registered User
Posts: 1796
Joined: Wed Jan 30, 2008 8:50 pm
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by spaceace » Sun Feb 04, 2018 12:06 am

ok, that didn't take long to find this...
[phpBB Debug] PHP Warning: in file [ROOT]/ext/primehalo/primelinks/event/main_listener.php on line 156: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/ext/primehalo/primelinks/event/main_listener.php on line 157: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
looks like it needs the fix i posted here... https://www.phpbb.com/customise/db/mod/ ... 01#p528501

edit: that fix is working fine on my site

suggestion/request...
enable the member external links in the memberlist page

User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Sun Feb 04, 2018 12:48 am

Thanks, I'll make sure to update that.

Can you further explain your suggestion/request?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
jan_2017
Registered User
Posts: 129
Joined: Sun May 07, 2017 3:39 pm

Re: [3.1][3.2][BETA] Prime Links

Post by jan_2017 » Sun Feb 04, 2018 10:43 am

Any screenshots in action?

bye Jan

User avatar
spaceace
Registered User
Posts: 1796
Joined: Wed Jan 30, 2008 8:50 pm
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by spaceace » Sun Feb 04, 2018 11:16 am

primehalo wrote:
Sun Feb 04, 2018 12:48 am
Can you further explain your suggestion/request?
when in memberlist.php, users links just open normal. the prime links css is applied but does not open in a new window when set to open external links in a new window. would be nice to have prime links working throughout the whole board

User avatar
eunaumtenhoid
Registered User
Posts: 741
Joined: Wed Jun 03, 2009 12:46 am
Location: ????

Re: [3.1][3.2][BETA] Prime Links

Post by eunaumtenhoid » Sun Feb 04, 2018 2:56 pm

with this extension is it possible to put porpaganda link before the lins ??

as adf.lv ??

nice job, Good to see you bringing your old mod to 3.2 will bring any more?
My translations of the extensions for Brazilian Portuguese
https://github.com/phpBBTraducoes

User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Sun Feb 04, 2018 8:15 pm

eunaumtenhoid wrote:
Sun Feb 04, 2018 2:56 pm
with this extension is it possible to put porpaganda link before the lins ??

as adf.lv ??

nice job, Good to see you bringing your old mod to 3.2 will bring any more?
Could you explain this further? I don't understand what you mean.

I would like to convert more of my extensions to phpBB 3.2 extensions.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Wed Feb 07, 2018 11:33 pm

I uploaded v1.1.0 Beta 2 which addresses the issues and suggestions brought up in this thread.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
eunaumtenhoid
Registered User
Posts: 741
Joined: Wed Jun 03, 2009 12:46 am
Location: ????

Re: [3.1][3.2][BETA] Prime Links

Post by eunaumtenhoid » Thu Feb 08, 2018 12:44 pm

primehalo wrote:
Sun Feb 04, 2018 8:15 pm
eunaumtenhoid wrote:
Sun Feb 04, 2018 2:56 pm
with this extension is it possible to put porpaganda link before the lins ??

as adf.lv ??

nice job, Good to see you bringing your old mod to 3.2 will bring any more?
Could you explain this further? I don't understand what you mean.

I would like to convert more of my extensions to phpBB 3.2 extensions.
so...
look, user posted a link, but to access his link who click will be directed to another link that will then be directed to the original link, does this extension do this?
My translations of the extensions for Brazilian Portuguese
https://github.com/phpBBTraducoes

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 20854
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by RMcGirr83 » Thu Feb 08, 2018 2:03 pm

Welcome back Ken! :)

Github?
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
spaceace
Registered User
Posts: 1796
Joined: Wed Jan 30, 2008 8:50 pm
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by spaceace » Thu Feb 08, 2018 10:57 pm

primehalo wrote:
Wed Feb 07, 2018 11:33 pm
I uploaded v1.1.0 Beta 2 which addresses the issues and suggestions brought up in this thread.
1.0.0 BETA is still what you get from the link in your first post ;)

User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Thu Feb 08, 2018 11:10 pm

Sorry about that. I just fixed it.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
spaceace
Registered User
Posts: 1796
Joined: Wed Jan 30, 2008 8:50 pm
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by spaceace » Fri Feb 09, 2018 11:39 am

primehalo wrote:
Sat Feb 03, 2018 11:24 pm
## [1.1.0 BETA 2]
### Added
- Applied external link attributes to member website links on the memberlist page.
i will have to update my board to phpBB 3.2.2 to test this as the core event used was applied to the phpBB core in that version

also, composer.json needs the version updated in it ;)

pennino
Registered User
Posts: 139
Joined: Thu May 05, 2005 2:07 pm

Re: [3.1][3.2][BETA] Prime Links

Post by pennino » Fri Feb 09, 2018 3:00 pm

Congrats for this wonderful extension!
Tried with phpBB 3.2.2: everything OK except for the following:
- Prime Links does not manage "member website links" on profile pages, member pages and right colum in viewtopic (below the avatar).
"Enable for Member Website" is enabled.

Thank you so much!

Update: OK, I've just checked. In memberlist.php (member page + profile page) Prime Links uses JavaScript. The question is: it would be possible to add inline a rel="nofollow"?

In viewtopic.php, Prime Links does not manage the member website link under the avatar. It would be possible to do that and adding a rel="nofollow" into the anchor tag?

Best regards

Locked

Return to “Extensions in Development”

Who is online

Users browsing this forum: andares, igorbond, LapouX, obagley, pierredu and 15 guests