[3.2.9-3.3.x][RC] Glossary 3.0.20

BIABrewer · Post by **BIABrewer** » Fri Sep 07, 2018 3:48 am

Thanks Pierre,

Just managed to upload now. Install went fine but still having no luck when clicking on the Glossary Editor page. I gave Chrome, Vivaldi and Firefox a go.

One thing I did notice (not sure if it's any use) is that in both Chrome and Vivaldi, in the console, came up with an error...

"Unexpected token <" in the lmdi/gloss/styles/prosilver/theme/scroll.js file

Maybe I have too many extensions

pierredu · Post by **pierredu** » Sun Sep 09, 2018 9:25 am

I only have two '<' characters in this file, for <script> and </script>.
Therefore, I think the culprit could be a js file loaded before it, missing the closing angle bracket.

BIABrewer · Post by **BIABrewer** » Mon Sep 10, 2018 4:28 am

Thanks again Pierre. I will try and find the culprit and if I'm successful, I'll be sure to let you know.

BIABrewer · Post by **BIABrewer** » Mon Sep 10, 2018 5:39 am

Little bit more info...

On my test site, I disabled all extensions and then installed Glossary. The unexpected token error still came up when loading the Glossary Viewer, the Edition Page and also when pressing "Click here" on the Glossary Editions Page. I've attached a few pics some which include the other scripts loading.

Remember I have no coding skills

so have no idea if the above info helps at all. Please let me know though if there is anything else you'd like me to test or try.

Thanks again,
Pat

kasimi · Post by **kasimi** » Mon Sep 10, 2018 11:16 am

There are HTML tags in your scroll.js file which doesn't work. The <script> and </script> tags (first and last line) need to be removed.

pierredu · Post by **pierredu** » Mon Sep 10, 2018 1:50 pm

Thanks, kasimi.
I don't remember where this file comes from.
Some Web site about a top-scrolling function...

I'll update the package on github.

BIABrewer · Post by **BIABrewer** » Tue Sep 11, 2018 2:19 am

[Note: Have disabled vanilla board mentioned below as Pierre has fixed this. More details in my next post.]

Hi Pierre (and cheers @ kasimi)

I've just set up a test site that anyone can use if it helps. It's a completely vanilla install* of phpb3.2 on a completely different server.

I've set it up so, once registered (no approval needed) you are in the Editor group.

Unfortunately, the problem of nothing happening when you "click here" on the Glossary Editor page still exists.

Hope that helps a bit?
Pat

*Only change to vanilla install was correcting a known bug that exists in /forum_name/includes/functions_posting.php (I tried the uncorrected version of that file too but this had no effect on the "click here" problem. Adblock was another thing I tried but disabling that made no diff either sorry.)

I'll leave the test site unrestricted for now but will obviously have to limit it soon before too many spammers discover it

pierredu · Post by **pierredu** » Tue Sep 11, 2018 6:25 am

OK, I understand now.
I'll check my code as soon as possible.

A few moments later:
It is now corrected. A version 2.1.5 is on github.

BIABrewer · Post by **BIABrewer** » Tue Sep 11, 2018 12:37 pm

Nice job Pierre

The "click here" is now working perfectly on the vanilla site as well as on my main site (if I use Prosilver.)

Also noticed that your recent version fixed a few other things. For example, before I was having to create an editor group and add myself to it but now, I don't have to do that. (Checked some normal users and they can't so that's great!)

I had a try with my own style (Ravaio by Gramzui) by adding a copy of the lmdi/gloss/styles/prosilver folder but calling it lmdi/gloss/styles/ravaio. Didn't have any luck there but, it's a pretty advanced style but I'll see if I can remember how I got other extensions working with that style.

On the vanilla site I set up, I'll change you to an administrator but will set the board as disabled. Feel free to play with it for now if it helps.

Thanks again,
Pat

RomaamoR · Post by **RomaamoR** » Tue Sep 11, 2018 8:22 pm

RomaamoR wrote: ↑Fri Jan 22, 2016 8:12 pm Do not download pictures . Tried different formats .

It's been 3 years but I have a problem. How to install the insulation?

pierredu · Post by **pierredu** » Wed Sep 12, 2018 7:31 am

Can you be more explicit?

RomaamoR · Post by **RomaamoR** » Wed Sep 12, 2018 8:33 am

Images do not load like three years ago.

pierredu · Post by **pierredu** » Wed Sep 12, 2018 8:52 am

In the mean time, I changed the structure holding the image files.
In the past, the image folder was forum/ext/lmdi/gloss/glossaire.
I was told that my extension must keep its files in forum/store/lmdi/gloss
Caution, the folder must have correct access rights to upload the files.

RomaamoR · Post by **RomaamoR** » Wed Sep 12, 2018 9:12 am

Permissions on folder 0755. Files in the folder are downloaded.

pierredu · Post by **pierredu** » Wed Sep 12, 2018 10:18 am

If you do a right click on the broken link icon and ask about informations, what is the access path for the picture?