Known issues in 3.2.4

Get help with installation and running phpBB 3.2.x here. Please do not post bug reports, feature requests, or extension related questions here.
User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 5470
Joined: Tue Oct 30, 2007 10:57 pm
Location: Munich, Germany
Name: Marc
Contact:

Known issues in 3.2.4

Post by Marc »

After the release of phpBB 3.2.4 we've noticed an issue that can affect users with extensions that employ the generate_text_for_display() function.
A fix for this can be found on Github and will be included in the 3.2.5 release:
https://github.com/phpbb/phpbb/pull/5448/files
User avatar
3Di
Former Team Member
Posts: 16032
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Known issues in 3.2.4

Post by 3Di »

Thumbs up. :)
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
User avatar
</Solidjeuh>
Registered User
Posts: 1788
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: Known issues in 3.2.4

Post by </Solidjeuh> »

Thank you for the fix :D
User avatar
P_I
Registered User
Posts: 1228
Joined: Tue Mar 01, 2011 8:35 pm
Location: Staying home - Calgary
Contact:

Re: Known issues in 3.2.4

Post by P_I »

Marc wrote:
Sat Nov 17, 2018 10:35 pm
After the release of phpBB 3.2.4 we've noticed an issue that can affect users with extensions that employ the generate_text_for_display() function.
A fix for this can be found on Github and will be included in the 3.2.5 release:
https://github.com/phpbb/phpbb/pull/5448
Thanks for the quick update and fix.

Has anyone started to compile a list of extensions that employ this call or is it up the end users to scan their ext directory for calls to the function before deciding to update their boards to 3.2.4.

Added: So far I've found that the Board Rules extension makes this call.
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams
User avatar
3Di
Former Team Member
Posts: 16032
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Known issues in 3.2.4

Post by 3Di »

Almost all of my recent and large extensions make use of it.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
User avatar
david63
Registered User
Posts: 18311
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: Known issues in 3.2.4

Post by david63 »

My Privacy Policy and User Details extensions use this function.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 4561
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: Known issues in 3.2.4

Post by kasimi »

It only affects extensions that render rich text in the old style format used in phpBB 3.1.x and earlier. In phpBB 3.2.x the content is saved in the database as XML. When calling generate_text_for_display() with XML content, the bugged code is not called. So this only affects extensions written before 3.2.x that haven't migrated to the new XML format yet. For example, mChat 2.1.x uses the new XML format exclusively and therefore is not affected, while mChat 2.0.x is.
User avatar
bubbathegimp
Registered User
Posts: 164
Joined: Tue Sep 25, 2018 8:02 pm
Location: Off Plumb
Name: Bubba
Contact:

Re: Known issues in 3.2.4

Post by bubbathegimp »

I downloaded the fix, but being a complete noob, I have no Idea of how to apply it...
Beans: Because just saying we need to socially distance doesn't always work....
User avatar
P_I
Registered User
Posts: 1228
Joined: Tue Mar 01, 2011 8:35 pm
Location: Staying home - Calgary
Contact:

Re: Known issues in 3.2.4

Post by P_I »

kasimi wrote:
Sun Nov 18, 2018 9:31 am
It only affects extensions that render rich text in the old style format used in phpBB 3.1.x and earlier. In phpBB 3.2.x the content is saved in the database as XML. When calling generate_text_for_display() with XML content, the bugged code is not called. So this only affects extensions written before 3.2.x that haven't migrated to the new XML format yet. For example, mChat 2.1.x uses the new XML format exclusively and therefore is not affected, while mChat 2.0.x is.
Thanks for this additional information.

On the boards I'm involved with I've scanned for calls to generate_text_for_display() and so far only the Board Rules extension makes this call. Rather than dig further into the code and database, I've asked the extension developers if the extension is affected or not. Since there is a 3.2.x and 3.1.x version of the extension I'm guessing not but I'd rather have the developers confirm to be sure.
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams
User avatar
invenio
Registered User
Posts: 151
Joined: Wed Dec 09, 2015 1:45 pm
Location: New Hampshire, USA
Contact:

Re: Known issues in 3.2.4

Post by invenio »

Marc wrote:
Sat Nov 17, 2018 10:35 pm
A fix for this can be found on Github and will be included in the 3.2.5 release:
Any estimate when we should see 3.2.5? If it's coming soon I would rather hold off on the update.
rxu
Extensions Development Team
Posts: 3391
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: Known issues in 3.2.4

Post by rxu »

The issue also affects boards freshly converted from 2.0/3.0/3.1 to 3.2 (where text is not reparsed to XML yet).
Swanny
Registered User
Posts: 457
Joined: Sun Apr 14, 2002 2:11 am
Location: Canada

Re: Known issues in 3.2.4

Post by Swanny »

Can you update the 3.2.4 code package right now so people from now on doing the upgrade aren't affected? I haven't upgraded to 3.2.4 yet, I usually wait a few days after release in case there are known "bugs".
User avatar
Forex Station
Registered User
Posts: 112
Joined: Thu Apr 06, 2017 2:26 pm
Location: Australia

Re: Known issues in 3.2.4

Post by Forex Station »

Swanny wrote:
Sun Nov 18, 2018 3:45 pm
Can you update the 3.2.4 code package right now so people from now on doing the upgrade aren't affected? I haven't upgraded to 3.2.4 yet, I usually wait a few days after release in case there are known "bugs".
Same here haha. I get a bit nervous now with the updates. Even though we don't run many extensions we've had a couple of issues in the past like that one update that made it unable to upload attachments. Everyone on our forum had a fit :shock:
Proudly powered by phpBB for almost 4 years now: forex-station.com :mrgreen:
Global Alexa rank: 40,500
User avatar
Crizzo
Translations & International Support Teams Manager
Translations & International Support Teams Manager
Posts: 1252
Joined: Thu Apr 23, 2009 1:20 pm
Location: Germany
Name: Christian
Contact:

Re: Known issues in 3.2.4

Post by Crizzo »

Swanny wrote:
Sun Nov 18, 2018 3:45 pm
Can you update the 3.2.4 code package right now so people from now on doing the upgrade aren't affected? I haven't upgraded to 3.2.4 yet, I usually wait a few days after release in case there are known "bugs".
This would lead to two different versions with the same name/number and would lead to a mess.
My extensions for phpBB: crizzo.de
German phpBB Support at www.phpbb.de
User avatar
janus_zonstraal
Registered User
Posts: 4808
Joined: Sat Aug 30, 2014 1:30 pm

Re: Known issues in 3.2.4

Post by janus_zonstraal »

And offer a download with know errors will lead not to a mess?
Why not give it a other name as phpbb did in the past? phpbb3.2.4_fix
Sorry! My English is bat ;) !!!
Locked

Return to “[3.2.x] Support Forum”