[3.2][3.3][RC] TCS - Topic Cement and Style 👨‍🎨

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
3Di
Former Team Member
Posts: 15697
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Topic Cement Style

Post by 3Di »

shortmort37 wrote:
Tue Mar 05, 2019 11:56 am
I'm unclear on exactly what this means. Should I declare something like this, instead?

'topic_priority' => array('INT:11', 0),

Where does -2,147,483,648 come from, anyway? I know that the least negative number that can be represented in 16 bits (base 2) is -32,768. The least negative number for 11 digits in base 10 would be -99,999,999,999 - no?
1 - Yes.
2 - http://www.mysqltutorial.org/mysql-int/ / https://wiki.phpbb.com/Database_Type_Map#Numeric
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
shortmort37
Registered User
Posts: 516
Joined: Sat Aug 26, 2006 8:40 pm
Location: Upper Darby, PA, USA
Name: Dan Morton
Contact:

Re: [3.2][BETA] Topic Cement Style

Post by shortmort37 »

Ah; the largest range that can be specified in 32 bits. BTW, that range is incorrect; it should be -2,147,483,648 to 2,147,483,647.
User avatar
3Di
Former Team Member
Posts: 15697
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Topic Cement Style

Post by 3Di »

shortmort37 wrote:
Tue Mar 05, 2019 9:51 pm
Ah; the largest range that can be specified in 32 bits.
No, INT has a storage 4 bytes, that's all.
shortmort37 wrote:
Tue Mar 05, 2019 9:51 pm
BTW, that range is incorrect; it should be -2,147,483,648 to 2,147,483,647.
Feel free to correct the Wiki, you can. :)

On a side note, such change should be done within a new migration which depends on the parent, not on an installed extension for sure.
Btw, there could be someone who assigned a priority of ie.: 4294967295 and downgrading the capacity could lead to issues.
Moreover, there is not a minimum/maximum input's error handling in the HTMl anymore, another issue.

Again, I am discouraging the readers to apply such change if not approved (and therefore deeply tested) by us.

Glad to evaluate suggestions/ideas/PRs for this project if done here: https://github.com/phpBB-Studio/TopicCe ... new/choose
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
3Di
Former Team Member
Posts: 15697
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Topic Cement Style

Post by 3Di »

v1.1.1-beta released - see first post.

This version fixes a couple of issues and needs phpBB 3.2.7 to be installed.

For all those who have already downloaded the extension, the update is simple:

1 - disable and DELETE DATA
2 - delete folder
3 - upload new folder
4 - enable
5 - purge cache

:geek:
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
Steppenwind
Registered User
Posts: 19
Joined: Sat Sep 21, 2019 10:00 am

Re: [3.2][BETA] TCS - Topic Cement Style

Post by Steppenwind »

This is a very neat extension, thank you.

One suggestion:

In my opinion the TCS options only need to be displayed when creating (or editing) sticky posts - other than that (while writing regular posts) they're only in the way.

Would it be possible to make them collapsable?
User avatar
3Di
Former Team Member
Posts: 15697
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style

Post by 3Di »

We make a differentiation between topic and post and have a better view.
We extend the faculty to all types of topics, I don't understand why only stickies should be taken into account, so no.
That's fine since is a topic cement application. Posts (which follow the topic) do not have it.

To collapse the options menu is something that is already on the table, it will be for the next version.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
shortmort37
Registered User
Posts: 516
Joined: Sat Aug 26, 2006 8:40 pm
Location: Upper Darby, PA, USA
Name: Dan Morton
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style

Post by shortmort37 »

Will a version of this extension that works with 3.3.0 be released any time soon?

Thanks in advance,
Dan
User avatar
3Di
Former Team Member
Posts: 15697
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style

Post by 3Di »

If you want to go ahead and test it you could change the line #36 in ext.php to be:

Code: Select all

if ( !(phpbb_version_compare(PHPBB_VERSION, '3.2.7', '>=') && phpbb_version_compare(PHPBB_VERSION, '4.0.0@dev', '<')) )
Though no support for 3.3 is given here till we will release a new official version for.

Any issue with 3.3 should be reported at our tracker at GitHub: https://github.com/phpBB-Studio/TopicCementStyle/issues
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
3Di
Former Team Member
Posts: 15697
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style 👨‍🎨

Post by 3Di »

Steppenwind wrote:
Tue Oct 22, 2019 7:56 am
...

Would it be possible to make them collapsable?
Yes: https://github.com/phpBB-Studio/TopicCe ... e/issues/1
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
shortmort37
Registered User
Posts: 516
Joined: Sat Aug 26, 2006 8:40 pm
Location: Upper Darby, PA, USA
Name: Dan Morton
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style

Post by shortmort37 »

3Di wrote:
Mon May 04, 2020 8:14 pm
If you want to go ahead and test it you could change the line #36 in ext.php to be:

Code: Select all

if ( !(phpbb_version_compare(PHPBB_VERSION, '3.2.7', '>=') && phpbb_version_compare(PHPBB_VERSION, '4.0.0@dev', '<')) )
Though no support for 3.3 is given here till we will release a new official version for.

Any issue with 3.3 should be reported at our tracker at GitHub: https://github.com/phpBB-Studio/TopicCementStyle/issues
I made a change to permit the extension to load. I did report an issue here: https://github.com/phpBB-Studio/TopicCe ... e/issues/2

I'm not sure if it's an issue in 3.2.7 or not - I've since upgraded both my prod and test environments to 3.3.0, which is where I first discovered the issue. But it may have been there before, and I just didn't notice it.

Dan
User avatar
3Di
Former Team Member
Posts: 15697
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style 👨‍🎨

Post by 3Di »

Well done, thanks.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
shortmort37
Registered User
Posts: 516
Joined: Sat Aug 26, 2006 8:40 pm
Location: Upper Darby, PA, USA
Name: Dan Morton
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style 👨‍🎨

Post by shortmort37 »

What are the prospects for getting a bug fix for this anytime soon? I did determine that the bug is present in 3.2.7 as well.

-Dan
User avatar
3Di
Former Team Member
Posts: 15697
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style 👨‍🎨

Post by 3Di »

Please follow the ticket, I left a comment just now:
https://github.com/phpBB-Studio/TopicCe ... -628347932

Oh, no need to PM me for support. I do ignore those kind of PMs actually.

Thanks in advance. :)
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
shortmort37
Registered User
Posts: 516
Joined: Sat Aug 26, 2006 8:40 pm
Location: Upper Darby, PA, USA
Name: Dan Morton
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style 👨‍🎨

Post by shortmort37 »

3Di wrote:
Thu May 14, 2020 2:32 am
Please follow the ticket, I left a comment just now:
https://github.com/phpBB-Studio/TopicCe ... -628347932
That seems to have fixed it! Thanks!

Dan
User avatar
3Di
Former Team Member
Posts: 15697
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] TCS - Topic Cement Style 👨‍🎨

Post by 3Di »

Thanks for feedback.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
Post Reply

Return to “Extensions in Development”