[BETA] Filter by country - version 1.0.8

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
BF79
Registered User
Posts: 272
Joined: Fri Feb 13, 2015 1:28 pm

Re: [RC] Filter by country - version 1.0.6

Post by BF79 » Sun Sep 01, 2019 10:32 pm

great idea this extension !!! thanks my friend but is possible to filter just proxies and vpn... ?

User avatar
MarkDHamill
Registered User
Posts: 3943
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Filter by country - version 1.0.6

Post by MarkDHamill » Sun Sep 01, 2019 10:47 pm

I hadn't thought about that as a feature. As release candidate the features are supposed to be set. But I can look into it.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

BF79
Registered User
Posts: 272
Joined: Fri Feb 13, 2015 1:28 pm

Re: [RC] Filter by country - version 1.0.6

Post by BF79 » Sun Sep 01, 2019 11:01 pm

MarkDHamill wrote:
Sun Sep 01, 2019 10:47 pm
I hadn't thought about that as a feature. As release candidate the features are supposed to be set. But I can look into it.
thanks my friend !! filter just proxies and vpn is very useful + banned ip redirected to google is also good thing ;)

User avatar
</Solidjeuh>
Registered User
Posts: 1732
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: [RC] Filter by country - version 1.0.6

Post by </Solidjeuh> » Sun Sep 01, 2019 11:48 pm


User avatar
EA117
Registered User
Posts: 1084
Joined: Wed Aug 15, 2018 3:23 am
Contact:

Re: [RC] Filter by country - version 1.0.6

Post by EA117 » Sun Sep 01, 2019 11:59 pm

MarkDHamill wrote:
Sun Sep 01, 2019 10:47 pm
I hadn't thought about that as a feature. As release candidate the features are supposed to be set. But I can look into it.
I thought that had been the difference at the outset, regarding "we're not requiring that you obtain a paid MaxMind database." Since the GeoIP2 Anonymous IP Database requires paid access.

Or are you thinking of leveraging the informal observation of "if the address block isn't attributed to a country in the free countries database, it's because its part of something which might be a VPN or proxy." i.e. We can't confirm what the address actually is (because that would require the Anonymous IP Database), but we could allow to "restrict this address because it doesn't appear in the country database", which probably blocks VPNs, proxies and maybe some other things.

Isn't that something the extension already does? i.e. When control was introduced for what action should be taken for an "unknown" address, in database terms?

User avatar
MarkDHamill
Registered User
Posts: 3943
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Filter by country - version 1.0.6

Post by MarkDHamill » Mon Sep 02, 2019 1:59 am

I assume if the extension returns essentially "an IP is not in the database" message from the MaxMind country code database then it is likely a VPN address, but it could be some new set of IPs that will get assigned to a country at some point and appear in the database. As noted, the Anonymous IP database from MaxMind is not a free product and I would prefer not to get into that.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
KlausiMaus
Registered User
Posts: 143
Joined: Sat Nov 15, 2014 4:55 pm

Re: [RC] Filter by country - version 1.0.6

Post by KlausiMaus » Tue Sep 03, 2019 2:29 pm

MarkDHamill wrote:
Sun Sep 01, 2019 7:20 pm
The first issue is due to how you have PHP configured.
No, the configuration is correct!
I think it is a missing flag for unknown countries.

Image

MarkDHamill wrote:
Sun Sep 01, 2019 7:20 pm
Version check not working is a fair point.
Will we get a working version check with the next release?
Klaus (http://forum.kuhnert.ch/) :: Keep it simple, stupid :!:

User avatar
MarkDHamill
Registered User
Posts: 3943
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Filter by country - version 1.0.6

Post by MarkDHamill » Tue Sep 03, 2019 3:28 pm

Yes, I should have a work around in the next version. Your situation should only occur though file_exists() triggers a warning, which should only happen if some parts of searchable paths on your server are not accessible. This is typically due to issues with permission on a /tmp folder.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
canonknipser
Registered User
Posts: 2096
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: [RC] Filter by country - version 1.0.6

Post by canonknipser » Tue Sep 03, 2019 4:14 pm

Mark, do you use ??.png for the unknown countries? Maybe that is a problem with windows because ? is a wildcard on windows file systems ...
Better use something like ##.png
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

User avatar
MarkDHamill
Registered User
Posts: 3943
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Filter by country - version 1.0.6

Post by MarkDHamill » Tue Sep 03, 2019 4:37 pm

Interesting thought. This is a constant easily changed. Thanks.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
KlausiMaus
Registered User
Posts: 143
Joined: Sat Nov 15, 2014 4:55 pm

Re: [RC] Filter by country - version 1.0.6

Post by KlausiMaus » Tue Sep 03, 2019 7:21 pm

canonknipser wrote:
Tue Sep 03, 2019 4:14 pm
Mark, do you use ??.png for the unknown countries? Maybe that is a problem with windows because ? is a wildcard on windows file systems ...
Better use something like ##.png
There is no flag for unknown country defined, when I change settings so that VPN unknown disappear the error is gone!
Klaus (http://forum.kuhnert.ch/) :: Keep it simple, stupid :!:

User avatar
canonknipser
Registered User
Posts: 2096
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: [RC] Filter by country - version 1.0.6

Post by canonknipser » Tue Sep 03, 2019 7:56 pm

KlausiMaus wrote:
Tue Sep 03, 2019 7:21 pm
There is no flag for unknown country defined
But the extension is looking up for a file named ??.png - it would be displayed, if that file exists. ->
KlausiMaus wrote:
Tue Sep 03, 2019 7:21 pm
when I change settings so that VPN unknown disappear the error is gone
- no unknown country, no lookup for that file ...
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

User avatar
KlausiMaus
Registered User
Posts: 143
Joined: Sat Nov 15, 2014 4:55 pm

Re: [RC] Filter by country - version 1.0.6

Post by KlausiMaus » Tue Sep 03, 2019 8:05 pm

@canonknipser: A perfect analysis, but no solution.
Klaus (http://forum.kuhnert.ch/) :: Keep it simple, stupid :!:

User avatar
canonknipser
Registered User
Posts: 2096
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: [RC] Filter by country - version 1.0.6

Post by canonknipser » Tue Sep 03, 2019 8:29 pm

KlausiMaus wrote:
Tue Sep 03, 2019 8:05 pm
but no solution.
It's up to Mark (and you as his tester after he changed his extension) to create a solution, I just gave a idea for a possible reason for the error.
KlausiMaus wrote:
Tue Sep 03, 2019 8:05 pm
A perfect analysis
And 99% of an error solution is error analysis - so 99% is done :ugeek:
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

User avatar
warmweer
Registered User
Posts: 3059
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Belt ... well actually Belgium

Re: [RC] Filter by country - version 1.0.6

Post by warmweer » Tue Sep 03, 2019 8:32 pm

canonknipser wrote:
Tue Sep 03, 2019 8:29 pm
And 99% of an error solution is error analysis - so 99% is done :ugeek:
But it's always the remaining 1% which is the real PITA. :lol:
The year is 2192. The British Prime Minister visits Brussels to ask for an extension of the Brexit deadline. No one remembers where this tradition originated, but every year it attracts many tourists from all over the world.

Post Reply

Return to “Extensions in Development”