AbelaJohnB wrote: Stop using the ENTIRE LINE for your "FIND" statements... you only need a small fraction of the line, not the entire line, when doing a FIND-INLINE. Some of us have other MOD's installed and when MOD Authors do a FIND on the entire line, it means we end-users have to go into your MOD and fix this. Not fun.
AbelaJohnB wrote: VARCHAR( 255 ) -- Hmm, last I recall Jabber doesn't allow 255 character usernames. Reduce this some and save us a small about of db bloating.
AbelaJohnB wrote: Include the xmpp integration within a /contrib/ directory so we don't have to hunt it down from your website.
AbelaJohnB wrote: Beyond that, works well. I know of a few people who will be grateful to see this MOD in action!
ptlis wrote:AbelaJohnB wrote: VARCHAR( 255 ) -- Hmm, last I recall Jabber doesn't allow 255 character usernames. Reduce this some and save us a small about of db bloating.
Actually, limiting it to VARCHAR(255) is actually a rather conservative limit as the Jabber protocol has a limit of 1023 characters
ptlis wrote:AbelaJohnB wrote:Include the xmpp integration within a /contrib/ directory so we don't have to hunt it down from your website.
Ah, once again in future revisions I will do such, but in this instance the 'metamodificaion' to allow people to use the xmpp:// URI was made a week or two after i'd resubmitted the modification for validation.
ptlis wrote: Actually, I am looking at either grabbing the phpBB 3 source from cvs and backporting the Jabber class to phpBB 2.0.x or looking at this GPL'd Jabber class with the aim of being able to inform users if people are online. If I do do this it should be (relatively) trivial to add such functionality. If I did do that however i'd probably release it as a seperate MOD such that people who want their users to be able to post their jabber details but don't want the overhead the rest would require can still use this.
Code: Select all
#
#-----[ OPEN ]------------------------------------------------
#
language/lang_english/lang_main.php
#
#-----[ FIND ]------------------------------------------------
#
$lang['JABBER'] = 'Jabber';
#
#-----[ REPLACE WITH ]----------------------------------------
#
$lang['JABBER'] = 'Google Talk';
#
#-----[ SAVE/CLOSE ALL FILES ]--------------------------------
#
# EoM
stordoff wrote: Quick Way:
In notepad, use the replace tool to replace all JABBER with GTALK
ie, Edit > Replace > Find What = Jabber > Replace With = GTALK > Repalce All