[3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Ticinoforum
Registered User
Posts: 25
Joined: Sat Mar 02, 2019 9:19 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Ticinoforum »

KYPREO wrote:
Mon Jan 06, 2020 11:44 pm
I don't mean this to be insensitive as no doubt this has caused you some agony and wasted time - I've been there myself. However, the upgrade documentation clearly states that you need to disable all extension before upgrading between major versions. Also, this is why everyone should test upgrades on a local host test environment before trying it on a live board.
I agree, usually I test on local and than put online. I made it many time.
This time, I don't know why, I was confidente and made directly online!
But "backup" was invented exactly for this circumstance! :)

Anyway, hope this nice EXT is fixed soon!
Ticino Forum 4.0
ADMINISTRATOR
User avatar
Naguissa
Registered User
Posts: 374
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

Yes, I'm currently working on this.

Thanks about the info about clearing data, it helps me and saves me few tests.

It's still not working, as I have to update my local site, do the recoding and then test it on (updated) preprod and prod environments, but I'm working on this....
User avatar
mrgoldy
Development Team Member
Development Team Member
Posts: 1394
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by mrgoldy »

You'll have to update your routing.yml file.
pattern: is deprecated (well, was deprecated for a while and now removed).
It should be replaced with path:.
It's also best to encapsulate all strings in singular quotes.

Code: Select all

gfksx_ThanksForPosts_thankslist_controller_user:
    path: /thankslist/{mode}/{author_id}/{give}
    defaults: { _controller: gfksx.ThanksForPosts.controller.thankslist:main, top: 0, start: 0, sort_key: "a", sort_dir: "d", topic_id: 0, return_chars: 300 }
    requirements:
        mode: \w+
        author_id: \d+
        give: true|false
        top: \d+
        start: \d+
        topic_id: \d+
        return_chars: \d+

gfksx_ThanksForPosts_thankslist_controller:
    path: /thankslist
    defaults: { _controller: gfksx.ThanksForPosts.controller.thankslist:main, mode: "", author_id: 1, give: "", top: 0, start: 0, sort_key: "e", sort_dir: "d", return_chars: 300 }
    requirements:
        author_id: \d+
        top: \d+
        start: \d+
        return_chars: \d+

gfksx_ThanksForPosts_toplist_controller_mode:
    path: /toplist/{mode}
    defaults: { _controller: gfksx.ThanksForPosts.controller.toplist:main, mode: "", start: 0, return_chars: 300 }
    requirements:
        mode: \w+
        start: \d+
        return_chars: \d+

gfksx_ThanksForPosts_toplist_controller:
    path: /toplist
    defaults: { _controller: gfksx.ThanksForPosts.controller.toplist:main, mode: "", start: 0, return_chars: 300 }
    requirements:
        mode: \w+
        start: \d+
        return_chars: \d+
Simple regex statements can be left unquoted, such as \d+ and \w+, but with more advanced regex, you should quote those aswell with double quotes. For example [A-Za-z0-9_] would be interpreted as an array, while "[A-Za-z0-9_]" will be correctly used as a regex.
phpBB Studio / Member of the Studio

Contributing: You can do it too! Including testing Pull Requests (PR).
phpBB Development and Testing made easy.
User avatar
bubbathegimp
Registered User
Posts: 172
Joined: Tue Sep 25, 2018 8:02 pm
Location: Off Plumb
Name: Bubba
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by bubbathegimp »

Cant wait to add this to 3.30 when it becomes available :D
If at first you don't succeed, Sky diving is not for you....
Ymmv
User avatar
Ticinoforum
Registered User
Posts: 25
Joined: Sat Mar 02, 2019 9:19 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Ticinoforum »

mrgoldy wrote:
Tue Jan 07, 2020 3:15 pm
You'll have to update your routing.yml file.
pattern: is deprecated (well, was deprecated for a while and now removed).
It should be replaced with path:.
It's also best to encapsulate all strings in singular quotes.
I just tried this solution.
Board at least start, but generate "fatal error" asap I try to read a topic/post.
This is the error:

Fatal error: Uncaught phpbb\notification\exception: NOTIFICATION_TYPE_NOT_EXIST in phpbb\notification\manager.php:915
Stack trace: #0 phpbb\notification\manager.php(951): phpbb\notification\manager->get_notification_type_id('gfksx.thanksfor...')
[...] and similar...

Thanks.
Ticino Forum 4.0
ADMINISTRATOR
User avatar
mrgoldy
Development Team Member
Development Team Member
Posts: 1394
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by mrgoldy »

Well, that’s a completely different. I just provided the routing.yml fixes.
phpBB Studio / Member of the Studio

Contributing: You can do it too! Including testing Pull Requests (PR).
phpBB Development and Testing made easy.
User avatar
Naguissa
Registered User
Posts: 374
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

Thanks to all for providing all that info, very appreciate!
User avatar
Ticinoforum
Registered User
Posts: 25
Joined: Sat Mar 02, 2019 9:19 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Ticinoforum »

Naguissa wrote:
Tue Jan 07, 2020 10:07 pm
Thanks to all for providing all that info, very appreciate!
Thanks to you mate for the EXT!
So, are you working to fix it?
Ticino Forum 4.0
ADMINISTRATOR
User avatar
Naguissa
Registered User
Posts: 374
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

Ticinoforum wrote:
Fri Jan 10, 2020 9:27 am
Naguissa wrote:
Tue Jan 07, 2020 10:07 pm
Thanks to all for providing all that info, very appreciate!
Thanks to you mate for the EXT!
So, are you working to fix it?
Yes, it's only that I have a lot of work and have less time than desired to work on it.
User avatar
Ticinoforum
Registered User
Posts: 25
Joined: Sat Mar 02, 2019 9:19 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Ticinoforum »

Naguissa wrote:
Fri Jan 10, 2020 9:37 am
Yes, it's only that I have a lot of work and have less time than desired to work on it.
Take your time, we will wait :!:
Ticino Forum 4.0
ADMINISTRATOR
User avatar
Naguissa
Registered User
Posts: 374
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

By the moment:

I've updated my local copy of the forum (disabled all extensions and languages, updated and then enable only this extension).

After I've applied mrgoldy fix for routing forum works and thanks/remove actions works, but still some warnings on notifications. I've to fix these and properly test all other functionality.
mlankton
Registered User
Posts: 11
Joined: Tue May 01, 2018 2:05 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by mlankton »

updating routing.yml worked for me, thank you so much!
mlankton
Registered User
Posts: 11
Joined: Tue May 01, 2018 2:05 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by mlankton »

mlankton wrote:
Tue Jan 14, 2020 4:19 pm
updating routing.yml worked for me, thank you so much!
ah but yeah the notifications are blank now.

I appreciate the author getting this to work. It adds a much needed function to phpbb.
User avatar
Naguissa
Registered User
Posts: 374
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

mlankton wrote:
Tue Jan 14, 2020 6:48 pm
mlankton wrote:
Tue Jan 14, 2020 4:19 pm
updating routing.yml worked for me, thank you so much!
ah but yeah the notifications are blank now.

I appreciate the author getting this to work. It adds a much needed function to phpbb.
Yes, that's just the problem I'm debugging now. I've been looking for any bug in phpbb because notifiation is getting null data instead its data....
mlankton
Registered User
Posts: 11
Joined: Tue May 01, 2018 2:05 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by mlankton »

the blank notifications all have timestamp
Wed Dec 31, 1969 6:00 pm

no other notifications show the incorrect date like this

hope this helps
Post Reply

Return to “Extensions in Development”