[3.3][RC] Filter by country - version 1.0.12

[MarkDHamill]

I would think you'd want to make it:

Code: Select all

			phpbb_version_compare($config['version'], '3.2.0', '>=') &&
			phpbb_version_compare($config['version'], '3.3', '<=') &&

You can make permissions on the /store/phpbbservices folder 0777 and see if that works.

[warmweer]

phpbb_version_compare($config['version'], '3.2.0-a1', '>=') &&

Doesn't this result in phpBB 3.2.0 not being supported (since 3.2.0 < 3.2.0-a1)? (it looks illogical but in alphanumeric order 3.2.0 is smaller than3.2.0-a1).

[mastnacek]

warmweer: on that version does not metter. With 3.2.0-a1 installed, with 3.2.0 installed.

Premmision set but same error
Unable to create the MaxMind country codes database. This may be due to insufficient permissions or an invalid license key. The file permissions for the forum’s /store/phpbbservices folder should be set to publicly writeable (777 on Unix-based systems).

[MarkDHamill]

Did anyone test on 3.2 to see if it worked there?

[MarkDHamill]

Sorry about the problem. In /core/common.php on lines 55-59 replace:

Code: Select all

		// If the license key is blank or not 16 characters, the database cannot be downloaded, so exit this function.
		if (strlen(trim($this->config['phpbbservices_filterbycountry_license_key'])) !== 16)
		{
			return false;
		}

with:

Code: Select all

		// If on the settings page, we return true, otherwise, the screen can't come up to enter a new or corrected license key.
		if (stripos($this->user->page['query_string'], 'mode=settings'))
		{
			return true;
		}
		else
		{
			// If the license key is blank or not 16 characters, the database cannot be downloaded, so exit this function.
			if (strlen(trim($this->config['phpbbservices_filterbycountry_license_key'])) !== 16)
			{
				return false;
			}
		}

This should allow you to enter a new license key.

I'll update the 1.0.9 archive with the correction.

[mastnacek]

Works. License succesfully generated and used.

[MarkDHamill]

One other thing. I was testing and neglect to revert some code. So in /event/main_listener.php lines 142-145 may be:

Code: Select all

		$test_mode = true;
		if ($test_mode)
		{
			$test_ips[] = '128.101.101.101';	// For testing, United States IP

If so it should be:

Code: Select all

		$test_mode = false;
		if ($test_mode)
		{
			//$test_ips[] = '128.101.101.101';	// For testing, United States IP

I'll update the archive.

The effect of not changing anything is to make all traffic counted by the extension use 128.101.101.101 for the IP.

[MarkDHamill]

Version 1.0.9 is finally on GitHub:

https://github.com/MarkDHamill/filterby ... tree/1.0.9

A list of file changes since 1.0.8 can be seen here.

If you download it from GitHub, make sure to place it in a /ext/phpbbservices/filterbycountry directory.

[mastnacek]

works, but same problem with phpbb version.

[MarkDHamill]

It hasn't been tested for phpBB 3.3 yet, so ext.php still constrains it to PHP 3.2.

[focp]

Did anyone test on 3.2 to see if it worked there?

once i'd got a Maxmind licence key it worked fine on 3.2.9

[MarkDHamill]

A version of the extension that supports phpBB 3.3 is released! See the first post for download links.

One other bug was noticed and fixed: double statistical entries were being made, so I had to reexamine and fix that logic. Otherwise, other than asserting that it works on 3.3, no other changes were made. It also works on 3.2.

A list of changes since version 1.0.9 can be seen here:

https://github.com/MarkDHamill/filterby ... 9...1.0.10

If downloaded from GitHub, select the 1.0.10 branch, download and expand it, disable the extension, remove its files, then upload the new files.

Upgrading extensions from phpBB 3.2 to 3.3 so far is much less hassle than from 3.1 to 3.2, thank goodness.

[KlausiMaus]

There is still

Code: Select all

  "version": "1.0.9-beta", 

in the composer.json

[MarkDHamill]

Thanks. I updated the archive. It is correct on GitHub.

[KlausiMaus]

I tried to update from 1.0.9 on an 3.3.0 board and get this message, when i try to activate the extension:

Information

To install this extension, the store directory must be writable (0777 Unix file permissions). The allow_url_fopen directive must be enabled. The following PHP extensions are required: curl, dom and Phar. This extension works with phpBB 3.2 only.

Does that mean it is not phpBB 3.3.0 compatible? I try to switch back.