[3.2.9-3.3.x][RC] Glossary 3.0.20

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Bymemor
Registered User
Posts: 154
Joined: Sun Dec 01, 2019 7:55 pm

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by Bymemor »

First, thanks for this great extension.

Please, could someone teach me how can user search for term in the glossary ?

I use phpBB navbar search extension but it is not able to find glossary terms.
User avatar
pierredu
Registered User
Posts: 1274
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by pierredu »

When the extension is installed, there should be a link in the navbar. Click on it and the extension will display a table with all glossary items. Use CTRL F to make a search. You also have a series of links toward the initial letters of the items.
User avatar
Bymemor
Registered User
Posts: 154
Joined: Sun Dec 01, 2019 7:55 pm

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by Bymemor »

Yeah, it sounds great, but if you imagine glossary with 30.000 terms it is hard to find the word with link to their first letters. Ctrl+ F is great for desktop, but when it comes to phone and mobile users and also web-view apps it doesn't work for them. Sure there are also ways to find word in page inside mobile browser settings, but it is not practical.

So, what would I suggest ?

Writing a little script that make it possible on glossary page to find words like browser's find in page function. I understand that I can't want that from you, but it would be useful and amazing if you make search bar for glossary page if you have time.

And I already found script like I wanted , but this just doesn't work only on Safari (browser for apple devices).

Here's the link for that script : http://www.javascripter.net/faq/searchin.htm

Maybe you could improve this code and hopefully add search bar to glossary page.
User avatar
pierredu
Registered User
Posts: 1274
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by pierredu »

The glossary can't be a dictionnary. On my board, there are 700+ terms. To manage 30000 terms, you would need another tool, IMHO.
ghswen
Registered User
Posts: 54
Joined: Sun Apr 21, 2019 9:04 pm

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by ghswen »

Hi,

I have installed the Glossary and can everything works fine, until I attempt to create a new glossary term. I'm running phpBB 3.3.0 w/ PHP Version 7.3.17-1.

Here's the SQL error I'm getting:

General Error
SQL ERROR [ mysqli ]

In aggregated query without GROUP BY, expression #2 of SELECT list contains nonaggregated column 'AstronomyphpBB.phpbb_glossary.term_id'; this is incompatible with sql_mode=only_full_group_by [1140]

SQL

SELECT COUNT(*) as nb, term_id FROM phpbb_glossary WHERE term = 'Deep-Sky Object'

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 1023
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 195
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 345
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/ext/lmdi/gloss/core/helper.php
LINE: 286
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/ext/lmdi/gloss/core/glossnew.php
LINE: 138
CALL: lmdi\gloss\core\helper->existe_rubrique()

FILE: [ROOT]/ext/lmdi/gloss/controller/main.php
LINE: 88
CALL: lmdi\gloss\core\glossnew->main()

FILE: [ROOT]/vendor/symfony/http-kernel/HttpKernel.php
LINE: 151
CALL: lmdi\gloss\controller\main->handle_gloss()

FILE: [ROOT]/vendor/symfony/http-kernel/HttpKernel.php
LINE: 68
CALL: Symfony\Component\HttpKernel\HttpKernel->handleRaw()

FILE: [ROOT]/app.php
LINE: 35
CALL: Symfony\Component\HttpKernel\HttpKernel->handle()
ghswen
Registered User
Posts: 54
Joined: Sun Apr 21, 2019 9:04 pm

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by ghswen »

Just an update. I was able to get everything working correctly on my "Live" forum so the problem is apparently something to do with the 'Test forum" on my home server.

Another question however. Perhaps you can tell me where I can change the default text color for the noted Glossary terms. It appears to be a dark brown and I need something lighter because of my use of Dark styles.

Thanks again!

This is exactly what I was looking for!
User avatar
pierredu
Registered User
Posts: 1274
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by pierredu »

Thanks for the follow-up about this error.

The whole styling is in the file lmdi/gloss/styles/prosilver/theme/gloss.css.
ghswen
Registered User
Posts: 54
Joined: Sun Apr 21, 2019 9:04 pm

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by ghswen »

I fixed the glossary text colors. So far so good.

We have begun to load input and discovered another problem. I'm sure this has to do with the default style we are using but perhaps there's a way we can fix it.

When a member clicks on a highlighted Glossary term the definitions display towards the left of the screen and this is what we see.

I'm assuming this is also a 'styles' issue? Can it be fixed on my end?
Glossary issue.jpg
You do not have the required permissions to view the files attached to this post.
User avatar
pierredu
Registered User
Posts: 1274
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by pierredu »

Download the latest version from the github repository.
This should cure this problem.
ghswen
Registered User
Posts: 54
Joined: Sun Apr 21, 2019 9:04 pm

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by ghswen »

First off.
Thanks so much for your help! Our Glossary is up and running. We have almost 100 terms in place. These are Astronomy related terms that are really helping our beginners.

We are getting an error thrown from specific terms. I will post an image of an example. In addition to throwing the error message at the top, it also displays the highlighted term but with additional text included, sometimes not related to the word that is highlighted.

Is this perhaps something we are entering incorrectly when we load the glossary terms?
Imdi Glossary error message.png
You do not have the required permissions to view the files attached to this post.
User avatar
pierredu
Registered User
Posts: 1274
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by pierredu »

I can't display your picture with suficient resolution to understand.
Send me the dump of the phpbb(3)_glossary table.
I'll give you my address in a mp.
ghswen
Registered User
Posts: 54
Joined: Sun Apr 21, 2019 9:04 pm

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by ghswen »

Sorry to take so long to reply. I have read through other posts and determined that I'm having the same problem as member Holder (see page 29). If a description of a term uses a word that is also in the glossary it automatically adds additional text after the displayed word in a post. I hope this is something you can fix in the future.
User avatar
pierredu
Registered User
Posts: 1274
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by pierredu »

I'll check when I come back from holidays.
mh254
Registered User
Posts: 26
Joined: Tue Jan 21, 2014 5:56 pm

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by mh254 »

I usw phpBB 3.2.9 with PHP 7.2 and get this error:

Code: Select all

[phpBB Debug] PHP Warning: in file [ROOT]/vendor/s9e/text-formatter/src/Utils.php on line 76: DOMDocument::loadXML(): Unescaped '<' not allowed in attributes values in Entity, line: 19
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/s9e/text-formatter/src/Utils.php on line 76: DOMDocument::loadXML(): attributes construct error in Entity, line: 19
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/s9e/text-formatter/src/Utils.php on line 76: DOMDocument::loadXML(): Couldn't find end of Start Tag lmdigloss line 19 in Entity, line: 19
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/s9e/text-formatter/src/Utils.php on line 76: DOMDocument::loadXML(): Opening and ending tag mismatch: r line 1 and lmdigloss in Entity, line: 19
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/s9e/text-formatter/src/Utils.php on line 76: DOMDocument::loadXML(): Extra content at the end of the document in Entity, line: 19
[phpBB Debug] PHP Notice: in file [ROOT]/vendor/s9e/text-formatter/src/Utils.php on line 39: Trying to get property 'textContent' of non-object
Style is Prosilver, no custom style.
User avatar
pierredu
Registered User
Posts: 1274
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.2.9-3.3.x][RC] Glossary 3.0.15

Post by pierredu »

Are you sure you're using latest version? See first post of the topic for github address.

Return to “Extensions in Development”