Add user_agent (or other device info) to session keys table

https://www.phpbb.com/ideas/
Post Reply
User avatar
Siava
Registered User
Posts: 148
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Add user_agent (or other device info) to session keys table

Post by Siava »

In UCP session keys tab have many trash keys with same IP.
Perhaps adding a new field to the table would help to better understand them.

It very simple to realise.
User avatar
Brf
Support Team Member
Support Team Member
Posts: 52169
Joined: Tue May 10, 2005 7:47 pm
Location: {postrow.POSTER_FROM}
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by Brf »

You mean like the existing session_browser column?
User avatar
Siava
Registered User
Posts: 148
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by Siava »

I mean Manage “Remember Me” login keys in UCP.
For example: ucp.php?i=ucp_profile&mode=autologin_keys

If you have a lot of information about login keys there, it is not clear which key belongs to which device.
User avatar
warmweer
Jr. Extension Validator
Posts: 5790
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: Add user_agent (or other device info) to session keys table

Post by warmweer »

But what is there more to understand?
If browser agent is just informative then what's its use when a member logs in o, with another device (I log in with tablet, home PC, another PC and I've even tested smartphone).
BTW user agents can be spoofed easily (that 's what bots do all the time).
Spelling is freeware, which means you can use it for free.
On the other hand, it is not open source, which means you cannot change it or publish it in a modified form.
User avatar
Siava
Registered User
Posts: 148
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by Siava »

How to understand what to remove and what to leave?
What else is valid and what can be removed?
Where is the PC, notebook, smartphone/tab session key?
Attachments
Снимок.PNG
User avatar
Lumpy Burgertushie
Registered User
Posts: 68281
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by Lumpy Burgertushie »

why do you want to remove any of them or only certain ones? If I was concerned about disk space or whatever, I would remove them all.

also, where do you see this form that you posted the screen shot for?


I don't find it in the admin panel unless I missed it somewhere.


rob ert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.3 Styles by PlanetStyles.net

If nobody is in the forest, does a tree really fall?
User avatar
Dr.Death
Registered User
Posts: 400
Joined: Fri Apr 25, 2003 10:04 am
Location: Germany
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by Dr.Death »

Lumpy Burgertushie wrote:
Thu Jun 18, 2020 4:10 pm
also, where do you see this form that you posted the screen shot for?
  • UCP -->
  • Profile -->
  • Manage “Remember Me” login key
So, it would be helpfull to see on this page, what device / browser was used.
Voted with : Yes.
Doc.
rxu
Extensions Development Team
Posts: 3429
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by rxu »

UCP wrote:Here you can see remember login keys created on other computers you used to access this site.
Sounds logically. Currently you have actually no real info about keys to decide what keys to delete. Key hash, IP address and login time say nothing about what 'computer' login key was created on.

For the reference: https://github.com/WhichBrowser/Parser-PHP
User avatar
AmigoJack
Registered User
Posts: 5795
Joined: Tue Jun 15, 2010 11:33 am
Location: グリーン ヒル ゾーン
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by AmigoJack »

Dr.Death wrote:
Thu Jun 18, 2020 7:25 pm
  • UCP -->
  • Profile -->
  • Manage “Remember Me” login key
To use one key feature of the internet I'll just link to that site. For me this page lists only one single key, not dozens.
  • The worst thing about censorship is ███████████
  • "The problem is probably not my English but you do not want to understand correctly. ... We will not come anybody anyway, nevertheless, it's best to shit this." Affin, 2018-11-20
  • "But this shit is not here for you. You can follow with your. Maybe the question, instead, was for you, who know, so you shoved us how you are." axe70, 2020-10-10
User avatar
Dr.Death
Registered User
Posts: 400
Joined: Fri Apr 25, 2003 10:04 am
Location: Germany
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by Dr.Death »

It depends on your usage and on different connections / devices you use.
Doc.
User avatar
3Di
Former Team Member
Posts: 16052
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano 🇮🇹 - Frankfurt 🇩🇪
Name: Marco
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by 3Di »

This required just a bunch of lines of code and a new migration which adds a new field in the session_keys table.
2020-06-22 19_34_05-vblog - User Control Panel - Manage “Remember Me” login keys.png
Having read the rxu's new PR though I do not know if making a PR for this will be accepted.
https://github.com/phpbb/phpbb/pull/6012
It can be done via extensions once merged.
To request support for our extensions you can also contact me here: phpBB Studio

Please PM me only to request paid works. Thx. Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
🚀 Looking for a specific feature or alternative option? We will rock you! 🚀
User avatar
Siava
Registered User
Posts: 148
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: Add user_agent (or other device info) to session keys table

Post by Siava »

3Di wrote:
Mon Jun 22, 2020 5:37 pm
It can be done via extensions once merged.
I already wrote an extension :) You can test it.

Minimum phpbb version required: 3.3.2.
Device info in Session keys

Important!
Before install on phpbb 3.3.0/3.3.1 apply this: https://github.com/phpbb/phpbb/pull/6012
And change in ext.php minimum version from 3.3.2 to 3.3.0.
Post Reply

Return to “phpBB Ideas”