[ABD] [DEV] Post Love

[Bootstrap]

I want to cleanly delete postlove.

I have removed the files from the ext directory, but something is trying to find that code and inject it. What else do I need to do to remove it?

[janus_zonstraal]

Did you purge the cache?

[Bootstrap]

Did you purge the cache?

I have now.

I now have it installed again and can see it in extensions.

[nvisibl]

Can anyone help?

Trying to install on 3.3.1

Created avarano folder in phpbb/ext

Extracted post-lov e master files to rolder: phpbb/ext/avarano/post-love master

Cant see reference to post love in forum customize

also tried with copying all files into avarano folder but still non joy

noob needs guidance, can you help?

[ssl]

Hi
Modifiy post-love master folder by postlove

[teebling]

Here to report a bug with missing notifications. Using phpBB 3.3.3 fresh install (no modifications, no other extensions) and the latest master version of Post Love from Github (version 2.0.0-b3). Have done some testing and here's what I've found:

Description of bug & how to reproduce:

When a user likes a post, the author of that post receives a notification as usual. However, when that same user likes another (different) post by the same author, the author of that post does NOT receive a notification for this like. The author is only notified of the first 'like' - the notification for the second 'like' is not generated in the phpbb_notifications table at all.

Possible explanation for this:

It seems that if a 'like' notification already exists from the liking user in the phpbb_notifications table, a second one is not generated by any subsequent like actions from the same user. I have proved this behaviour by taking the steps to reproduce as described above, and then deleting the notification row from phpbb_notifications for the first like, and then liking another post, and observing that a notification is then generated.

It seems then that if a notification already exists from the same user in that table, that a second notification will never be generated. Until the notification disappears naturally (as per the ACP setting for 'Read Notification Expiration' under 'Load settings'), or is deleted manually from the database (like in my test), a second notification will never appear for any other likes from that user.

Could this be related to the historically prevalent issues with duplicate notifications? Perhaps when these sorts of SQL errors were fixed, it only hid the problem, and the extension still has issues generating another notification when it thinks that a 'duplicate' exists? It seems that this same issue was reported on Github back in 2015, and then apparently fixed in version 1.0.2.137. But clearly as you can see from my tests, the issue still persists in the latest master (version 2.0.0-b3).

Any ideas lads? I've also raised an issue on Github over here for anyone else tracking this bug.

Edit: Fixed!

As I suspected it seems that the original fix for this was overwritten at some point during development, so the old bug snuck back in. I looked at what the original dev changed back in 2015 when he released version 1.0.2.137 and re-applied the changes to my current master version (2.0.0-b3) and now all the notifications are showing For anyone wanting a find & replace solution here's how to do it:

In /ext/anavaro/postlove/notifications/postlove.php:

FIND:

Code: Select all

	public static function get_item_id($data)
	{
		return (int) $data['requester_id'];
	}

REPLACE WITH:

Code: Select all

	public static function get_item_id($data)
	{
		return (int) $data['post_id'];
	}

FIND:

Code: Select all

	public static function get_item_parent_id($data)
	{
		return (int) $data['post_id'];
	}

REPLACE WITH:

Code: Select all

	public static function get_item_parent_id($data)
	{
		return (int) $data['requester_id'];
	}

That fixes it.

[wjfox]

Great extension. I'm brand new to phpBB, and just installed my first forum yesterday, along with Post Love. It seems to work fine in 3.3.4

[Paul]

This topic has been marked as [ABD] - Abandoned as the extension author has not been active recently. If the extension author wishes to continue development, please PM anyone on the Extension Customisations Team to request this topic be unlocked.

Notice!
We do not recommend that a user of the phpBB software install this extension, or any other extension that is marked as "abandoned" or "in development", on a live forum. Doing so may cause your forum to not perform in the manner it should.

Thank you,
The phpBB Extension Customisations Team

[DavidIQ]

Restored at author's request.

[zyrien]

Since we updated our forum this extension doesnt work. We can click at the heart but it doesnt give a like..

Any ideas?

[v12mike]

Which version of phpBB and which version of Post Love?

[DavidIQ]

That didn't last long. Moved back to abandoned since author has not been back since requesting the topic to be moved.