[SOLUTION] 3.3.11 stylesheet.css hash values not updated

[P_I]

It is my understanding that the hash values in styles/prosilver/theme/stylesheet.css are the crc32 values of the underlying CSS files. These get updated during the phpBB build process so that CSS changes can be detected by end-user browsers when an update has been made.

It would appear that this didn't happen in the 3.3.11 build.

After updating some of my boards to 3.3.11 I noticed that an awaited fix didn't appear to have been resolved, specifically

Release highlights

• Notable Improvements
  • Ensure compatibility of message editor layout with latest Safari: PHPBB3-17125

My workaround was to manually update the hash values in styles/prosilver/theme/stylesheet.css and then purge the board cache in ACP so that browsers would recognize the CSS changes made in 3.3.11.

[Marc]

You are correct. This was unfortunately missed while building the update package. I've now updated our internal tool that will ensure that this is automatically updated the next time we create a new release. Sorry for the inconvenience.

[P_I]

Marc, perhaps you could consider generating and posting the corrected version of the 3.3.11 styles/prosilver/theme/stylesheet.css.

[Kailey]

posting the corrected version of the 3.3.11 styles/prosilver/theme/stylesheet.css.

Here ya go!

Code: Select all

@import url("normalize.css?hash=48eb3f89");
@import url("base.css?hash=7c5543be");
@import url("utilities.css?hash=d8f72c42");
@import url("common.css?hash=a9741ba1");
@import url("links.css?hash=18286e16");
@import url("content.css?hash=38d7ca0d");
@import url("buttons.css?hash=56f0d25f");
@import url("cp.css?hash=50d868ab");
@import url("forms.css?hash=9016b55c");
@import url("icons.css?hash=64da33ce");
@import url("colours.css?hash=fcb2f289");
@import url("responsive.css?hash=91525545");

[P_I]

Thanks Kailey.

[Lumpy Burgertushie]

I assume that the updated file has already been added to the downloads so that they will be correct for future downloaders.


robert

[Kailey]

No, the package still contains the incorrect hash values. If you want the correct values, you have to manually modify the stylesheet with the values posted (it's only 3 hash values that changed).

[Lumpy Burgertushie]

just curious... why not, I would think it would only take a few minutes to do this.

Over the years, I have wondered why small problems/errors like this are not fixed in the download.

robert

[Sniper_E]

"Lumpy: Just curious... why not?" I would be willing to bet that everyone with a phpbb board that keeps their site updated has already updated.
That's over and done. And I would be willing to bet that most of those users updated their board the day it was released. I did.

It is so easy for all members to update their hash tags like most all users have done already. Thanks for that list Kailey.
I sure don't want to update to version 3.3.11b so soon because of some hash marks. Besides you can be ensured this inconvenience want happen again.

I've now updated our internal tool that will ensure that this is automatically updated the next time we create a new release.

[ssl]

I agree sniper, like some I updated my forum the day version 3.3.11 was released.
As everyone should know, it is not uncommon to encounter bugs with each version release. It's up to us to check these various fixes.

[Mick]

Maybe somebody could post a sticky in support with an explanation and howto?

[5hocK]

I agree sniper, like some I updated my forum the day version 3.3.11 was released.
As everyone should know, it is not uncommon to encounter bugs with each version release. It's up to us to check these various fixes.

Isn't this why there's RC releases?

Yes, no RC this time.

viewtopic.php?p=15979075#p15979075

[ssl]

As if the release versions solved absolutely all the problems

[Kailey]

I think we are all making a mountain out of an anthill. There was a small oversight with the release, the issue was identified, a workaround provided and the Development Team have already taken steps to address the issue so it doesn't happen again. It's not the most convenient situation, but certainly not a showstopper.

Maybe somebody could post a sticky in support with an explanation and howto?

If someone wants to write a guide for this, they can alert a team member to have the topic stickyfied™.

[Paul]

The reason for not modifying packages is pretty simple, it will mean there are going to multiple packages with the same version number, making it hard to find what download a user is exactly using. It also makes validating if a package is the actual package is the expected package, as there will be multiple signatures around for a valid package.
So any change we make in a download, will mean it is going to be a new release. Depending on the impact of the issue, we will release a new version sooner as expected, or we will wait until the next planned release.