[3.3][RC] Autolinks 1.3.9

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
romeo_piter
Registered User
Posts: 129
Joined: Mon Nov 09, 2009 7:11 pm
Location: Paraguay

Re: [3.3][RC] Autolinks 1.3.5

Post by romeo_piter »

https://aquastatus.ru/viewtopic.php?t=39630
The problem can be seen in guest mode. There are no lmdi terms used in this topic at all.
User avatar
pierredu
Registered User
Posts: 1265
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.3][RC] Autolinks 1.3.5

Post by pierredu »

I'm clueless.
The curious thing is that the second page of this topic doesn't trigger the warning.
I must dive deeper in the code.

Could you check whether the problem is still present if there are no ads on this page?
No, it can't be that, because there are ads on the second page.
rxu
Extensions Development Team
Posts: 3773
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation

Re: [3.3][RC] Autolinks 1.3.5

Post by rxu »

Just at the brief look, foreach iterates the $parts array by $index => $part and at the last iteration step the $parts[$index + 1] array element simply does not exist, hence the error.
Not all pages are affected probably since PHP doesn't reach the $parts[$index + 1][0] check as far as $part is neither equal to < nor to [.
User avatar
pierredu
Registered User
Posts: 1265
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.3][RC] Autolinks 1.3.9

Post by pierredu »

Thanks for pointing this error, rxu.

This is code written using two former MODs.

I uploaded a version 1.3.9 on github.
I hope this will run as advertized.
Bruce Banner
Registered User
Posts: 1372
Joined: Thu Sep 25, 2014 10:36 am

Re: [3.3][RC] Autolinks 1.3.9

Post by Bruce Banner »

Hi. Just noticed a conflict between this extension and this one. With both extensions enabled, as long as I haven't added an autolink yet, everything's fine. But when I add an autolink, and enable it in a forum where I've posted a link that's been parsed with Magic OGP, the magic parsing of that link disappears and it becomes just an ordinary link again. If I delete the autolink, the old link is magically parsed again.
User avatar
pierredu
Registered User
Posts: 1265
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.3][RC] Autolinks 1.3.9

Post by pierredu »

Thanks for this pointer.
I'll try to understand what is going on.
Bruce Banner
Registered User
Posts: 1372
Joined: Thu Sep 25, 2014 10:36 am

Re: [3.3][RC] Autolinks 1.3.9

Post by Bruce Banner »

pierredu wrote: Fri Apr 26, 2024 5:19 am Thanks for this pointer.
I'll try to understand what is going on.
Thanks.
User avatar
pierredu
Registered User
Posts: 1265
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.3][RC] Autolinks 1.3.9

Post by pierredu »

I Installed the magicogp extension on my test server but could not find any explanation for the misbehaviour you're describing.
I supposed that this extension and mine would subscribe to the same event and therefore get in conflict. In such a case, the solution is to step back in the subscription process. But this is not true.
I'll try to contact the author to see whether he has ideas about that.
Bruce Banner
Registered User
Posts: 1372
Joined: Thu Sep 25, 2014 10:36 am

Re: [3.3][RC] Autolinks 1.3.9

Post by Bruce Banner »

pierredu wrote: Sat Apr 27, 2024 3:45 pm I Installed the magicogp extension on my test server but could not find any explanation for the misbehaviour you're describing.
I supposed that this extension and mine would subscribe to the same event and therefore get in conflict. In such a case, the solution is to step back in the subscription process. But this is not true.
I'll try to contact the author to see whether he has ideas about that.
Thanks for trying. Were you at least able to replicate the problem?
User avatar
pierredu
Registered User
Posts: 1265
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.3][RC] Autolinks 1.3.9

Post by pierredu »

No, sadly.
Bruce Banner
Registered User
Posts: 1372
Joined: Thu Sep 25, 2014 10:36 am

Re: [3.3][RC] Autolinks 1.3.9

Post by Bruce Banner »

pierredu wrote: Sun Apr 28, 2024 5:38 am No, sadly.
Are you sure? Maybe I didn't describe it right. If you post a link with MagicOGP enabled, it should appear as a big banner across the page. If you then enable an autolink in that same forum, the banner will disappear and be replaced by an ordinary link.
User avatar
pierredu
Registered User
Posts: 1265
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.3][RC] Autolinks 1.3.9

Post by pierredu »

I understand what you told me. But I couldn't reproduce the problem, because I don't know what to do exactly to enable the magicOGP.
Bruce Banner
Registered User
Posts: 1372
Joined: Thu Sep 25, 2014 10:36 am

Re: [3.3][RC] Autolinks 1.3.9

Post by Bruce Banner »

pierredu wrote: Sun Apr 28, 2024 9:22 am I understand what you told me. But I couldn't reproduce the problem, because I don't know what to do exactly to enable the magicOGP.
You just enable it like any other extension, don't you?

EDIT: Sorry, do you mean you can't figure out how to get a link to appear like a big banner? That extension doesn't have configuration options. Just try www.imdb.com Just type that into a post and a big banner should just appear. Then if you enable an autolink in that forum, the big banner will be replaced with an ordinary link.
User avatar
Mick
Support Team Member
Support Team Member
Posts: 26679
Joined: Fri Aug 29, 2008 9:49 am

Re: [3.3][RC] Autolinks 1.3.9

Post by Mick »

Doesn’t the MediaEmbed extension fill your needs?
  • "The more connected we get the more alone we become" - Kyle Broflovski©
  • "The good news is hell is just the product of a morbid human imagination.
    The bad news is, whatever humans can imagine, they can usually create.
    " - Harmony Cobel©
🇬🇧
Bruce Banner
Registered User
Posts: 1372
Joined: Thu Sep 25, 2014 10:36 am

Re: [3.3][RC] Autolinks 1.3.9

Post by Bruce Banner »

Mick wrote: Sun Apr 28, 2024 10:42 am Doesn’t the MediaEmbed extension fill your needs?
You don't understand how this extension works. It's not for embeddable media.

Return to “Extensions in Development”