[3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
peyman974
Registered User
Posts: 64
Joined: Tue Sep 18, 2012 11:58 pm
Location: instagram:c64persian

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by peyman974 »

peyman974 wrote: Sat Jan 21, 2023 9:20 pm
Naguissa wrote: Wed Jan 18, 2023 6:58 pm

Your installations has a different prefix, correct SQL is:

Code: Select all

DELETE FROM forum_migrations where migration_name like '%naguissa%';

"forum" instead "phpbb".
sql query worked but after disable extension then enable extension forum show this message again:


SQL ERROR [ mysqli ]

Table 'forum_thanks' doesn't exist [1146]

SQL

SELECT MAX(tally) AS max_post_thanks FROM (SELECT post_id, COUNT(*) AS tally FROM forum_thanks GROUP BY post_id) t

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()
Hi Naguissa,

After a few months, I still have a problem with this extension, it was activated (4.0.5), but neither the settings nor the thank you button show it self

in attachment my other table type is MyISAM and utf_bin except forum_thanks
Untitled.jpg
You do not have the required permissions to view the files attached to this post.
User avatar
peyman974
Registered User
Posts: 64
Joined: Tue Sep 18, 2012 11:58 pm
Location: instagram:c64persian

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by peyman974 »

Is it possible that this also has an effect?

HTTP input character conversion
mbstring.http_input
User avatar
Naguissa
Registered User
Posts: 501
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

peyman974 wrote: Fri Sep 08, 2023 7:44 am Is it possible that this also has an effect?

HTTP input character conversion
mbstring.http_input
It seems your server defaults to that charset and I didn't force to utf8. But don't worry, thanks table stores nothing except numerical values.
User avatar
peyman974
Registered User
Posts: 64
Joined: Tue Sep 18, 2012 11:58 pm
Location: instagram:c64persian

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by peyman974 »

I have a question Why this extension does not create table when enabled and my forum show this message: forum thanks table does not exist!

I have more than 30 extensions installed and none of them have problems.
User avatar
Naguissa
Registered User
Posts: 501
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

peyman974 wrote: Sat Oct 07, 2023 6:48 am I have a question Why this extension does not create table when enabled and my forum show this message: forum thanks table does not exist!

I have more than 30 extensions installed and none of them have problems.
It should.

Try executing this SQL before enabling it:

Code: Select all

DELETE FROM forum_migrations where migration_name like '%naguissa%';
joelhaasnoot
Registered User
Posts: 1
Joined: Sun Oct 15, 2023 6:53 pm

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by joelhaasnoot »

I've been trying to get this module installed but running into some issues and I'm not sure where to look.

- I've done a fresh install of 4.0.5 from here https://github.com/Naguissa/thanks_for_posts/releases
- I've removed, deleted data and reinstalled afresh
- Board is running Dutch language and a custom Prosilver fork but this also happens on the stock Prosilver

- I see the thanks list in the quick menu but there are no buttons on any posts, including new ones.
- I may be missing some ACP items looking at some (older?) posts here, all I see under extensions are

Code: Select all

THANKS FOR POSTS
Update counters
Rating Options
Are there supposed to be four here?

I've tried this:
Naguissa wrote: Sat Oct 07, 2023 7:56 am Try executing this SQL before enabling it:

Code: Select all

DELETE FROM forum_migrations where migration_name like '%naguissa%';
I also tried this

Code: Select all

INSERT INTO `phpbb_modules` (`module_id`,`module_enabled`,`module_display`,`module_basename`,`module_class`,`parent_id`,`left_id`,`right_id`,`module_langname`,`module_mode`,`module_auth`) VALUES (273,1,1,'','acp',31,346,355,'ACP_THANKS','','');
INSERT INTO `phpbb_modules` (`module_id`,`module_enabled`,`module_display`,`module_basename`,`module_class`,`parent_id`,`left_id`,`right_id`,`module_langname`,`module_mode`,`module_auth`) VALUES (274,1,1,'\\naguissa\\thanksforposts\\acp\\acp_thanks_module','acp',273,347,348,'ACP_THANKS_SETTINGS','thanks','ext_naguissa/thanksforposts && acl_a_board');
INSERT INTO `phpbb_modules` (`module_id`,`module_enabled`,`module_display`,`module_basename`,`module_class`,`parent_id`,`left_id`,`right_id`,`module_langname`,`module_mode`,`module_auth`) VALUES (275,1,1,'\\naguissa\\thanksforposts\\acp\\acp_thanks_refresh_module','acp',273,349,350,'ACP_THANKS_REFRESH','thanks','ext_naguissa/thanksforposts && acl_a_board');
INSERT INTO `phpbb_modules` (`module_id`,`module_enabled`,`module_display`,`module_basename`,`module_class`,`parent_id`,`left_id`,`right_id`,`module_langname`,`module_mode`,`module_auth`) VALUES (276,1,1,'\\naguissa\\thanksforposts\\acp\\acp_thanks_truncate_module','acp',273,351,352,'ACP_THANKS_TRUNCATE','thanks','ext_naguissa/thanksforposts && acl_a_board');
INSERT INTO `phpbb_modules` (`module_id`,`module_enabled`,`module_display`,`module_basename`,`module_class`,`parent_id`,`left_id`,`right_id`,`module_langname`,`module_mode`,`module_auth`) VALUES (277,1,1,'\\naguissa\\thanksforposts\\acp\\acp_thanks_reput_module','acp',273,353,354,'ACP_THANKS_REPUT_SETTINGS','thanks','ext_naguissa/thanksforposts && acl_a_board');
Which did give me a new tab "Thanks For Posts" in the ACP.

If this is a permissions issue, what am I looking for? `Can thank for posts` is ON
Last edited by joelhaasnoot on Mon Oct 16, 2023 8:01 am, edited 1 time in total.
User avatar
CyanSorcery
Registered User
Posts: 1
Joined: Mon Oct 16, 2023 7:22 am
Name: Roxy

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by CyanSorcery »

I'm also having the same issues as joelhaasnoot. Some settings show but the extension doesn't seem to work. I just got back into forum hosting and I think this would be really useful, if it could work
User avatar
Naguissa
Registered User
Posts: 501
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

I have to check db setup script to enforce it and create a "Repair db" option...
User avatar
CyanSorcery
Registered User
Posts: 1
Joined: Mon Oct 16, 2023 7:22 am
Name: Roxy

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by CyanSorcery »

So after some experimentation I found that installing 4.0.4 made the settings submenu appear in the extensions menu, and installing 4.0.0 made the final submenu appear. Upgrading back to 4.0.5 made sure that all the panels were still there. However, none of them made the Thanks button actually show up unfortunately

I also found that changing settings and then saving didn't actually change the settings at all, and they're reset to default when I return to the page

edit: Someone recommended me to use this extension instead, and it worked https://github.com/rxu/thanks_for_posts
Last edited by CyanSorcery on Tue Oct 17, 2023 7:30 pm, edited 1 time in total.
User avatar
Tin Soldier
Registered User
Posts: 82
Joined: Wed Dec 05, 2018 1:20 am

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by Tin Soldier »

So, has the original dev taken over again? Is this fork dead now?
User avatar
Naguissa
Registered User
Posts: 501
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

Tin Soldier wrote: Mon Dec 04, 2023 4:14 am So, has the original dev taken over again? Is this fork dead now?
No idea. "Original dev was Палыч, who made the MOD.

Then rxu adapted it to extension.

Finally I forked extension for phpbb 3.?; original extension didn't work at that phpbb update.

After several time extensions diverted, so now there're two flavors of same extension. I think both are actively developed.
User avatar
Hareon
Registered User
Posts: 27
Joined: Tue Dec 12, 2023 9:03 pm
Location: Brasília/Brazil
Name: Fred Hareon

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by Hareon »

Tested here on 3.3.11 from the github version and don't work.

The settings are there, but no like button.
https://br.crowdin.com/profile/hareon
O bater de asas de uma borboleta causa um tufão do outro lado do mundo.
Teoria do Caos
User avatar
Naguissa
Registered User
Posts: 501
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa »

Hareon wrote: Thu Dec 21, 2023 2:20 pm Tested here on 3.3.11 from the github version and don't work.

The settings are there, but no like button.
1) Check permissions: viewtopic.php?p=14744131#p14744131

2) Pass me the URL and I'll check it.
User avatar
Hareon
Registered User
Posts: 27
Joined: Tue Dec 12, 2023 9:03 pm
Location: Brasília/Brazil
Name: Fred Hareon

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by Hareon »

Oooh...

The first time I used it, everything was fine (although I couldn't "like" the forums/posts). So I disabled the extension and deleted the data via ACP (as I always do when I disable extensions).

I imagine that with this, phpBB will delete the Database tables and clean the board so that I can activate and use it again later.

Well...

Now I went to activate the extension again to test the permissions and the server returned an Error 500.

I tried to activate again and it generated this SQL error like the one in the image.

Image

***********

EDIT:

I searched phpmyadmin, located the phpbbwn_ext table and deleted the extension related entry.
Image

After I went back to my board and tried to activate, I got another Error 500.
And at the second try, again, the SQL error. Looking again at the db table, the entry is appearing there, but there is one more "notifications". I don't know the reason, but there seems to be an error with the extension when inserting the database.
Image

Now I can no longer activate this extension.

EDIT 2: I've downloaded the fresh extension again. Deleted the old, cleared the cache and tried to activate. Error 500 and:

SQL ERROR [ mysqli ]

Duplicate entry 'naguissa/thanksforposts' for key 'ext_name' [1062]

SQL

INSERT INTO phpbbwn_ext (ext_name, ext_active, ext_state) VALUES ('naguissa/thanksforposts', 0, 's:13:\"notifications\";')

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 1031
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 202
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 353
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/phpbb/extension/manager.php
LINE: 179
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/phpbb/extension/manager.php
LINE: 241
CALL: phpbb\extension\manager->update_state()

FILE: [ROOT]/includes/acp/acp_extensions.php
LINE: 209
CALL: phpbb\extension\manager->enable_step()

FILE: [ROOT]/includes/functions_module.php
LINE: 676
CALL: acp_extensions->main()

FILE: [ROOT]/adm/index.php
LINE: 81
CALL: p_master->load_active()

Sad.
https://br.crowdin.com/profile/hareon
O bater de asas de uma borboleta causa um tufão do outro lado do mundo.
Teoria do Caos
User avatar
Hareon
Registered User
Posts: 27
Joined: Tue Dec 12, 2023 9:03 pm
Location: Brasília/Brazil
Name: Fred Hareon

Re: [3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

Post by Hareon »

I managed to solve the problem! :o :o :o

I managed it thanks to the "mirror version" of this addon that was made by another author.

I believe that since the base of both extensions was the same, one may be able to clean the other. When deleting data from the other version, it ended up also deleting something that this version was able to delete, and this made it possible to activate (the other version of the extension) where in this one I could only see Error 500.

I'm just going to leave the information about what I did so that this version also has a future update to solve the problem.

After reporting the problem I had with the database for this extension, even though I tried to delete the extension from the host's drive, it still appeared in the list of extensions with an error of not being able to find a composer.json file, I think.

So I left the files for this version in the istallation folder until you could respond so I could properly clean the database. (I tried to repair the db using a plugin that is here on the board, but it didn't work, I had to do it manually).

Searching here on the board, I saw that there was another version and decided to download it to see if I could solve the problem (or even accumulate more problems) and tried to activate it. The extension gave an error, but it wasn't Error 500 or a SQL error, just an error it couldn't find an image. The error was something like "Something went wrong while executing the request and an exception was created. Changes made before the error occurred have been rolled back as best as possible. However, you should check the forum for errors.

Unexpectedly the "thanks_reput_image" configuration option does not exist." -> As it appears in Portuguese, I don't know what the original message looks like in English, but it should be a message close to this one.

As there was an error to activate. So I went back to phpmyadmin and deleted (again) the table ext (ext_name, ext_active, ext_state) VALUES ('naguissa/thanksforposts', 0, 's:13:\"notifications\";')

Then in the other version of thanksforposts the option to "delete data" appeared in ACP. I even tried to activate again without deleting, but it gave the same error that I reported above.

Then I went to delete data and it deleted it successfully to my surprise. :o

Then I tried to activate the other version of the extension and it activated! :mrgreen: I tested it and it was working fine.

I just need to know if the other extension actually deleted the data from this version here. I just need to know "where to search" in phpmyadmin or cpanel to be able to edit and delete so as not to keep the 2 versions (which could cause conflict). If you have information, I would greatly appreciate it.

And I hope this report helps anyone who may have a similar problem in the future, should this type of problem occur again.
https://br.crowdin.com/profile/hareon
O bater de asas de uma borboleta causa um tufão do outro lado do mundo.
Teoria do Caos

Return to “Extensions in Development”