[3.3][RC] Autolinks 1.3.9

[romeo_piter]

https://aquastatus.ru/viewtopic.php?t=39630
The problem can be seen in guest mode. There are no lmdi terms used in this topic at all.

[pierredu]

I'm clueless.
The curious thing is that the second page of this topic doesn't trigger the warning.
I must dive deeper in the code.

Could you check whether the problem is still present if there are no ads on this page?
No, it can't be that, because there are ads on the second page.

[rxu]

Just at the brief look, foreach iterates the $parts array by $index => $part and at the last iteration step the $parts[$index + 1] array element simply does not exist, hence the error.
Not all pages are affected probably since PHP doesn't reach the $parts[$index + 1][0] check as far as $part is neither equal to < nor to [.

[pierredu]

Thanks for pointing this error, rxu.

This is code written using two former MODs.

I uploaded a version 1.3.9 on github.
I hope this will run as advertized.

[Bruce Banner]

Hi. Just noticed a conflict between this extension and this one. With both extensions enabled, as long as I haven't added an autolink yet, everything's fine. But when I add an autolink, and enable it in a forum where I've posted a link that's been parsed with Magic OGP, the magic parsing of that link disappears and it becomes just an ordinary link again. If I delete the autolink, the old link is magically parsed again.

[pierredu]

Thanks for this pointer.
I'll try to understand what is going on.

[Bruce Banner]

Thanks for this pointer.
I'll try to understand what is going on.

Thanks.

[pierredu]

I Installed the magicogp extension on my test server but could not find any explanation for the misbehaviour you're describing.
I supposed that this extension and mine would subscribe to the same event and therefore get in conflict. In such a case, the solution is to step back in the subscription process. But this is not true.
I'll try to contact the author to see whether he has ideas about that.

[Bruce Banner]

I Installed the magicogp extension on my test server but could not find any explanation for the misbehaviour you're describing.
I supposed that this extension and mine would subscribe to the same event and therefore get in conflict. In such a case, the solution is to step back in the subscription process. But this is not true.
I'll try to contact the author to see whether he has ideas about that.

Thanks for trying. Were you at least able to replicate the problem?

[pierredu]

No, sadly.

[Bruce Banner]

No, sadly.

Are you sure? Maybe I didn't describe it right. If you post a link with MagicOGP enabled, it should appear as a big banner across the page. If you then enable an autolink in that same forum, the banner will disappear and be replaced by an ordinary link.

[pierredu]

I understand what you told me. But I couldn't reproduce the problem, because I don't know what to do exactly to enable the magicOGP.

[Bruce Banner]

I understand what you told me. But I couldn't reproduce the problem, because I don't know what to do exactly to enable the magicOGP.

You just enable it like any other extension, don't you?

EDIT: Sorry, do you mean you can't figure out how to get a link to appear like a big banner? That extension doesn't have configuration options. Just try www.imdb.com Just type that into a post and a big banner should just appear. Then if you enable an autolink in that forum, the big banner will be replaced with an ordinary link.

[Mick]

Doesn’t the MediaEmbed extension fill your needs?

[Bruce Banner]

Doesn’t the MediaEmbed extension fill your needs?

You don't understand how this extension works. It's not for embeddable media.