Approving New Post issue after Update 3.3.13

[mrix2000]

Hello all, has anyone noticed if your getting a issue with approving New topics only ? after updating to the latest phpbb3.3.13 my moderator pointed out that there is a issue whereby when he clicks on the notifications where it shows there is a New topic to approve it directs to the post detail page and there is nowhere to approve it he then has to find the post on the open forum which then does show the approval / disapprove option etc.

[ssl]

If the moderator has the correct permissions, all messages to be approved can be found by clicking on the MCP link in the navbar

Capture d’écran 2024-09-01 à 18.47.03.png

[mrix2000]

If the moderator has the correct permissions, all messages to be approved can be found by clicking on the MCP link in the navbar
Capture d’écran 2024-09-01 à 18.47.03.png

Hello and thanks, I can understand there is a workaround but even using that method takes two actions as opposed to the normal one, obviously you get the New topic notification and you simply click it to then approve or disapprove, after using the software for 14 years it would be a shame to have to click on the notification to then have to click the moderation queue or see the post actually on the forum
Hopefully this is just a bug and can be resolved

[ssl]

I don't see this on my test board in version 3.3.13, so the bug comes from you.
A link to your forum would be helpful

[mrix2000]

I don't see this on my test board in version 3.3.13, so the bug comes from you.
A link to your forum would be helpful

Hello, not sure if you was aware but just in case not its only a issue on a New topic and not the replies to a topic.

[ssl]

when he clicks on the notifications where it shows there is a New topic to approve it directs to the post detail page and there is nowhere to approve it

When you have a notification of new messages to validate and you click on the subject link you arrive in the “Queue” of the “Moderation Panel” in the event of a new subject from a user.
In the “Moderation Options” drop-down menu you can only Delete message
At the bottom of the page are 3 links to validate the message:

Return to the queue | Return to topic | Return to post


This function is missing

Capture d’écran 2024-09-02 à 05.13.19.png

Is this what your moderator is talking about?

Capture d’écran 2024-09-02 à 05.27.01.png

[mrix2000]

Is this what your moderator is talking about ?

Yes the option to approve / disapprove is now missing but only on New topics... well my end, its totally fine with approving reply posts to already created topics.

[Anișor]

Yes, It looks like only the delete option is available when accessing the topic via MCP.
It can be approved from the view topic page only.

Screenshot at Sep 02 08-54-15.png

[ssl]

Reported the bug on the tracker: https://tracker.phpbb.com/browse/PHPBB-17390

[mrix2000]

Seems to be some kind of bug related to the addition of ajax as my moderator just explained the approval/disapproval option did suddenly appear AFTER he had edited the New topic.

[ssl]

There was no AJAX addition between version 3.3.12 and 3.3.13 it seems to me

[mrix2000]

There was no AJAX addition between version 3.3.12 and 3.3.13 it seems to me

Oh ok so it rules that out.

[exemplary1]

I updated my localhost forum to 3.3.13, Created two accounts, Posted reply from one ID and new topic from another ID.
Both are not shown for approval/disapproval.

[danieltj]

It looks like this is a regression with the latest update after new code was added in the prosilver template files. I'll submit a fix for this soon but then it's a waiting game for the next version. At least there's a work around though

edit: https://github.com/phpbb/phpbb/pull/6714

Here's the fix for anyone interested.

Open includes/mcp/mcp_queue.php and find:

Code: Select all

'U_APPROVE_ACTION'		=> append_sid("{$phpbb_root_path}mcp.$phpEx", "i=queue&p=$post_id"),

Add after:

Code: Select all

'S_CAN_APPROVE'			=> $auth->acl_get('m_approve', $post_info['forum_id']),

Save and then clear your cache and you should be good to go.

[exemplary1]

Will this solve styles based on prosilver or have to modify separately ?

Edit : I can see with other styles.

Edit2 : I made above changes and its working.