3.3.12 The submitted form was invalid. Try submitting again.

[oferlaor]

I have php 8.2, phpbb 3.3.12 (with the patch for the session update from 3.3.13)

I noticed that recently I started getting the occasional

Code: Select all

"The submitted form was invalid. Try submitting again."

error

My form_token_lifetime is -1 (I don't want form validation)

I re-read the documentation and saw this statement:

aximum time to submit forms:
The time a user has to submit a form. Use -1 to disable. Note that a form might become invalid if the session expires, regardless of this setting.

Is it possible that the session update fix from 3.3.13 is causing the session to expire?

[thecoalman]

I believe the default for session length and form token is 3600 seconds or 60 minutes. Set them both to the same higher value if you want more time.

There should be no need to disable the token, it's there to prevent cross site scripting.

[oferlaor]

I put it back as 3600

The point is that even with -1 I got this message when posting to the forum.

The form was not open for very long.

[oferlaor]

Is it possible that the 3.3.13 session fix introduced this issue?

[oferlaor]

hmmm. I think this happens because I have dormant tabs on my browser and when I come back and immediately reply (through quick reply), the session is refreshed.

Interestingly, prior to the 3.3.13 session fix, when the form timeout was set to -1, this didn't happen. It started happening now.

[oferlaor]

Btw, were there any relevant style changes regarding captcha functionality in the last few releases?

We have our own custom style and we do not update it along with prosilver on upgrades

[Mick]

The answer is ‘maybe’ without actually going and having a look, see here, style and phpBB versions MUST always match.

[thecoalman]

We have our own custom style and we do not update it along with prosilver on upgrades

If it's not a problem now it will be in the future.Easiest way to check is upload the stock prosilver folder into styles directory, purge the cache. If you modified prosilver itself rename the customized version prosilverbak before uploading prosilver.

To manage a style based on prosilver you can use Winmerge to compare new files to yours. Merge your changes into the new files. It's especially important the new stylesheet.css is uploaded, that forces the browser to download new versions of CSS files but that only works once.*

Unless it's during an update you always need to purge the cache when you upload new template file(s) *Purging the cache also increases asset version and will force browser to update stylesheet.css and subsequently the imported CSS files it lists. If you need to force the browser to update imported CSS files you can manually edit the hash value to anything.

[oferlaor]

We didn’t modify prosilver itself. We started with a copy and slowly adapted.

[Mick]

It’s your adapted style that needs updating.

[oferlaor]

so, that's the question, what's the best way to patch it or at least see what features we're missing in prosilver so we can port them over.

[thecoalman]

To manage a style based on prosilver you can use Winmerge to compare new files to yours. Merge your changes into the new files.

https://winmerge.org/?lang=en

[Mick]

The link I posted earlier gives you the code changes.