[CDB] Browser Push Notifications

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
halil16
Registered User
Posts: 1393
Joined: Fri Jul 24, 2020 11:30 pm
Location: Turkiye
Name: Halil

Re: [3.3][RC] Browser Push Notifications

Post by halil16 »

I saw the same problem on the Like/Thanks notice. I found the solution in redirection. But I'm not sure why.
Buy me a coffee
Hire me for your phpBB board.
Introducing Mobile Upgrade! Make your phpBB board like an app!
O BeldeThatTowns*for sale*
"The day we will need ideas more than possessions, we will find the secret to true wealth." - Peyami Safa
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5979
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: [3.3][RC] Browser Push Notifications

Post by MattF »

nou nou wrote: Mon Sep 02, 2024 11:02 pm Working beautifully apart from one thing - my forum is installed in a subfolder of my domain (www.mysite.com/myforum) and third party extensions that generate notifications, like Thanks for Posts and others, deliver a path to the post that is www.mysite.com/viewtopic.php... instead of www.mysite.com/myforum/viewtopic....

In the forum's notification list in the navbar the links are all fine, just in the Push Notifications they are not.

I've redirected my way around it in the .htaccess, but any idea what may cause this?

Thanks!
We can't seem to reproduce that. Check your forum's server settings, under Server URL settings. Make sure all the fields, especially the script path, is correct. And maybe see what happens when Force URL server settings is on and/or off.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
nou nou
Registered User
Posts: 673
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.3][RC] Browser Push Notifications

Post by nou nou »

MattF wrote: Tue Sep 03, 2024 3:52 pm Check your forum's server settings
Screenshot 2024-09-04 024223.png
Tested force settings on/off and no difference... Thank you though!
You do not have the required permissions to view the files attached to this post.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5979
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: [3.3][RC] Browser Push Notifications

Post by MattF »

nou nou wrote: Wed Sep 04, 2024 12:44 am
MattF wrote: Tue Sep 03, 2024 3:52 pm Check your forum's server settings
Screenshot 2024-09-04 024223.png

Tested force settings on/off and no difference... Thank you though!
halil16 wrote: Mon Sep 02, 2024 11:13 pm I saw the same problem on the Like/Thanks notice. I found the solution in redirection. But I'm not sure why.
We can't reproduce any issues using Thanks for Posts.

It'd be helpful if you could post the JSON data that is in the DB table "phpbb_wpn_notification_push" column called "push_data" for a push notification triggered by Thanks for posts, as well as a regular notification, like from a PM or quote/reply.

Example:

Code: Select all

{
  "heading":"Testing Board",
  "title":"tester_62 has thanked you for this post:",
  "text":"\"Test\"",
  "url":".\/viewtopic.php?p=3917#p3917",
  "avatar":{"src":""}
}

Code: Select all

{
  "heading":"Testing Board",
  "title":"Private Message from tester_76:",
  "text":"\"Blah blah blah\"",
  "url":".\/ucp.php?i=pm&mode=view&p=1",
  "avatar":{"src":""}
}
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
halil16
Registered User
Posts: 1393
Joined: Fri Jul 24, 2020 11:30 pm
Location: Turkiye
Name: Halil

Re: [3.3][RC] Browser Push Notifications

Post by halil16 »

Thanks. So far the extension is perfect.
Buy me a coffee
Hire me for your phpBB board.
Introducing Mobile Upgrade! Make your phpBB board like an app!
O BeldeThatTowns*for sale*
"The day we will need ideas more than possessions, we will find the secret to true wealth." - Peyami Safa
User avatar
nou nou
Registered User
Posts: 673
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.3][RC] Browser Push Notifications

Post by nou nou »

thanks for post:

Code: Select all

{"heading":"Test Board",
"title":"Test User has thanked you for this post:",
"text":"\"My Topic.\"",
"url":".\/viewtopic.php?p=46129#p46129",
"avatar":{"src":"https:\/\/www.mytestboard.com\/forumfolder\/download\/file.php?avatar=g2_1568531610.png"}}
new topic:

Code: Select all

{"heading":"Test Board",
"title":"New topic by Test User:",
"text":"\"My Topic.\"",
"url":".\/viewtopic.php?t=6892",
"avatar":{"src":"https:\/\/www.mytestboard.com\/forumfolder\/download\/file.php?avatar=322_1724365068.jpg"}}
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5979
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: [3.3][RC] Browser Push Notifications

Post by MattF »

nou nou wrote: Sat Sep 07, 2024 11:48 am thanks for post:

Code: Select all

{"heading":"Test Board",
"title":"Test User has thanked you for this post:",
"text":"\"My Topic.\"",
"url":".\/viewtopic.php?p=46129#p46129",
"avatar":{"src":"https:\/\/www.mytestboard.com\/forumfolder\/download\/file.php?avatar=g2_1568531610.png"}}
new topic:

Code: Select all

{"heading":"Test Board",
"title":"New topic by Test User:",
"text":"\"My Topic.\"",
"url":".\/viewtopic.php?t=6892",
"avatar":{"src":"https:\/\/www.mytestboard.com\/forumfolder\/download\/file.php?avatar=322_1724365068.jpg"}}
Everything looks good to me. It should be behaving as expected on your site unless there's just something mysterious with in your Forum settings or you actual web server set up, like redirects or something???

One hack you could try is to mod this file in Thanks for posts extension:

notification/thanks.php:
change:

Code: Select all

return append_sid($this->phpbb_root_path . 'viewtopic.' . $this->php_ext, "p={$this->item_id}#p{$this->item_id}");
to:

Code: Select all

return generate_board_url() . '/' . append_sid('viewtopic.' . $this->php_ext, "p={$this->item_id}#p{$this->item_id}");
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5979
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: [3.3][RC] Browser Push Notifications

Post by MattF »

Extension has been officially released. Download it and use it's contribution support topics here: https://www.phpbb.com/customise/db/exte ... fications/
Formerly known as VSEMy ExtensionsPlease do not PM me for support.

Return to “Extensions in Development”