Use [] and array() consistently

[scootergrisen]

I notice in 3.3.13 that two files (language\en\acp\styles.php and language\en\captcha_recaptcha.php) contain:

Code: Select all

$lang = array_merge($lang, [
	[...]
]);

Where the other files seem to use:

Code: Select all

$lang = array_merge($lang, array(
	[...]
));

I guess it does the same but maybe they should use the same style to be consistent across all files.

[Anișor]

They both do the same.
You can use either array() or simply [] to define an array.
But yes, same for some <br /> which were replaced with <br> in some of the files only.

[scootergrisen]

"<br />" could be changed to "<br>" too for consistency.
Even though it occur 423 it would be easy for the translators to change if they know how to do search and replace.

[Gumboots]

<br /> is XHTML. phpBB uses an HTML5 doctype, so all of those tags should be <br>. Find/replace will do the lot in a one second. I do it anyway if I am editing any file.

[scootergrisen]

Both <br> and <br /> are valid.

[scootergrisen]

One more [] in language\en\cli.php:

Code: Select all

	'CLI_USER_RECLEAN_DONE'			=> [
		0	=> 'Re-cleaning complete. No usernames needed to be cleaned.',
		1	=> 'Re-cleaning complete. %d username was cleaned.',
		2	=> 'Re-cleaning complete. %d usernames were cleaned.',
	],

[Toxyy]

One more [] in language\en\cli.php:

They're all throughout phpbb core, you'll find. IIRC if you want an actual reason, it's because using array() was part of phpbb's coding standard, and that has since changed to []. array() is changed to [] in newer code but is left in the older code.

That's what I think anyways, I can't confirm that.