[3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

[gvp9000]

17 Oct 2023

Version 1.0.5 has been released.

Fix the rotation popup to correctly show up on browsers/devices.
Add webp img format

https://github.com/axew3/phpBB-image-at ... /tag/1.0.5

https://github.com/axew3/phpBB-image-at ... s-rotation

Yes, many things could have been improved and shorted and added and...
It will be done! 1.0.6 may will be moved to the next level!

Any suggestion?
Cheers!

I've installed version 1.0.5 and when I "Re-check for all versions" 1.0.5 is not checked like the other extensions.

Untitled 1.jpg

[axe70]

Hello!

I've installed version 1.0.5 and when I "Re-check for all versions" 1.0.5 is not checked like the other extensions.

This forum is:
Extensions in development

It's because this extension, done quite easily the way it's done, result to be quite hard to be done respecting the phpBB coding rules.
So even if it is perfectly secure and fully working, it has not been accepted to be published into the official db of extensions releases (because do not respect coding rules).

This the reason of the behavior you see. There is no possible check for the phpBB ACP code screen. It is not published into the official phpBB ext db.

Best behavior to adopt:
until it will work, do not check for updates!
If anything is not working fine, just report here, like eventual suggestions for additions!

p.s somebody said: "i will re-code this in the right way into one day".
But after (i knew) there is no way to do what it is done with this code, in a shorter and easier way.

Cheers!

[Ch3vr0n]

Found this extension due to a member post regarding a rotated image on my forum. Works absolutely beautifully and fixed the issue immediately. I do have a minor point of feedback. I'm using the following dark template: https://www.phpbb.com/customise/db/styl ... lver_dark/

When using the dark template, the popup becomes transparent of sorts and it's difficult to see the image background and the buttons (but they do still work). Any chance for an option to set a fixed popup background perhaps (or a general fix to this)

[axe70]

Hello! File:
/ext/w3all/imageattachrotation/styles/prosilver/template/css/style.css

Open it and change into what you want any color using css selectors.
Not sure if it is necessary to set Recompile Stale Templates option to yes into ACP for changes to take effect, i assume yes.
Cheers!

Ps on next version, all the rotation popup css selectors should be changed to be as it is the phpBB default popup, so that it will look by default as it need to be without further changes into any theme.

[EDITED]

[gvp9000]

delete this

[funtent]

Hello axe70, thank you for this extension.

I installed 1.0.5 into my 3.3.5 phpBB install. Everything works... except the images do not rotate.

The icon appears next to attachment. The rotation dialog box appears when you click the rotation icon. All that works.

I rotate the image 90°, 180°, or 270°, the image does rotate in the extension's dialog box. Then click "save image". A very brief "processing..." appears, then I post the post.

But the image does not rotate when I view the post. Tested in Safari and Firefox.

I cleared cache, and "Recompile stale components" is set to "Yes".

Do I need to update phpBB version?

php 7.3.33

[SpIdErPiGgY]

Same here, I click on Save, but all I get is this popup.... Image still not rotated in the topic.
(phpbb 3.3.11, php 8.3.6)

Screenshot_20240430_071306_Firefox Beta.jpg

[mrix2000]

Ps on next version, all the rotation popup css selectors should be changed to be as it is the phpBB default popup, so that it will look by default as it need to be without further changes into any theme.

Hello and thanks for this ext which has helped hugely on my forum, as the other members have stated the ext no longer saves when the images have been rotated and the save button clicked
Can you please let us know if this ext will be updated to fix the issue ?
Thanks

[axe70]

Hello guys: ok, detected into my old ipad that there are problems, at first look, into the user's data that return (always) user ID 1 when the file core/fileRotate.php is loaded: substantially, it seem to me (maybe i am wrong i am just over to see) that the user's session is not correctly set then the execution fail.

Why it happen into the ipad, and not into any other test i try (with any browser on windows or android devices) is still obscure to me: going to apply a patch within (i hope) today.
I also note several errors into the core/fileRotate.php, i will try to fix it in short and return here in reply as soon.

[mrix2000]

Fantastic News, thanks for your time and efforts looking into this.
Very much appreciated.

[foxiedog]

could the problem be related to the php version in use ?

after apply the fix as in this post viewtopic.php?p=15862491#p15862491 my live forum and a test forum running phpbb 3..3.12 and php 7.4.33 the rotation extension works fine,

but on two test boards running phpbb 3.3.12 and php 8.2.12 the rotation extension fails,
all four board have the same setup and content as each other,
could it be that the Attachments images rotation extension is not compatible with php8 ?

[mrix2000]

could it be that the Attachments images rotation extension is not compatible with php8 ?

I have just run some checks on my forum and this EXT works fine with php8.0 but all later version php 8.1, 8.2 and 8.2 it does not work.

For the time being I have reverted back to php 8.0 which presently allows this ext to work.

[mrix2000]

could it be that the Attachments images rotation extension is not compatible with php8 ?

There is now a New version 1.0.6 over at Github but unfortunately its not working for me personally, I get the same issue of it only running on php8.0 if you get the chance I would appreciated to see how you get along with the New update.
Thanks

[foxiedog]

could it be that the Attachments images rotation extension is not compatible with php8 ?

There is now a New version 1.0.6 over at Github but unfortunately its not working for me personally, I get the same issue of it only running on php8.0 if you get the chance I would appreciated to see how you get along with the New update.
Thanks

i get the same results using ver 1.0.6
it works fine in php 7.4.33 but not in php 8.2.12

i tried it with that fix in place, and without the fix, but its still not rotating the image,

(the fix says there are three instances of the line to be edited, but in 1.0.6 there seems to be just one line now ?)

[SpIdErPiGgY]

Now it works with PHP 8.3.11
Tried on my phpBB 3.3.13 forum.

https://github.com/axew3/phpBB-image-at ... s-rotation