Register Globals update code.

[gavo]

Hi, how can this code be updated so it doesnt use globals?

Thanks

Code: Select all

if (isset($_SERVER['HTTP_X_FORWARDED_FOR']))
{
$_SERVER['REMOTE_ADDR'] = $_SERVER['HTTP_X_FORWARDED_FOR'];
}

[Kailey]

Hello,

Can you provide a link to your board?

[Helter Skelter]

Code: Select all

if (isset($_SERVER['HTTP_X_FORWARDED_FOR'])) {
    $remoteAddr = $_SERVER['HTTP_X_FORWARDED_FOR'];
} else {
    $remoteAddr = $_SERVER['REMOTE_ADDR'];
}

Instead of directly modifying $_SERVER['REMOTE_ADDR'], assign the value of $_SERVER['HTTP_X_FORWARDED_FOR'] to a new variable named $remote_addr so it no longer relies on register_globals and instead uses a separate variable to store the value of the remote address.

or you can use the null coalescing operator directly in the assignment

Code: Select all

$remoteAddr = $_SERVER['HTTP_X_FORWARDED_FOR'] ?? $_SERVER['REMOTE_ADDR'] ?? null;

[gavo]

Thanks for the reply, I gave up with this route and used mod_remoteip