Patronising comments

[John Wheater]

Do we think this comment is OK?:
w:\forum\admin\admin_users.php(352): // Awww, the user wants to change their password, isn't that cute..
w:\forum\admin\admin_users.php(354): if($password != $password_confirm)

I think it's a disaster.... Try and edit out such things before release!

John

[david63]

Do we think this comment is OK?:
w:\forum\admin\admin_users.php(352): // Awww, the user wants to change their password, isn't that cute..

Not bothered - if it helps the devs do their job the it is ok by me.

w:\forum\admin\admin_users.php(354): if($password != $password_confirm)

What is wrong with this - it is a perfectly valid php statement

[KevC]

That's not the actual language file text that comes up though is it?

[cheater512]

Putting comments like those in the code is a kind of programmer's humor.
I do it myself.

[Arty]

Comments like that make editing phpBB code much more fun, which helps a lot when doing some commercial work for customers. Please add more such comments!

[david63]

What I find sad is that anyone would actually spend time going through the code to find these comments in the first place and then start a topic about them (very sad )

[3Di]

Comments like that make editing phpBB code much more fun, which helps a lot when doing some commercial work for customers. Please add more such comments!

So do I, I love such comments in the code, also to put comments into mines.

It is not the first time I got a laugh reading codes.

[dhn]

http://www.google.com/codesearch

[Handyman`]

Who is going to go through the code and be concerned with all those comments?
Every good programmer that I know does that
Stuff like: Replace naughty words such as farty pants
lol
yes, that comment is actually in the code… what's the problem with that?

[just.xTc]

All of you just made me hate myself for never commenting my code I want to join the fun, too!

[3Di]

http://area51.phpbb.com/statcvs/#lastlogs


like:

2007-03-14 shs

Do the syncorama dance! /-< \-< |-<

[Handyman`]

All of you just made me hate myself for never commenting my code I want to join the fun, too!

8O You were missing out on the fun??? what are you waiting for
Ugh! I hate this half page loading stuff

[3Di]

// Strip all tags from data ... may p**s some people off, bah, strip_tags is
// doing the job but can still break HTML output ... have no choice, have
// to use htmlspecialchars ... be prepared to be moaned at.

be prepared then..

[just.xTc]

MOOOOOOOAAAAAN......
xD

But why is htmlspecialchars a problem anyway?

[3Di]

MOOOOOOOAAAAAN......
xD

But why is htmlspecialchars a problem anyway?

Problem? Bah..