Patronising comments

Do not post support requests, bug reports or feature requests. Discuss phpBB here. Non-phpBB related discussion goes in General Discussion!
Anti-Spam Guide
John Wheater
Registered User
Posts: 2
Joined: Sun Mar 04, 2007 5:34 pm

Patronising comments

Post by John Wheater »

Do we think this comment is OK?:
w:\forum\admin\admin_users.php(352): // Awww, the user wants to change their password, isn't that cute..
w:\forum\admin\admin_users.php(354): if($password != $password_confirm)

I think it's a disaster.... Try and edit out such things before release!

John
User avatar
david63
Registered User
Posts: 20646
Joined: Thu Dec 19, 2002 8:08 am

Re: Patronising comments

Post by david63 »

John Wheater wrote: Do we think this comment is OK?:
w:\forum\admin\admin_users.php(352): // Awww, the user wants to change their password, isn't that cute..
Not bothered - if it helps the devs do their job the it is ok by me.
John Wheater wrote: w:\forum\admin\admin_users.php(354): if($password != $password_confirm)
What is wrong with this - it is a perfectly valid php statement
David
Remember: You only know what you know and - you don't know what you don't know!

I now no longer support any of my extensions but they will start to become available here
User avatar
KevC
Support Team Member
Support Team Member
Posts: 72612
Joined: Fri Jun 04, 2004 10:44 am
Location: Oxford, UK

Re: Patronising comments

Post by KevC »

That's not the actual language file text that comes up though is it?
-:|:- Support Request Template -:|:-
Image
"Step up to red alert. Sir, are you absolutely sure? It does mean changing the bulb"
User avatar
cheater512
Registered User
Posts: 296
Joined: Sat Mar 05, 2005 11:27 pm
Location: Brisbane, Australia

Re: Patronising comments

Post by cheater512 »

Putting comments like those in the code is a kind of programmer's humor.
I do it myself. ;-)
Last edited by cheater512 on Fri Mar 23, 2007 11:50 pm, edited 1 time in total.
User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin

Re: Patronising comments

Post by Arty »

Comments like that make editing phpBB code much more fun, which helps a lot when doing some commercial work for customers. Please add more such comments! :D
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework
User avatar
david63
Registered User
Posts: 20646
Joined: Thu Dec 19, 2002 8:08 am

Re: Patronising comments

Post by david63 »

What I find sad :( is that anyone would actually spend time going through the code to find these comments in the first place and then start a topic about them (very sad :( :( :( )
David
Remember: You only know what you know and - you don't know what you don't know!

I now no longer support any of my extensions but they will start to become available here
User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco

Re: Patronising comments

Post by 3Di »

CyberAlien wrote: Comments like that make editing phpBB code much more fun, which helps a lot when doing some commercial work for customers. Please add more such comments! :D


So do I, I love such comments in the code, also to put comments into mines.

It is not the first time I got a laugh reading codes. :D
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
dhn
Former Team Member
Posts: 4999
Joined: Wed Jul 04, 2001 8:10 am
Location: Internet
Name: Dominik Dröscher

Re: Patronising comments

Post by dhn »

User avatar
Handyman`
Former Team Member
Posts: 1751
Joined: Thu Feb 03, 2005 8:44 pm

Re: Patronising comments

Post by Handyman` »

Who is going to go through the code and be concerned with all those comments?
Every good programmer that I know does that :)
Stuff like: Replace naughty words such as farty pants
lol
yes, that comment is actually in the code… what's the problem with that?
http://startrekguide.com My Mod Queue || 1/16/10 Display Posts Anywhere 1.2.0 RC5, Cash MOD 1.0.0 b1, MOD Version Check, AJAX Chat, SEO MOD, AJAX QR, Photo Gallery
MOD Development Manager (version 0.2.0-dev with MODX Generator)
just.xTc
Registered User
Posts: 23
Joined: Sun Aug 20, 2006 10:42 pm

Re: Patronising comments

Post by just.xTc »

All of you just made me hate myself for never commenting my code :( I want to join the fun, too!
User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco

Re: Patronising comments

Post by 3Di »

http://area51.phpbb.com/statcvs/#lastlogs


like:
2007-03-14 shs

Do the syncorama dance! :D/-< :D\-< :D|-<
:D
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
Handyman`
Former Team Member
Posts: 1751
Joined: Thu Feb 03, 2005 8:44 pm

Re: Patronising comments

Post by Handyman` »

just.xTc wrote: All of you just made me hate myself for never commenting my code :( I want to join the fun, too!

8O You were missing out on the fun??? what are you waiting for ;)
Ugh! I hate this half page loading stuff :?
http://startrekguide.com My Mod Queue || 1/16/10 Display Posts Anywhere 1.2.0 RC5, Cash MOD 1.0.0 b1, MOD Version Check, AJAX Chat, SEO MOD, AJAX QR, Photo Gallery
MOD Development Manager (version 0.2.0-dev with MODX Generator)
User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco

Re: Patronising comments

Post by 3Di »

// Strip all tags from data ... may p**s some people off, bah, strip_tags is
// doing the job but can still break HTML output ... have no choice, have
// to use htmlspecialchars ... be prepared to be moaned at.


be prepared then..
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
just.xTc
Registered User
Posts: 23
Joined: Sun Aug 20, 2006 10:42 pm

Re: Patronising comments

Post by just.xTc »

MOOOOOOOAAAAAN......
xD

But why is htmlspecialchars a problem anyway?
User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco

Re: Patronising comments

Post by 3Di »

just.xTc wrote: MOOOOOOOAAAAAN......
xD

But why is htmlspecialchars a problem anyway?


Problem? Bah.. :)
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades

Return to “phpBB Discussion”