Code: Select all
<?php
if (!defined('IN_PHPBB'))
{
exit;
}
// Set update info with file structure to update
$update_info = array(
'version' => array('from' => '1.0.0', 'to' => '1.0.1'),
'files' => array(
'includes/ucp/ucp_yourmod.php'),
'binary' => array(
),
);
?>
That is a fairly swooping statement. Of course it was allowed. Look at the MODDB.The freedom to modify core code is a thing of the past (if it was ever really allowed)...
I agree. Modifying "core code" isn't always a bad thing; it just depends on what you want to accomplish. Plugins and other modular things are nice, but not everything can be like them due to their nature.poyntesm wrote:If you need a permission system in your MOD - use the phpBB system. If you need caching in your MOD - use the acm. If you MOD can be standalone - look into writing it as a module. What if you wanted to change the way phpBB does topic tracking for whatever reason. A module could not do that. You would want to edit the core files and adjust to your desired method and in my opinion thats 100% OK.
michaelo wrote:It does appear the concept of Safe Mods is/was only wishful thinking on my part.
Code: Select all
thread.onpost = new handler(data, *myposthandler)
myposthandler(data)
if (post allowed using my own logic)
return true;
else
return false;
usually I name it 'fork', though.MennoniteHobbit wrote:Modifying "core code" isn't always a bad thing; it just depends on what you want to accomplish.
3Di wrote:usually I name it 'fork', though.MennoniteHobbit wrote:Modifying "core code" isn't always a bad thing; it just depends on what you want to accomplish.
I have always imagined this was the case, unfortunately if you allow such changes, then, over time you could end up with something other than a true phpBB core product.... mind you, database changes are rare and can probably be dealt with easily enough but php core changes (I don't mean code additions) are very common and in MHO do more damage....wGEric wrote:IMO it is a good idea (well some of the things) but at this point, it's not practical and not efficient. phpBB needs to be written in a way that allows this to happen easily. Something along the lines of WordPress's plug in system comes to mind.
Until then, if it ever happens, MOD Authors can edit the files and the database as they want.
The MOD Team doesn't like it when you change delete anything in the database though. You can add columns and tables but when it comes to deleting columns, we don't like it. We will accept MODs that do this though but the author has to have a good reason on why he/she is doing what they are doing.
We don't like people to use REPLACE WITH but use IN-LINE actions instead. Although, there are instances where IN-LINE actions can't be used and you need to use REPLACE WITH.michaelo wrote:Having said that, can you imagine how much easier for everyone if 'find and replace' were not be allowed in mods... besides there are many new code segments that point towards module based inclusion...