[ABD] advanced quoting

[Erik Frèrejean]

Yes your right and I saw some other typo's in the mod. I'll upload a new version when I come back from school.

[Erik Frèrejean]

A little bit later then planned. But if I'm correct every thing should work if you use the latest revision of the mod.

[thomasfedb]

I get theses errors...

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/bbcode.php on line 665: Undefined index: aq_user_link
[phpBB Debug] PHP Notice: in file /includes/bbcode.php on line 677: Undefined index: aq_user_link
[phpBB Debug] PHP Notice: in file /includes/bbcode.php on line 687: Undefined index: aq_post_link
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3374: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2899)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3376: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2899)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3377: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2899)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3378: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2899) 

Help!

[Erik Frèrejean]

You have to run the sql query's in the mod.

[saaiberke]

I just reinstalled the last version but:

I get this error:

Code: Select all

Language file advanced_quoting.php couldn't be opened.

So I changed the language file acp_advanced_quoting to advanced_quoting.php and thhis seems to work. The ACP window opens but when I try to change some settings and click submit, I get redirected to the ACP main panel and not any setting is changed in the DB.

Then I renamed the language file to the original name and changed in the includes/acp/acp_advanced_quoting.php from

Code: Select all

		if (!$submit)
		{
			$user->add_lang('acp/advanced_quoting');

to

Code: Select all

		if (!$submit)
		{
			$user->add_lang('acp/acp_advanced_quoting');

This seems to work but I still can't change any DB settings. Even when I change the settings manually with phpMyadmin the quoting doesn't work.

Nic

[thomasfedb]

I get theses errors...

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/bbcode.php on line 665: Undefined index: aq_user_link
[phpBB Debug] PHP Notice: in file /includes/bbcode.php on line 677: Undefined index: aq_user_link
[phpBB Debug] PHP Notice: in file /includes/bbcode.php on line 687: Undefined index: aq_post_link
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3374: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2899)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3376: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2899)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3377: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2899)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3378: Cannot modify header information - headers already sent by (output started at /includes/functions.php:2899)  

Help!

I forgot to clear my cache, and the acp module didn't work so i edited my prefs through myphpadmin and then cleared the cache again.

When i delete a post (from the middle of a topic) i get this error:

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/bbcode.php on line 600: array_merge() [function.array-merge]: Argument #2 is not an array

This is the problem line (its in your code):

Code: Select all

            $row = array_merge ($row, $db->sql_fetchrow ($result)); 

[Erik Frèrejean]

You have to run the sql query's in the mod.

Make sure that you did this.

[annepenullar]

I just reinstalled the last version but:

I get this error:

Code: Select all

Language file advanced_quoting.php couldn't be opened.

So I changed the language file acp_advanced_quoting to advanced_quoting.php and thhis seems to work. The ACP window opens but when I try to change some settings and click submit, I get redirected to the ACP main panel and not any setting is changed in the DB.

Then I renamed the language file to the original name and changed in the includes/acp/acp_advanced_quoting.php from

Code: Select all

		if (!$submit)
		{
			$user->add_lang('acp/advanced_quoting');

to

Code: Select all

		if (!$submit)
		{
			$user->add_lang('acp/acp_advanced_quoting');

This seems to work but I still can't change any DB settings. Even when I change the settings manually with phpMyadmin the quoting doesn't work.

Nic

You're right. I did receive the same error above and made the same changes. It works in and for the most part. Though problem comes, whenever I change the "AQ default settings" and press Submit, I am redirected to Admin CP front page. Please help.

[Erik Frèrejean]

Thanks for the reports.

That language bit is really a stupid typo , but the fix above shall do the trick.

The other acp problem is also easy to fix:
Open includes/acp/acp_advanced_quoting.php, Find:

Code: Select all

$module_id        = request_var('i', false);  

Replace with:

Code: Select all

$module_id        = request_var('i', 0);  

Find:

Code: Select all

redirect (append_sid ('./index.php', 'i='.$this->module_id ));    

Replace with:

Code: Select all

redirect (append_sid ('./index.php', 'i='.$module_id ));    

*updated the package*

[annepenullar]

Lovely! Thanks for the fix!

[thomasfedb]

When i delete a post (from the middle of a topic) i get this error:

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/bbcode.php on line 600: array_merge() [function.array-merge]: Argument #2 is not an array

This is the problem line (its in your code):

Code: Select all

            $row = array_merge ($row, $db->sql_fetchrow ($result));   

Why is your code handling this? is it quote related

And yes, i'v done the SQL (even changed the settings through the db becasue that admin panel wouldn't work...)

Plz help!

[Erik Frèrejean]

I must admit that this is something I didn't test. When I come home I'll have a look at it.

[Erik Frèrejean]

When i delete a post (from the middle of a topic) i get this error:

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/bbcode.php on line 600: array_merge() [function.array-merge]: Argument #2 is not an array

This is the problem line (its in your code):

Code: Select all

            $row = array_merge ($row, $db->sql_fetchrow ($result));     

Why is your code handling this? is it quote related

And yes, i'v done the SQL (even changed the settings through the db becasue that admin panel wouldn't work...)

Plz help!

Oke to fix this one:
Open: /includes/bbcode.php, Find:

Code: Select all

            $result = $db->sql_query_limit($sql, 1, 0);
            $row = array_merge ($row, $db->sql_fetchrow ($result));  

Replace with:

Code: Select all

            $result = $db->sql_query_limit($sql, 1, 0);

            if ($fetch_row = $db->sql_fetchrow ($result))
            {
                $row = array_merge ($row, $fetch_row);
            }  

About the problems with the acp, I can't find it. I can't even duplicate it. And I have installed the mod a couple of times on a clean installation.

*Updated the package*

[ChriZathens]

A loooong time ago, Acyd Burn developed an Extended Quote Tag for phpbb2....
Suppose no chance to create an update-like script for phpbb2 forums which use it???
If you could do something like that it would be really nice...

BTW, great mod

[thomasfedb]

thx, that fixed it, luckily on 1 topic was affected before you told mehow to fix it!