yes, just redowned it to make surestatm wrote:Were you using the updated version from Jan 21st?jimcarrel wrote:thats Strange, I deleted mine and quick reply ceased to operate....
yes, just redowned it to make surestatm wrote:Were you using the updated version from Jan 21st?jimcarrel wrote:thats Strange, I deleted mine and quick reply ceased to operate....
In german we say it's a comment, I do not know the englisch word.jimcarrel wrote:It looks to me that it may have errant code plus legit code, and I sure don't understand why Sascha could delete and it still work.
Code: Select all
<!-- This is the comment: Begin of table -->
<table>
<tr>
<td>Hello Table</td>
</tr>
</table>
<!-- This is a comment: End of table -->
Code: Select all
<!--
<form action="{S_QR_POST_ACTION}" method="post" id="postform">
<div class="panel" id="postingbox">
<div class="inner"><span class="corners-top"><span></span></span>
<h3>{L_POST_REPLY}</h3>
<fieldset class="fields1">
<dl style="clear: left;" id="message-box">
<!-- IF S_QR_SUBJECT -->
<dd>
<input type="text" name="subject" id="subject" size="45" maxlength="64" tabindex="1" value="{QR_SUBJECT}" class="inputbox" style="width:100%;" />
</dd>
<!-- ENDIF -->
<dd>
<textarea name="message" id="message" rows="10" cols="76" tabindex="2" class="inputbox" style="height:200px; width:99%;"></textarea>
</dd>
<!-- IF S_QR_RESIZE -->
<dd>
<input type="button" value=" + " class="button1" onclick="textbox_resize(100);" />
<input type="button" value=" - " class="button1" onclick="textbox_resize(-100);" />
</dd>
<!-- ENDIF -->
</dl>
</fieldset>
<span class="corners-bottom"><span></span></span></div>
</div>
<!-- IF not S_USER_LOGGED_IN -->
<div class="panel bg2">
<div class="inner"><span class="corners-top"><span></span></span>
<fieldset class="fields1">
<div class="column1">
<dl>
<dl>
<dt><label for="username">{L_USERNAME}:</label></dt>
<dd><input type="text" tabindex="3" name="username" id="username" size="25" maxlength="30" class="inputbox" /></dd>
</dl>
<!-- IF S_CONFIRM_CODE -->
<dl>
<dt><label for="confirm_code">{L_CONFIRM_CODE}:</label></dt>
<dd><input type="hidden" name="confirm_id" value="{CONFIRM_ID}" />{CONFIRM_IMAGE}</dd>
<dd><input type="text" name="confirm_code" id="confirm_code" size="8" maxlength="8" tabindex="4" class="inputbox narrow" title="{L_CONFIRM_CODE}" /></dd>
</dl>
<!-- ENDIF -->
</dl>
</div>
</fieldset>
<span class="corners-bottom"><span></span></span></div>
</div>
<!-- ENDIF -->
<div class="panel bg2">
<div class="inner"><span class="corners-top"><span></span></span>
<fieldset class="submit-buttons">
{S_QR_HIDDEN_FIELDS}
<input type="submit" name="preview" tabindex="6" value="{L_PREVIEW}" class="button1" onclick="document.getElementById('postform').action += '#preview';" />
<input type="submit" name="post" tabindex="5" value="{L_SUBMIT}" class="button1" accesskey="s" />
</fieldset>
<span class="corners-bottom"><span></span></span></div>
</div>
{S_FORM_TOKEN}
</form>
-->
Okay, I just rechecked what I had deleted, I had grabbed an extra line that was outside of the comment!statm wrote:But my point is.. I don't understand how the MOD still works if you delete all of that.
Plus, in my copy none of that is commented.
Yours is wrong syntax, this is correct:jimcarrel wrote:oh, man, I am simply confused now,,, how can <!---endif---> be a comment
Code: Select all
<!-- endif -->
The PHP-Parser replace those comments --> <!-- IF for_example --> and <!-- ENDIF -->statm wrote:In phpBB 3.0's template engine <!-- IF for_example --> and <!-- ENDIF --> aren't comments and the syntax is capitalized. They are actually real instructions. But, if it just says <!-- this is a comment --> that is a comment.
Yes, that's correct of course!statm wrote:The template parser inside phpBB replaces the <!-- IF statements --> with php code and then the php parser renders it. The php parser on the server doesnt touch the <!-- IF statements --> in the style until it is actually parsed by the template parser first though.