I just installed and had a bad function call in common.php:
Code: Select all
$s_exists_unreads = check_unread_posts();
Any problems with this code with anyone else so far? Did I happen to miss something? All caches have been reloaded.
Code: Select all
$s_exists_unreads = check_unread_posts();
Sounds like maybe you didn't make the change the mod calls for in common.php (the one that requires inclusion of that file)?v8power wrote:Alan,
I just installed and had a bad function call in common.php:
Removing the code will still let me see the index page, and the template add that I manually did to my own templates work just fine. Of course the link now reads "You have no unread posts" because I removed the code in common.php to view the index page. But, when I click it I then get another function undefined unread_list_sql() in search.phpCode: Select all
$s_exists_unreads = check_unread_posts();
Any problems with this code with anyone else so far? Did I happen to miss something? All caches have been reloaded.
Well, this mod is very useful for my board because 90% of my users use it. I've changed from a 2.0 phpbb to a 3.0, and everyone asked for this functionality from the start. It makes my users happy!asinshesq wrote: Thanks for letting me know you like it (that feedback is much appreciated). I'm curious, though, about why this mod turns out to be so useful for your board (since to me it seem somewhat useful but not earthshattering):
- Is it mostly the ability to get a simple list of unreads? Or do you also find the ability to mark a post unread useful? (The list was easy to code but the part allowing you to mark posts unread was pretty tough.)
- Does the part that allows you to see unread pms in their own folder (and mark pms unread) matter much to you?
Did you end up getting rid of the regular "View new posts" link (as discussed in paragraph (4) of the author's notses)? Or do you find it is useful to have both links and not too confusing for your users?Forke wrote:The ability they appreciate the most is the simple list of unreads.
Code: Select all
IN-LINE ERPLACE WITH
Yes, you are correct. That is not in the mod itself - it wouldn't have passed validation if it were. But it is in the author's notes comments (author note (4)), and you are right that it is a typo. Thanks for pointing it out...I'll fix that if and when I do another version.ostkamp wrote:I think I've found a typo in this mod: In install.xml there is a lineI believe this should read REPLACE shouldn't it?Code: Select all
IN-LINE ERPLACE WITH
Yes, I did. In fact, I deleted many of other links. I just left your mod, "view your posts" and "Mark all forums read".asinshesq wrote:Did you end up getting rid of the regular "View new posts" link (as discussed in paragraph (4) of the author's notses)? Or do you find it is useful to have both links and not too confusing for your users?Forke wrote:The ability they appreciate the most is the simple list of unreads.
That would involve a re-write of the function check_unread_posts() that appears in functions_view_or_mark_unread_posts.phpForke wrote:Is there a way to indicate the number of unread posts in the unread post link? I mean, something like "View unread posts (14)", in which 14 is the number of unread posts the user has.
Never mind. I'll just stick with the one I got.asinshesq wrote:No idea. What's the post count on index mod and where is it? There is no user named 'christian' on phpbb.com.Renodil wrote:Would the New post count on index by christian be interfering?
[edit: I just found the mod you are talking about. There is no conflict, but they both change the same line in index_body.html so I am guessing you made those changes wrong. Please check your edits again. Also, please consider whether your users will be totally confused by a link for new posts with a number and another link for unread posts...see paragraph (4) of the author's notes for details.]
Find this linesovietpop wrote:Hello, I am getting an error message when I try and check pms
"
Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/.mykah/aaocarroll/misspeltCAT/includes/ucp/ucp_pm_viewfolder.php on line 216"
I've checked the viewfolder.php file and I can't see what I might have done wrong; could it be that I've a mistake in one of the other files? and if you think that might bet the case, where would I look for the error first.
Code: Select all
'FOLDER_ID' => $folder_id,
Code: Select all
'FOLDER_ID' => $row['folder_id'] ,
Code: Select all
" . $row['folder_id'] . "