You can use the mod risk free - however, not all bugs have been fixed (not quite what you would expect of a release version but what the heck).James321 wrote:Sorry for beeing a Noob.
But I have a question:
There are 37 pages and a lot of theme report bugs of a MOD released.I must read them all and fix them or they are fixed and the first post updated ?
P.S so I can free risk use this mod ?
Thank you@
OK I have fixed this bug - I just need to remember what I have changed in order to share it with everyone else. To get the updated template to be used, I had to purge the cache in the administration control panel.rwap01 wrote:I have been investigating the bug in the javascript which is run if you click on the "PAGE 1 of 3" link at the bottom to jump to an entered page number.
Nearly fixed, but I am struggling. I need to pass a parameter in the "jumpto();" statement which appears in the template - it should read:
I have amended this in the template for prosilver, and altered functions_seo.php to include setting up the chnages to these parameters in the template, but when you view my forums, the resulting HTML still shows:Code: Select all
jumpto('{TOPIC_URL}','{SEO_EXT}');
<a href="#" onclick="jumpto(); return false;" title="Click to jump to page…">
Any ideas what I have missed?
It would help if you could explain which change you are trying to do.... A link to the actual post or a bit of code would help as this statement does not make much senseDarkness568 wrote:ummm.. I read your SEO mod essentials to be updated, but when i searched the file in the index.php i couldnt find it, but it did find what it was supposed to change so should i just replace it?
Code: Select all
'U_MARK_FORUMS' => ($user->data['is_registered'] || $config['load_anon_lastread']) ? append_sid("{$phpbb_root_path}index.$phpEx", 'mark=forums') : '',
Code: Select all
'U_MARK_FORUMS' => ($user->data['is_registered'] || $config['load_anon_lastread']) ? append_sid("{$phpbb_root_path}index.$phpEx", 'mark=forums') : '',
Code: Select all
Select all
'U_MARK_FORUMS' => ($user->data['is_registered'] || $config['load_anon_lastread']) ? '?mark=forums' : '',
James321 wrote:Sorry for beeing a Noob.
But I have a question:
There are 37 pages and a lot of theme report bugs of a MOD released.I must read them all and fix them or they are fixed and the first post updated ?
P.S so I can free risk use this mod ?
Thank you@
rwap01 wrote: You can use the mod risk free - however, not all bugs have been fixed (not quite what you would expect of a release version but what the heck).
Once you have installed the SEO MOD, read my SEO Essential fixes post for details of fixes which you will need to implement.
They are still some outstanding issues, but the author does not appear to be working on these and leaving them up to the community to fix. Is there anyone else looking at these issues, or just me?
Yes, this is the line you need to replace.Darkness568 wrote:Well i read the SEO essential modes or updates or whatever it is and the mark all threads had a code change for index.php and wants me to find this code, but when i search for it i cannot find it, but i can find something similar to it this is the code i found in itCode: Select all
'U_MARK_FORUMS' => ($user->data['is_registered'] || $config['load_anon_lastread']) ? append_sid("{$phpbb_root_path}index.$phpEx", 'mark=forums') : '',
this is the code to replace it withCode: Select all
'U_MARK_FORUMS' => ($user->data['is_registered'] || $config['load_anon_lastread']) ? append_sid("{$phpbb_root_path}index.$phpEx", 'mark=forums') : '',
so should i just replace that code even though its not the same. I found the SEO essentials link in your post a few upCode: Select all
Select all 'U_MARK_FORUMS' => ($user->data['is_registered'] || $config['load_anon_lastread']) ? '?mark=forums' : '',
I would suggest that you have made an error in the changes to posting.php - see the MODxNLCrEaTiVe wrote:It looks like to be working, except when replying and editing posts. I get this error:
General Error
SQL ERROR [ mysqli ]
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'phpbb3_topics t WHERE t.topic_id = p.topic_id AND t.topic_id = 5393' at line 3 [1064]
SQL
SELECT t.topic_title FROM phpbb3_posts p phpbb3_topics t WHERE t.topic_id = p.topic_id AND t.topic_id = 5393
BACKTRACE
FILE: includes/db/mysqli.php
LINE: 143
CALL: dbal->sql_error()
FILE: includes/functions_seo.php
LINE: 170
CALL: dbal_mysqli->sql_query()
FILE: viewtopic.php
LINE: 64
CALL: moved_topic()
What am I missing out?
Well, I made all of the edits you listed but I am still having the same exact problem as before. When I click on a page number that is supposed to jump to that page I get the same errors as before adding the edits.rwap01 wrote:This is one of the pagination bugs referred to in my SEO Essential fixes postterryrw wrote:I am having issues with the mod. Let's say for example a user is browing a category and found a subject that has 5 pages. 1,2,3,4,5,6. If they click they try go directly to a specific page number "example, they click on page 5" they get a 404 page error like this. (The requested URL /forum/fishing-contest-for-the-kid%CA%B9s--t1577s30.php does not exist.) I can't figure out what is causing this. If they open the subject and click next to go through all 6 pages there is no problems. It is only when they try to click a page from the topics pages. I attempted to re-edit all the files 4 times and have the same result. Can someone please offer me some assistance, as I am not a coder.
I have managed to fix this bug, as follows:flycker wrote: Second, bugs without a bug fix:
1. - "Page 2 of 4" (javascript) doens't work:
1.1
1.2
1.3 Go to "http://new1.myforum.com/&start=10" a "404 - Not Found" page.
Code: Select all
function jumpto()
{
var page = prompt(jump_page, on_page);
if (page !== null && !isNaN(page) && page > 0)
{
document.location.href = base_url.replace(/&/g, '&') + '&start=' + ((page - 1) * per_page);
}
}
Code: Select all
function jumpto(base_url,seo_ext)
{
var page = prompt(jump_page, on_page);
if (page !== null && !isNaN(page) && page > 0)
{
document.location.href = base_url.replace(/&/g, '&') + 's' + ((page - 1) * per_page) + seo_ext;
}
}
Code: Select all
<a href="#" onclick="jumpto(); return false;" title="{L_JUMP_TO_PAGE}">
Code: Select all
<a href="#" onclick="jumpto('{BASE_URL}','{TOPIC_SEO_EXT}'); return false;" title="{L_JUMP_TO_PAGE}">
Code: Select all
<a href="#" onclick="jumpto(); return false;" title="{L_JUMP_TO_PAGE}">
Code: Select all
<a href="#" onclick="jumpto('{BASE_URL}','{TOPIC_SEO_EXT}'); return false;" title="{L_JUMP_TO_PAGE}">
Code: Select all
$tpl_prefix . 'PER_PAGE' => $per_page,
Code: Select all
$tpl_prefix . 'TOPIC_SEO_EXT' => $append,
I have also found the fix for this bug:flycker wrote: Second, bugs without a bug fix:
2. - Unread orange icon (When you are viewing a forum and there are unread threads you can click on the little orange)
2.1
2.2 Go to "http://new1.myforum.com/sdfsdfs-t9.html ... ead#unread" a "404 - Not Found" page.
Code: Select all
'U_NEWEST_POST' => $view_topic_url . '&view=unread#unread',
Code: Select all
'U_NEWEST_POST' => $view_topic_url . '-view=unread#unread',
It works now, it conflicted with another mod in viewtopic.php.rwap01 wrote:I would suggest that you have made an error in the changes to posting.php - see the MODxNLCrEaTiVe wrote:-
Code: Select all
function clean_url($url)
{
$url = trim(str_replace(array('Re:', 're:'), '', $url));
//$find = array('?', '#', '%', '?', '^', '.', '/', ' ', '_', ')', '(', '[', ']', ':', '.');
$find = array(' ', '@', '=', '$', '&', '+', '~', '`', '?', '#', '%', '!', '^', '.', '/', '_', ')', '(', '[', ']', '{', '}', ':', ',', '<', '>', ';', '|', '*', '"', '\'', '\\');
$url = str_replace($find, '-', censor_text($url));
// remove all duplicates "-"
$url = ereg_replace("-+", '-', $url);
// remove the last "-", to avoid this "/test--t14.html"
if ($url{strlen($url)-1} == '-')
{
$url = substr($url, 0, -1);
}
return utf8_clean_string($url);
}