[RC] Aero for phpBB 3.3.12

For style authors to post and receive feedback on 3.3.x styles still in development. Any development styles you wish to use on your live board should be installed with caution!
User avatar
jrolson
Registered User
Posts: 971
Joined: Wed Jan 05, 2005 1:53 am
Location: U.S.

Re: [RC] Aero for phpBB 3.3.7

Post by jrolson »

Mike-on-Tour wrote: Tue Apr 12, 2022 3:12 pm Today I detected something weird just by chance. If you look at the attached screenshot you will see an element just underneath the forum list box which seems to be empty.

Screenshot 2022-04-12 at 16-55-26 Mike-on-Tour.com - Userreminder for phpBB.png

It appears to be just this code:

Code: Select all

<div class="custombg"><div class="customborder"></div></div>
but I can't find it anywhere in the template files.

First I thought it came from an extension because it is displayed right underneath of something one of my extensions displays via the forumlist_body_last_row_after event but after disabling all extensions one by one it is still there (I made the screenshot while all extensions were disabled).

I am not sure whether it is only in the latest version 1.1.8 for phpBB 3.3.7 (which is running on my board) or whether it was there before and I just didn't notice it.
And it can not have its source within prosilver because after switching to prosilver this element wasn't there.

Would you please look into that issue?
This is because you only have subforums in this forum leaving the block for topics empty.

This might be something I can fix but I will have to try and reproduce it.
User avatar
warmweer
Jr. Extension Validator
Posts: 11374
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: [RC] Aero for phpBB 3.3.7

Post by warmweer »

Mike-on-Tour wrote: Tue Apr 12, 2022 4:45 pm In which of the 26 files did you remove this element?
Sorry, multitasking now (mostly cooking)

hmm ... Good question
I just removed a node using Inspector (FF) when viewing a category (viewforum.php?f=1).
It doesn't show up on index.php nor when looking at a normal forum.
Spelling is freeware, which means you can use it for free.
On the other hand, it is not open source, which means you cannot change it or publish it in a modified form.


Time flies like an arrow, but fruit flies like a banana.
maluki
Registered User
Posts: 4
Joined: Tue Apr 12, 2022 5:56 pm
Location: Germany

Re: [RC] Aero for phpBB 3.3.7

Post by maluki »

First let me say thank you for this style. A few days ago I converted an old 3.0 to 3.3 and was glad to find the same style again.

I registered today to report exactly this bug (in my opinion) and my solution.

File: template/viewforum_body.html

Code: Select all

@@ -252,21 +252,23 @@
 	<!-- ENDIF -->
 
 <!-- BEGINELSE -->
-	<div class="custombg"><div class="customborder">
 	<!-- IF S_IS_POSTABLE -->
+	<div class="custombg"><div class="customborder">
 	<div class="panel">
 		<div class="inner">
 		<strong>{{ lang(S_SORT_DAYS ? 'NO_TOPICS_TIME_FRAME' : 'NO_TOPICS') }}</strong>
 		</div>
 	</div>
+	</div></div>
 	<!-- ELSE IF not S_HAS_SUBFORUM -->
+	<div class="custombg"><div class="customborder">
 	<div class="panel">
 		<div class="inner">
 			<strong>{L_NO_FORUMS_IN_CATEGORY}</strong>
 		</div>
 	</div>
-	<!-- ENDIF -->
 	</div></div>
+	<!-- ENDIF -->
 <!-- END topicrow -->
 
 <!-- IF .topicrow and not S_DISPLAY_ACTIVE -->


I found a second design difference, not sure if it is a bug or intended.
The forum rules are surrounded by the same border when in the forum view. But not in the topic view. Is that intended?
forum-rules-viewforum.png
forum-rules-viewtopic.png

I added the same borders in the forum view to get a consistent design.

File: template/viewtopic_body.html

Code: Select all

@@ -13,6 +13,7 @@
 <!-- ENDIF -->
 
 <!-- IF S_FORUM_RULES -->
+	<div class="custombg"><div class="customborder">
 	<div class="rules<!-- IF U_FORUM_RULES --> rules-link<!-- ENDIF -->">
 		<div class="inner">
 
@@ -25,6 +26,7 @@
 
 		</div>
 	</div>
+	</div></div>
 <!-- ENDIF -->
 
 <div class="action-bar bar-top">
While taking the screen shots I saw that the borders are missing in the post editor too. Haven't looked at this yet.
You do not have the required permissions to view the files attached to this post.
User avatar
jrolson
Registered User
Posts: 971
Joined: Wed Jan 05, 2005 1:53 am
Location: U.S.

Re: [RC] Aero for phpBB 3.3.7

Post by jrolson »

Ah yes I see the problem now on the category page.

Maluki's fix seems to work correctly. Rule borders will also be fixed in next version.
User avatar
Mike-on-Tour
Registered User
Posts: 488
Joined: Wed Jan 15, 2020 3:51 pm
Location: Germany
Name: Michael

Re: [RC] Aero for phpBB 3.3.7

Post by Mike-on-Tour »

Thanks maluki,
that seems to solve this issue.
Watz fo lunch?
If you like my extensions or my support please consider a donation: Image
User avatar
jrolson
Registered User
Posts: 971
Joined: Wed Jan 05, 2005 1:53 am
Location: U.S.

Re: [RC] Aero for phpBB 3.3.7

Post by jrolson »

Aero 1.1.9 released
*fixed border showing incorrectly on category page.
*fixed missing board rule borders on viewtopic_body & posting_layout.
maluki
Registered User
Posts: 4
Joined: Tue Apr 12, 2022 5:56 pm
Location: Germany

Re: [RC] Aero for phpBB 3.3.7

Post by maluki »

Thanks jrolson for implementing it that fast. I can now remove my update notes as I do no longer need to patch the files when upgrading. :)
User avatar
Traction
Registered User
Posts: 345
Joined: Fri Jun 06, 2003 8:42 pm
Location: Staten Island, New York

Re: [RC] Aero for phpBB 3.3.7

Post by Traction »

I notice that when adding certain extensions that use Aero (such as php Arcade and cBB Reactions), it is default to a white text. It's quite hard to read on the light powder blue background. With Arcade it's not too bad (notice the white font on the four games listed in my example), but with Reactions it's very hard to see that white smiley face.

Is there any way to change it to black? Or possibly change the background color? I tried changing the colors with the color switch, but it didn't effect the white. I included two examples from my board.
You do not have the required permissions to view the files attached to this post.
Failure is not an option.
Zap! Classic Video Game Forums
User avatar
david63
Registered User
Posts: 20646
Joined: Thu Dec 19, 2002 8:08 am

Re: [RC] Aero for phpBB 3.3.7

Post by david63 »

Traction wrote: Mon May 09, 2022 7:53 am Is there any way to change it to black? Or possibly change the background color?
You would need to speak with the extension developers about this as those extensions would appear to not be compatible with this style and need some files adding to the extension.
David
Remember: You only know what you know and - you don't know what you don't know!

I now no longer support any of my extensions but they will start to become available here
User avatar
Traction
Registered User
Posts: 345
Joined: Fri Jun 06, 2003 8:42 pm
Location: Staten Island, New York

Re: [RC] Aero for phpBB 3.3.7

Post by Traction »

david63 wrote: Mon May 09, 2022 8:58 am
Traction wrote: Mon May 09, 2022 7:53 am Is there any way to change it to black? Or possibly change the background color?
You would need to speak with the extension developers about this as those extensions would appear to not be compatible with this style and need some files adding to the extension.
I did, and they told me to talk to you. :) I do find it odd that both defaulted to white though.
Failure is not an option.
Zap! Classic Video Game Forums
User avatar
david63
Registered User
Posts: 20646
Joined: Thu Dec 19, 2002 8:08 am

Re: [RC] Aero for phpBB 3.3.7

Post by david63 »

Traction wrote: Mon May 09, 2022 7:11 pm they told me to talk to you
Why me? The style has nothing to do with me
David
Remember: You only know what you know and - you don't know what you don't know!

I now no longer support any of my extensions but they will start to become available here
User avatar
jrolson
Registered User
Posts: 971
Joined: Wed Jan 05, 2005 1:53 am
Location: U.S.

Re: [RC] Aero for phpBB 3.3.7

Post by jrolson »

Do you have links to these mods? So I can test them.
User avatar
Traction
Registered User
Posts: 345
Joined: Fri Jun 06, 2003 8:42 pm
Location: Staten Island, New York

Re: [RC] Aero for phpBB 3.3.7

Post by Traction »

david63 wrote: Mon May 09, 2022 8:12 pm
Traction wrote: Mon May 09, 2022 7:11 pm they told me to talk to you
Why me? The style has nothing to do with me
Oops, I meant to the Aero's creator, my bad.
jrolson wrote: Tue May 10, 2022 3:11 am Do you have links to these mods? So I can test them.
Sure, thank you:

php Arcade

cBB Reactions

Edit: Arcade now has a black font, thanks to the owner who let me know that it was a .css file to edit with one line. I haven't yet figured out how to fix cBB Reactions being barely visible, but I strongly suspect that the fix lies in the reactions.css file.
Failure is not an option.
Zap! Classic Video Game Forums
User avatar
jrolson
Registered User
Posts: 971
Joined: Wed Jan 05, 2005 1:53 am
Location: U.S.

Re: [RC] Aero for phpBB 3.3.7

Post by jrolson »

cBB Reactions Fix

Open styles\aero\theme\common.css

At the end add,

Code: Select all

.reaction-button .icon { color: #888888 !important; }
Open styles\aero\theme\stylesheet.css

Find,

Code: Select all

common.css?v=1.1.9
Change to,

Code: Select all

common.css?v=1.1.9b
User avatar
Traction
Registered User
Posts: 345
Joined: Fri Jun 06, 2003 8:42 pm
Location: Staten Island, New York

Re: [RC] Aero for phpBB 3.3.7

Post by Traction »

Thank you so much!
Failure is not an option.
Zap! Classic Video Game Forums

Return to “[3.3.x] Styles in Development”