Convert quoted images to url

[Ger]

The $crepl-variable has one $ too much. Don't know for sure that's what's causing the error, but I guess so.

[Kharon]

problem solved thank you, Ger

find

Code: Select all

$inmessage = str_replace($$crepl, $qcode[1], $inmessage);

replace

Code: Select all

$inmessage = str_replace($crepl, $qcode[1], $inmessage);

[Lurx]

Great idea, works splendidly Thanks!

[stainless_steelrat]

Confirmed. Just installed the image multi-quoting. Works fine on one of the sites....

(with the && fix of course).

[Ger]

Thanks for testing, I changed it in my earlier post.

[Kharon]

suggestion,question and request : attachment images is not working in quote post ?

thank you

[Ger]

That has nothing to do with this MOD. Attachments aren't really a part of the post, but are kinda "linked" to it. So even with a clean, unmodded phpBB3-installation, attachments aren't quoted.

[Kharon]

hmm

okay,I understand

thank you,Ger

[DragonMaster1]

This is a great mod; images in quotes are so annoying.

My board also lets users post YouTube video. That means the video gets quoted too! Argh! So I modded this mod to take care of YouTube too, converting the embedded video player to a text link when quoted. It's my first mod-of-mod....

Look for:

Code: Select all

$qres = preg_replace('#\[img\](.*)\[/img\]#iU', '[ [url=\1]'. $user->lang['IMAGE'] .'[/url] ]', $qmatchin);

Add after:

Code: Select all

$replacement = preg_replace('#\[youtube\]\n*(.*)\n*\[/youtube\]#iU', '[url=$1]Writer posted a YouTube video[/url]', $replacement); // RupertGee Addition

My board supports English only and so I hardcorded the text link; you'll want to change that to language specific text for your multi-lingual board.

Does not work for me

[Ger]

Some more information would help...

[DragonMaster1]

Some more information would help...

Using 304 and code entered exactly as shown

The basic convert to a link works but the YouTube addition does nothing....as if nothing was added at all

[paciuli]

Great mod, really one of the most useful I've come across so far, and the video mod works fine too! I'll add more entries for all my embed codes
Just a minor glitch: this line

Code: Select all

$replacement = preg_replace('#\[url=\n*(.*)\n*\]\n*\[img\]\n*(.*)\n*\[/img\]\n*\[/url\]#iU', '[ [url=$1]'. $user->lang['IMAGE'] .'[/url] ]', $replacement);

converts images surrounded by a URL tag, but the resulting link points to the URL, which could be a web site or whatever. I think it should always point to the image address instead... I'm not very experienced with reg exp, so I can't sort this out myself suggestions?
Thanks a lot!

[Ger]

Using 304 and code entered exactly as shown

The basic convert to a link works but the YouTube addition does nothing....as if nothing was added at all

Perhaps you use different tags voor de youtubes? In that case you should change the code as such. Otherwise, I don't know an you'd probably await RupertGee to answer.

Great mod, really one of the most useful I've come across so far

Thanks!

Just a minor glitch: this line

Code: Select all

    $replacement = preg_replace('#\[url=\n*(.*)\n*\]\n*\[img\]\n*(.*)\n*\[/img\]\n*\[/url\]#iU', '[ [url=$1]'. $user->lang['IMAGE'] .'[/url] ]', $replacement);

converts images surrounded by a URL tag, but the resulting link points to the URL, which could be a web site or whatever. I think it should always point to the image address instead... I'm not very experienced with reg exp, so I can't sort this out myself suggestions?

That's the result of a discussion I had about it. But you can change it by replacing that line to:

Code: Select all

    $replacement = preg_replace('#\[url=\n*(.*)\n*\]\n*\[img\]\n*(.*)\n*\[/img\]\n*\[/url\]#iU', '[ [url=$2]'. $user->lang['IMAGE'] .'[/url] ]', $replacement);

With the $2 backreference you get the second sample pattern (within ( and ) ).

[spoda-b.com]

I installed this mod using AutoMOD and I got the following errors.

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 44: Undefined variable: user
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 44: Trying to get property of non-object
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 45: Undefined variable: user
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 45: Trying to get property of non-object
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 46: Undefined variable: user
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 46: Trying to get property of non-object
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 2119: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3184)

I'm using the latest version of PHPBB, PHP, SQL, etc.
My site is: http://spoda-b.com
My theme is: Hermes Gray
My test account is: test/test

The mod does work, so to speak. However the font on the page/thread is rather large and the error displays above the site in the header (i think is what it's called)

any help is much appreciated.

[spoda-b.com]

I installed this mod using AutoMOD and I got the following errors.

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 44: Undefined variable: user
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 44: Trying to get property of non-object
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 45: Undefined variable: user
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 45: Trying to get property of non-object
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 46: Undefined variable: user
[phpBB Debug] PHP Notice: in file /includes/message_parser.php on line 46: Trying to get property of non-object
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 2119: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3184)

I'm using the latest version of PHPBB, PHP, SQL, etc.
My site is: http://spoda-b.com
My theme is: Hermes Gray
My test account is: test/test

The mod does work, so to speak. However the font on the page/thread is rather large and the error displays above the site in the header (i think is what it's called)

any help is much appreciated.

but after a few seconds it redirects to the post and works fine...