Avatar of poster on Index and Viewforum

[lefty74]

Thanks. I've saved my edits from last time so i just need to rename and put them this time. It'll only take ten minutes. Is the last bit of code the repaired version of my code or a fresh viewforum_body.html file with your edits only? I don't want to lose previous MODs. Thanks again for your help.

thats with my edits only.

[mutank]

Index works fine, but when I try to view a list of topics, I get this

Parse error: syntax error, unexpected T_ELSE in /forums/cache/tpl_prosilver_viewforum_body.html.php on line 128

Any clues to what could be the issue?

[lefty74]

Index works fine, but when I try to view a list of topics, I get this

Parse error: syntax error, unexpected T_ELSE in /forums/cache/tpl_prosilver_viewforum_body.html.php on line 128

Any clues to what could be the issue?

have you doublechecked your template edits already?

[mutank]

Index works fine, but when I try to view a list of topics, I get this

Parse error: syntax error, unexpected T_ELSE in /forums/cache/tpl_prosilver_viewforum_body.html.php on line 128

Any clues to what could be the issue?

have you doublechecked your template edits already?

I've figured out which part of the viewforum_body.html code is causing the issue.

When I apply the first edit. The:

Code: Select all

<!-- IF topicrow.TOPIC_AUTHOR_AVATAR --><span style="float: left; padding-top: 3px; margin-right: {topicrow.TOPIC_AUTHOR_AVATAR_MARGIN}px;">{topicrow.TOPIC_AUTHOR_AVATAR}</span><!-- ENDIF-->

I get that error.

If I have only have the second edit, the :

Code: Select all

<!-- IF topicrow.LAST_POST_AUTHOR_AVATAR --><div style="float: left; padding-top: 0px; margin-left: 5px; margin-right: {topicrow.LAST_POST_AUTHOR_AVATAR_MARGIN}px;">{topicrow.LAST_POST_AUTHOR_AVATAR}</div><!-- ENDIF -->

it works fine.

So to sum up, if I have both edits, pulls up error. Only have the second edit, works fine (But does not show the avatar of the topic creator since thats what the first edit does)

Any suggestions?

[lefty74]

Hello I don't know if this is a bug. But whenever I add

Code: Select all

<!-- IF topicrow.TOPIC_AUTHOR_AVATAR --><span style="float: left; padding-top: 3px; margin-right: {topicrow.TOPIC_AUTHOR_AVATAR_MARGIN}px;">{topicrow.TOPIC_AUTHOR_AVATAR}</span><!-- ENDIF-->

to viewforum_body.html. The ./styles/prosilver/imageset/icon_topic_newest.gif appears. Even I click the Mark Topics Read link, it still shows that ALL topics are "new".

If I do remove the code, the "new" icon is not showing.

I also tried the demo forum. And it exhibits the same pattern. Is there a way to correct this?

Thank you.

annepenullar, I finally realised what it is you meant. There is a small bug in styles/prosilver/template/viewforum_body.html

find

Code: Select all

<!-- ENDIF-->

replace with

Code: Select all

<!-- ENDIF -->

@mutank, does that fix your error as well?
If it doesnt, can you please post the edited code with a few lines above and below the edit.

[Cashis]

Works great thanks lefty

[mutank]

I never had that bug in the viewforum file.

Anyways here is the edit, and code around the first edit that you need to input.

Code: Select all

<!-- IF not topicrow.S_TOPIC_TYPE_SWITCH and not topicrow.S_FIRST_ROW -->
		</ul>
		<span class="corners-bottom"><span></span></span></div>
	</div>
	<!-- ENDIF -->

	<!-- IF topicrow.S_FIRST_ROW or not topicrow.S_TOPIC_TYPE_SWITCH -->
		<div class="forumbg<!-- IF topicrow.S_TOPIC_TYPE_SWITCH --> announcement<!-- ENDIF -->">
		<div class="inner"><span class="corners-top"><span></span></span>
		<ul class="topiclist">
			<li class="header">
				<dl class="icon">
					<dt><!-- IF S_DISPLAY_ACTIVE -->{L_ACTIVE_TOPICS}<!-- ELSEIF topicrow.S_TOPIC_TYPE_SWITCH and topicrow.S_TOPIC_TYPE gt 1 -->{L_ANNOUNCEMENTS}<!-- ELSE -->{L_TOPICS}<!-- ENDIF --></dt>
					<dd class="posts">{L_REPLIES}</dd>
					<dd class="views">{L_VIEWS}</dd>
					<dd class="lastpost"><span>{L_LAST_POST}</span></dd>
				</dl>
			</li>
		</ul>
		<ul class="topiclist topics">
	<!-- ENDIF -->

		<li class="row<!-- IF topicrow.S_ROW_COUNT is even --> bg1<!-- ELSE --> bg2<!-- ENDIF --><!-- IF topicrow.S_POST_ANNOUNCE --> announce<!-- ENDIF --><!-- IF topicrow.S_POST_STICKY --> sticky<!-- ENDIF --><!-- IF topicrow.S_TOPIC_REPORTED --> reported<!-- ENDIF -->">
			<dl class="icon" style="background-image: url({topicrow.TOPIC_FOLDER_IMG_SRC}); background-repeat: no-repeat;">
				<dt<!-- IF topicrow.TOPIC_ICON_IMG and S_TOPIC_ICONS --> style="background-image: url({T_ICONS_PATH}{topicrow.TOPIC_ICON_IMG}); background-repeat: no-repeat;"<!-- ENDIF -->  <!-- IF topicrow.TOPIC_TITLE_HOVER --> title="{topicrow.TOPIC_TITLE_HOVER}"<!-- ELSE --> title="{topicrow.TOPIC_FOLDER_IMG_ALT}"> <!-- IF topicrow.TOPIC_AUTHOR_AVATAR --><span style="float: left; padding-top: 3px; margin-right: {topicrow.TOPIC_AUTHOR_AVATAR_MARGIN}px;">{topicrow.TOPIC_AUTHOR_AVATAR}</span><!-- ENDIF--> <!-- ENDIF --> <!-- IF topicrow.S_UNREAD_TOPIC --><a href="{topicrow.U_NEWEST_POST}">{NEWEST_POST_IMG}</a> <!-- ENDIF --><a href="{topicrow.U_VIEW_TOPIC}" class="topictitle"  <!-- IF topicrow.FIRST_TEXT_HOVER -->title="{topicrow.FIRST_TEXT_HOVER}"<!-- ENDIF -->>{topicrow.TOPIC_TITLE}</a>
					<!-- IF topicrow.S_TOPIC_UNAPPROVED or topicrow.S_POSTS_UNAPPROVED --><a href="{topicrow.U_MCP_QUEUE}">{topicrow.UNAPPROVED_IMG}</a> <!-- ENDIF -->
					<!-- IF topicrow.S_TOPIC_REPORTED --><a href="{topicrow.U_MCP_REPORT}">{REPORTED_IMG}</a><!-- ENDIF --><br />
					<!-- IF topicrow.PAGINATION --><strong class="pagination"><span>{topicrow.PAGINATION}</span></strong><!-- ENDIF -->
					<!-- IF topicrow.ATTACH_ICON_IMG -->{topicrow.ATTACH_ICON_IMG} <!-- ENDIF -->{L_POST_BY_AUTHOR} {topicrow.TOPIC_AUTHOR_FULL} &raquo; {topicrow.FIRST_POST_TIME}
				</dt>
				<dd class="posts">{topicrow.REPLIES} <dfn>{L_REPLIES}</dfn></dd>
				<dd class="views">{topicrow.VIEWS} <dfn>{L_VIEWS}</dfn></dd>
				<dd class="lastpost"> <!-- IF topicrow.LAST_POST_AUTHOR_AVATAR --><div style="float: left; padding-top: 0px; margin-left: 5px; margin-right: {topicrow.LAST_POST_AUTHOR_AVATAR_MARGIN}px;">{topicrow.LAST_POST_AUTHOR_AVATAR}</div><!-- ENDIF --><span><dfn>{L_LAST_POST} </dfn>{L_POST_BY_AUTHOR} {topicrow.LAST_POST_AUTHOR_FULL}
					<!-- IF not S_IS_BOT --><a href="{topicrow.U_LAST_POST}"  <!-- IF topicrow.LAST_TEXT_HOVER -->title="{topicrow.LAST_TEXT_HOVER}"<!-- ENDIF -->> <!-- IF topicrow.LAST_TEXT_HOVER -->{topicrow.LAST_POST_IMG}<!-- ELSE -->{LAST_POST_IMG} <!-- ENDIF --></a> <!-- ENDIF --><br />{topicrow.LAST_POST_TIME}</span>
				</dd>
			</dl>
		</li>

	<!-- IF topicrow.S_LAST_ROW -->
			</ul>
		<span class="corners-bottom"><span></span></span></div>
	</div>
	<!-- ENDIF -->

[lefty74]

you have another mod installed that has edits in that line.

here is what my testboard looks like:

Code: Select all

		<li class="row<!-- IF topicrow.S_ROW_COUNT is even --> bg1<!-- ELSE --> bg2<!-- ENDIF --><!-- IF topicrow.S_POST_ANNOUNCE --> announce<!-- ENDIF --><!-- IF topicrow.S_POST_STICKY --> sticky<!-- ENDIF --><!-- IF topicrow.S_TOPIC_REPORTED --> reported<!-- ENDIF -->">
			<dl class="icon" style="background-image: url({topicrow.TOPIC_FOLDER_IMG_SRC}); background-repeat: no-repeat;">
        <dt<!-- IF topicrow.TOPIC_ICON_IMG and S_TOPIC_ICONS --> style="background-image: url({T_ICONS_PATH}{topicrow.TOPIC_ICON_IMG}); background-repeat: no-repeat;"<!-- ENDIF --> title="{topicrow.TOPIC_FOLDER_IMG_ALT}"><!-- IF topicrow.TOPIC_AUTHOR_AVATAR --><span style="float: left; padding-top: 3px; margin-right: {topicrow.TOPIC_AUTHOR_AVATAR_MARGIN}px;">{topicrow.TOPIC_AUTHOR_AVATAR}</span><!-- ENDIF --><!-- IF topicrow.S_UNREAD_TOPIC --><a href="{topicrow.U_NEWEST_POST}">{NEWEST_POST_IMG}</a> <!-- ENDIF --><a href="{topicrow.U_VIEW_TOPIC}" class="topictitle">{topicrow.TOPIC_TITLE}</a>
					<!-- IF topicrow.S_TOPIC_UNAPPROVED or topicrow.S_POSTS_UNAPPROVED --><a href="{topicrow.U_MCP_QUEUE}">{topicrow.UNAPPROVED_IMG}</a> <!-- ENDIF -->
					<!-- IF topicrow.S_TOPIC_REPORTED --><a href="{topicrow.U_MCP_REPORT}">{REPORTED_IMG}</a><!-- ENDIF --><br />
					<!-- IF topicrow.PAGINATION --><strong class="pagination"><span>{topicrow.PAGINATION}</span></strong><!-- ENDIF -->
					<!-- IF topicrow.ATTACH_ICON_IMG -->{topicrow.ATTACH_ICON_IMG} <!-- ENDIF -->{L_POST_BY_AUTHOR} {topicrow.TOPIC_AUTHOR_FULL} &raquo; {topicrow.FIRST_POST_TIME}
				</dt>
				<dd class="posts">{topicrow.REPLIES} <dfn>{L_REPLIES}</dfn></dd>
				<dd class="views">{topicrow.VIEWS} <dfn>{L_VIEWS}</dfn></dd>
				<dd class="lastpost"> <!-- IF topicrow.LAST_POST_AUTHOR_AVATAR --><div style="float: left; padding-top: 0px; margin-left: 5px; margin-right: {topicrow.LAST_POST_AUTHOR_AVATAR_MARGIN}px;">{topicrow.LAST_POST_AUTHOR_AVATAR}</div><!-- ENDIF --><span><dfn>{L_LAST_POST} </dfn>{L_POST_BY_AUTHOR} {topicrow.LAST_POST_AUTHOR_FULL}
					<!-- IF not S_IS_BOT --><a href="{topicrow.U_LAST_POST}">{

[mutank]

you have another mod installed that has edits in that line.

here is what my testboard looks like:

Code: Select all

		<li class="row<!-- IF topicrow.S_ROW_COUNT is even --> bg1<!-- ELSE --> bg2<!-- ENDIF --><!-- IF topicrow.S_POST_ANNOUNCE --> announce<!-- ENDIF --><!-- IF topicrow.S_POST_STICKY --> sticky<!-- ENDIF --><!-- IF topicrow.S_TOPIC_REPORTED --> reported<!-- ENDIF -->">
			<dl class="icon" style="background-image: url({topicrow.TOPIC_FOLDER_IMG_SRC}); background-repeat: no-repeat;">
        <dt<!-- IF topicrow.TOPIC_ICON_IMG and S_TOPIC_ICONS --> style="background-image: url({T_ICONS_PATH}{topicrow.TOPIC_ICON_IMG}); background-repeat: no-repeat;"<!-- ENDIF --> title="{topicrow.TOPIC_FOLDER_IMG_ALT}"><!-- IF topicrow.TOPIC_AUTHOR_AVATAR --><span style="float: left; padding-top: 3px; margin-right: {topicrow.TOPIC_AUTHOR_AVATAR_MARGIN}px;">{topicrow.TOPIC_AUTHOR_AVATAR}</span><!-- ENDIF --><!-- IF topicrow.S_UNREAD_TOPIC --><a href="{topicrow.U_NEWEST_POST}">{NEWEST_POST_IMG}</a> <!-- ENDIF --><a href="{topicrow.U_VIEW_TOPIC}" class="topictitle">{topicrow.TOPIC_TITLE}</a>
					<!-- IF topicrow.S_TOPIC_UNAPPROVED or topicrow.S_POSTS_UNAPPROVED --><a href="{topicrow.U_MCP_QUEUE}">{topicrow.UNAPPROVED_IMG}</a> <!-- ENDIF -->
					<!-- IF topicrow.S_TOPIC_REPORTED --><a href="{topicrow.U_MCP_REPORT}">{REPORTED_IMG}</a><!-- ENDIF --><br />
					<!-- IF topicrow.PAGINATION --><strong class="pagination"><span>{topicrow.PAGINATION}</span></strong><!-- ENDIF -->
					<!-- IF topicrow.ATTACH_ICON_IMG -->{topicrow.ATTACH_ICON_IMG} <!-- ENDIF -->{L_POST_BY_AUTHOR} {topicrow.TOPIC_AUTHOR_FULL} &raquo; {topicrow.FIRST_POST_TIME}
				</dt>
				<dd class="posts">{topicrow.REPLIES} <dfn>{L_REPLIES}</dfn></dd>
				<dd class="views">{topicrow.VIEWS} <dfn>{L_VIEWS}</dfn></dd>
				<dd class="lastpost"> <!-- IF topicrow.LAST_POST_AUTHOR_AVATAR --><div style="float: left; padding-top: 0px; margin-left: 5px; margin-right: {topicrow.LAST_POST_AUTHOR_AVATAR_MARGIN}px;">{topicrow.LAST_POST_AUTHOR_AVATAR}</div><!-- ENDIF --><span><dfn>{L_LAST_POST} </dfn>{L_POST_BY_AUTHOR} {topicrow.LAST_POST_AUTHOR_FULL}
					<!-- IF not S_IS_BOT --><a href="{topicrow.U_LAST_POST}">{

The edit you provided works fine now. But the topic preview bubble I had before is now gone (I checked the edits and you removed it)

Is there a way to keep both edits in the file?

[lefty74]

i didnt actually remove or change anything, i simply posted the code that i have on my testboard.
what mod is it you are using?

[mutank]

i didnt actually remove or change anything, i simply posted the code that i have on my testboard.
what mod is it you are using?

The topic preview MOD where if you hover your mouse over a topic, a buble appears and tells you a short blurb of what the first post is saying.

Code: Select all

<dt<!-- IF topicrow.TOPIC_ICON_IMG and S_TOPIC_ICONS --> style="background-image: url({T_ICONS_PATH}{topicrow.TOPIC_ICON_IMG}); background-repeat: no-repeat;"<!-- ENDIF -->  <!-- IF topicrow.TOPIC_TITLE_HOVER --> title="{topicrow.TOPIC_TITLE_HOVER}"<!-- ELSE --> title="{topicrow.TOPIC_FOLDER_IMG_ALT}"> <!-- ENDIF --> <!-- IF topicrow.S_UNREAD_TOPIC --><a href="{topicrow.U_NEWEST_POST}">{NEWEST_POST_IMG}</a> <!-- ENDIF --><a href="{topicrow.U_VIEW_TOPIC}" class="topictitle"  <!-- IF topicrow.FIRST_TEXT_HOVER -->title="{topicrow.FIRST_TEXT_HOVER}"<!-- ENDIF -->>{topicrow.TOPIC_TITLE}</a>

Thats the line which contained the topichover mod, its also the same line which the first edit should have been placed into.

[lefty74]

you can try this if you like, havent tried it myself tho:

Code: Select all

   <dt<!-- IF topicrow.TOPIC_ICON_IMG and S_TOPIC_ICONS --> style="background-image: url({T_ICONS_PATH}{topicrow.TOPIC_ICON_IMG}); background-repeat: no-repeat;"<!-- ENDIF -->  <!-- IF topicrow.TOPIC_TITLE_HOVER --> title="{topicrow.TOPIC_TITLE_HOVER}"<!-- ELSE --> title="{topicrow.TOPIC_FOLDER_IMG_ALT}"> <!-- ENDIF --> <!-- IF topicrow.TOPIC_AUTHOR_AVATAR --><span style="float: left; padding-top: 3px; margin-right: {topicrow.TOPIC_AUTHOR_AVATAR_MARGIN}px;">{topicrow.TOPIC_AUTHOR_AVATAR}</span><!-- ENDIF --><!-- IF topicrow.S_UNREAD_TOPIC --><a href="{topicrow.U_NEWEST_POST}">{NEWEST_POST_IMG}</a> <!-- ENDIF --><a href="{topicrow.U_VIEW_TOPIC}" class="topictitle"  <!-- IF topicrow.FIRST_TEXT_HOVER -->title="{topicrow.FIRST_TEXT_HOVER}"<!-- ENDIF -->>{topicrow.TOPIC_TITLE}</a>

[mutank]

you can try this if you like, havent tried it myself tho:

Code: Select all

   <dt<!-- IF topicrow.TOPIC_ICON_IMG and S_TOPIC_ICONS --> style="background-image: url({T_ICONS_PATH}{topicrow.TOPIC_ICON_IMG}); background-repeat: no-repeat;"<!-- ENDIF -->  <!-- IF topicrow.TOPIC_TITLE_HOVER --> title="{topicrow.TOPIC_TITLE_HOVER}"<!-- ELSE --> title="{topicrow.TOPIC_FOLDER_IMG_ALT}"> <!-- ENDIF --> <!-- IF topicrow.TOPIC_AUTHOR_AVATAR --><span style="float: left; padding-top: 3px; margin-right: {topicrow.TOPIC_AUTHOR_AVATAR_MARGIN}px;">{topicrow.TOPIC_AUTHOR_AVATAR}</span><!-- ENDIF --><!-- IF topicrow.S_UNREAD_TOPIC --><a href="{topicrow.U_NEWEST_POST}">{NEWEST_POST_IMG}</a> <!-- ENDIF --><a href="{topicrow.U_VIEW_TOPIC}" class="topictitle"  <!-- IF topicrow.FIRST_TEXT_HOVER -->title="{topicrow.FIRST_TEXT_HOVER}"<!-- ENDIF -->>{topicrow.TOPIC_TITLE}</a>

Works perfectly now. Thanks

[Macster12]

I don't know if this matters, but I keep getting this error:

Code: Select all

SQL query:

ALTER TABLE alvt_forums ADD forum_last_poster_avatar VARCHAR( 255 ) COLLATE utf8_bin NOT NULL default '';

MySQL said: Documentation
#1060 - Duplicate column name 'forum_last_poster_avatar' 

Now, I have the last topic title mod installed ( the one that shows the topics title of course) above the name and date, and I was wondering if that was what was messing it up, as the sql will not inject because that becomes the issue.

And when I go to hit submit when making a new topic I get this:

Code: Select all

SQL ERROR [ mysqli ]

Unknown column 'topic_last_poster_avatar' in 'field list' [1054]

SQL

UPDATE alvt_topics SET topic_first_post_id = 2469, topic_last_post_id = 2469, topic_last_post_time = 1270113156, topic_last_poster_id = 58, topic_last_poster_name = 'Macster', topic_last_poster_colour = 'AA0000', topic_last_poster_avatar = 'http://dmart.uuuq.com/macattack.gif', topic_last_poster_avatar_type = '2', topic_last_poster_avatar_width = '100', topic_last_poster_avatar_height = '100', topic_last_post_subject = 'sss' WHERE topic_id = 449

BACKTRACE

FILE: includes/db/mysqli.php
LINE: 163
CALL: dbal->sql_error()

FILE: includes/functions_posting.php
LINE: 2102
CALL: dbal_mysqli->sql_query()

FILE: posting.php
LINE: 1179
CALL: submit_post()

I can only assume that is because of the mod again, or I missed a code or so in functions_posting.php. Just wondering if ya know or not if that could be affecting it. I also have 3.0.7PL1 if that makes a difference. lefty doesn't have to respond to this if someone else knows the answer, but I am hoping lefty will respond lol.

[lefty74]

hi, have you already checked your database tables (phpbb_topics, phpbb_forums, phpbb_config) to make sure the fields that you executed are in the db?

also, please note that if your prefix is not phpbb_ you will need to change the SQL statement to what you have as your prefix, e.g. if your prefix is phpbb1_ you will need to change the SQL statement to ALTER TABLE phpbb1_topics...

always, purge your cache as well after installing a mod.