[RC2] Sig2Bottom 1.0.2

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Scam Warning
User avatar
iEric
Registered User
Posts: 249
Joined: Mon Apr 10, 2006 10:57 pm
Location: Falköping, Sweden

Re: [RC1] Sig2Bottom 1.0.1

Post by iEric »

RMcGirr83 wrote:Well, looks like I spoke to soon. :(

have a look

Been playing around with the code for ~ 1 hour and I can't get it to work...or look correct.
Ouch..
I think it is the "other" way you loaded the script.

Code: Select all

onload_functions.push('sig2bottom();');
I tried that (and versions of it) on our board and it stopped working. The original script works.
Willl play more with that line of yours later. :)
User avatar
RMcGirr83
Former Team Member
Posts: 22105
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC1] Sig2Bottom 1.0.1

Post by RMcGirr83 »

iEric wrote:Ouch..
I think it is the "other" way you loaded the script.

Code: Select all

onload_functions.push('sig2bottom();');
I tried that (and versions of it) on our board and it stopped working. The original script works.
Willl play more with that line of yours later. :)
On a prosilver based template that is the correct code to load js files. Hint, take a look at overall_header.html.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
User avatar
iEric
Registered User
Posts: 249
Joined: Mon Apr 10, 2006 10:57 pm
Location: Falköping, Sweden

Re: [RC1] Sig2Bottom 1.0.1

Post by iEric »

RMcGirr83 wrote:On a prosilver based template that is the correct code to load js files. Hint, take a look at overall_header.html.
Ah... yes, I looked at that one before. Never got hold of it. But I'll look more.
Thanks.
User avatar
RMcGirr83
Former Team Member
Posts: 22105
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC1] Sig2Bottom 1.0.1

Post by RMcGirr83 »

FWIW, I believe that is the problem that muggins is having with the loss of transparency of the tool tip.

I've removed the mod from my forum, but you can see the same type of effect on my test forum. Which has both of the tool tip as well as this mod installed.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
User avatar
RMcGirr83
Former Team Member
Posts: 22105
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC1] Sig2Bottom 1.0.1

Post by RMcGirr83 »

Messed around with it, now no javascript is used (IIRC that was to add a bottom margin?) and it's all css based now.

I have it installed on both my test forum as well as my live one. Looks okay?

Basically got rid of the javascript call, deleted the css signa and changed this in viewtopic_body.html

Code: Select all

      <!-- MOD: Sig2Bottom -->
      <!-- IF postrow.SIGNATURE --><div class="clear"></div>
      <div id="sigwrap">
         <div id="sig{postrow.POST_ID}" class="signature signa">{postrow.SIGNATURE}</div>
      </div><!-- ENDIF -->
to this

Code: Select all

      <!-- MOD: Sig2Bottom -->
      <!-- IF postrow.SIGNATURE --><div class="clear"></div>
      <div id="sigwrap">
         <div id="sig{postrow.POST_ID}" class="signature">{postrow.SIGNATURE}</div>
      </div><!-- ENDIF -->
warning though, my css foo is weak but it works okay...I think. :?:
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
User avatar
iEric
Registered User
Posts: 249
Joined: Mon Apr 10, 2006 10:57 pm
Location: Falköping, Sweden

Re: [RC1] Sig2Bottom 1.0.1

Post by iEric »

:) Yes, that is something simular with what I started with and tested once a while back. A non-java solution would of course be the best. But what it does... it "builds" the siggy downwards... and not simulating a bottom aligned siggy - or how I should explain it.

Well, it works with the "onload = ..." - and I'll try during the weekend to see if I can get it to load the other (prefered) way. Thanks for all the help/time.
User avatar
iEric
Registered User
Posts: 249
Joined: Mon Apr 10, 2006 10:57 pm
Location: Falköping, Sweden

Re: [RC1] Sig2Bottom 1.0.1a

Post by iEric »

OK, I solved it. :) Script loads fine now with:

Code: Select all

onload_functions.push('sig2bottom();');
Updated the download
User avatar
iEric
Registered User
Posts: 249
Joined: Mon Apr 10, 2006 10:57 pm
Location: Falköping, Sweden

Re: [RC2] Sig2Bottom 1.0.2

Post by iEric »

I've made a "non-java version" for subsilver2.
Made a few corrections and also updated the ReadMe.


1st post updated
Sig2Bottom 1.0.2

:)
User avatar
hww
Registered User
Posts: 177
Joined: Tue Sep 30, 2008 2:52 pm
Location: Wollongong, N.S.W., Australia

Re: [RC2] Sig2Bottom 1.0.2

Post by hww »

*snip*

:oops:

Turned out to be my error. Please ignore. :lol:

MOD works great (including with RMcGirr83's Topic Text in MouseOver MOD, which I also have installed).
Sorry for my English, but I am Australian. Forgive me please.
User avatar
iEric
Registered User
Posts: 249
Joined: Mon Apr 10, 2006 10:57 pm
Location: Falköping, Sweden

Re: [RC2] Sig2Bottom 1.0.2

Post by iEric »

Thanks... Glad you got it sorted out. :)
User avatar
janine
Registered User
Posts: 345
Joined: Sun Mar 24, 2002 6:38 pm
Location: Pa

Re: [RC2] Sig2Bottom 1.0.2

Post by janine »

Love it! Thanks so much!! :D
geoffreak
Registered User
Posts: 591
Joined: Sat Feb 12, 2005 8:39 am

Re: [RC2] Sig2Bottom 1.0.2

Post by geoffreak »

Would it not be simpler just to set the attribute of the css of the signature block to have an absolute position relative to the post block?
Anime Revolution - Your new #1 source for All things anime and manga!
READ MY BLOG ALREADY!
Morun
Registered User
Posts: 30
Joined: Tue Mar 17, 2009 4:28 pm

Re: [RC2] Sig2Bottom 1.0.2

Post by Morun »

Hello,

I have the problem that in long posts, the signature and the bottom of the post are overlaying each other. Any suggestions what might be the problem or how to fix it?

Cheers,
Morun
User avatar
hww
Registered User
Posts: 177
Joined: Tue Sep 30, 2008 2:52 pm
Location: Wollongong, N.S.W., Australia

Re: [RC2] Sig2Bottom 1.0.2

Post by hww »

Morun wrote:I have the problem that in long posts, the signature and the bottom of the post are overlaying each other. Any suggestions what might be the problem or how to fix it?
Are any of the images in your users' signatures failing to load?
Sorry for my English, but I am Australian. Forgive me please.
Morun
Registered User
Posts: 30
Joined: Tue Mar 17, 2009 4:28 pm

Re: [RC2] Sig2Bottom 1.0.2

Post by Morun »

hey hww,

most signatures on my board are just text, in the cases where I observed the issue they were only text as well (including some formating and linking BBcodes).

It seems to happen as soon as text+signature are longer than the user information field, somehow the css doesn't calculate the additional space the signature needs or something like that?

Return to “[3.0.x] MODs in Development”