[RC] Thanks for post by Палыч

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Get Involved
Paulo França Lacerda
Registered User
Posts: 109
Joined: Wed Jun 03, 2009 9:17 am

Re: [RC] Thanks for post by Палыч

Post by Paulo França Lacerda » Fri Jun 12, 2009 8:19 am

Hmmm.. sorry for not being able to create image thumbs. :(
Gone...

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Fri Jun 12, 2009 5:19 pm

Paulo França Lacerda
Thank you for your interest!!! :)

I can add your language files in the archive?
Paulo França Lacerda wrote:should have the column name double-quoted...
Perhaps, I did not work with Firebird as Dabatase :?
Paulo França Lacerda wrote:The PRIMARY KEY should also include the field "POST_ID"
Hmmm... This field is already included...

Code: Select all

PRIMARY KEY (post_id , user_id)
Sorry for my bad english

Paulo França Lacerda
Registered User
Posts: 109
Joined: Wed Jun 03, 2009 9:17 am

Re: [RC] Thanks for post by Палыч

Post by Paulo França Lacerda » Fri Jun 12, 2009 7:16 pm

Палыч wrote:I can add your language files in the archive?

Of Course! I'd be glad.

Палыч wrote:
Paulo França Lacerda wrote:should have the column name double-quoted...
Perhaps, I did not work with Firebird as Dabatase :?
For sure it's true: I do work with FB exclusively. :D
Палыч wrote:
Paulo França Lacerda wrote:The PRIMARY KEY should also include the field "POST_ID"
Hmmm... This field is already included...

Code: Select all

PRIMARY KEY (post_id , user_id)
Sorry for my confusion. I meant all 3 fields should go in the Primary Key, and the SQL Error stops showing up:

Code: Select all

PRIMARY KEY (post_id , POSTER_ID, user_id)
[/color]

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Fri Jun 12, 2009 7:33 pm

Paulo França Lacerda wrote:Of Course! I'd be glad.
OK. Thanks! :)
Paulo França Lacerda wrote:For sure it's true: I do work with FB exclusively.
OK, correct, thanks! :)
Paulo França Lacerda wrote:I meant all 3 fields should go in the Primary Key
Strange. The combination of fields post_id and user_id is enough for the unique identification of records (because the post_id has only one author - poster_id) :?
Sorry for my bad english

Paulo França Lacerda
Registered User
Posts: 109
Joined: Wed Jun 03, 2009 9:17 am

PTBR 2nd Edition

Post by Paulo França Lacerda » Fri Jun 12, 2009 8:34 pm

Just upload an update for the PTBR pack with 1 translation fixed (as in the screenshot below), 1 additional screenshot (below), and also created the translation history (included in the zip).

PTBR 2nd Edition:
MOD.Thank4Post.v122.PTBR-Trad.2.zip

Screenshot #8:
list of thanks received for a given message
lista de agradecimentos recebidos por uma dada postagem

Image

Paulo França Lacerda
Registered User
Posts: 109
Joined: Wed Jun 03, 2009 9:17 am

Re: [RC] Thanks for post by Палыч

Post by Paulo França Lacerda » Fri Jun 12, 2009 8:42 pm

Палыч wrote:
Paulo França Lacerda wrote:I meant all 3 fields should go in the Primary Key
Strange. The combination of fields post_id and user_id is enough for the unique identification of records (because the post_id has only one author - poster_id) :?
Yes, it's correct, but dunno why I was getting an SQL Error related to Primary Key violation.
If anybody has faced the error, all right, but the 3-key approach wouldn't hurt.

Now I understand what happened...
It happens that I used EMS SEL Manager in order to create the THANK table directly into Firebird Database and, when creating the Primary Key, I must have (mistakenly) selected the field POSTER_ID instead of POST_ID. That must have caused the PK SQL Error when the reader tried to thank a second post of the same author.

Infact, just the 2 fields (POST_ID and USER_ID) are enough in the PK.
Sorry for the confusion. :oops:

So the SQL Sentence for preparing the Firebird Database can be:

Code: Select all

CREATE TABLE ATS_THANKS (
  POST_ID   INTEGER DEFAULT 0 NOT NULL,
  POSTER_ID INTEGER DEFAULT 0 NOT NULL,
  USER_ID   INTEGER DEFAULT 0 NOT NULL);

ALTER TABLE ATS_THANKS 
  ADD CONSTRAINT CPK_THANKS PRIMARY KEY (USER_ID,POST_ID);

ALTER TABLE phpbb_users 
  ADD user_allow_thanks_pm SmallInt DEFAULT '0' NOT NULL;
[/color]
Last edited by Paulo França Lacerda on Fri Jun 12, 2009 10:43 pm, edited 1 time in total.

Paulo França Lacerda
Registered User
Posts: 109
Joined: Wed Jun 03, 2009 9:17 am

Visual issue in prosilver

Post by Paulo França Lacerda » Fri Jun 12, 2009 10:39 pm

Well, this bug I'm unable to solve:

When using prosilver style (dunno about others), the thank list that appears on user's profile are wider than its parent box, as shown in my screenshot #7:


Image

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Fri Jun 12, 2009 10:54 pm

Paulo França Lacerda wrote:Infact, just the 2 fields (POST_ID and USER_ID) are enough in the PK.
OK
Otherwise, I thought it was time for me to school :lol: :lol: :lol:
Paulo França Lacerda wrote:When using prosilver style (dunno about others), the thank list that appears on user's profile are wider than its parent box
And as it looks at this memberlist?
Sorry for my bad english

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Fri Jun 12, 2009 11:21 pm

New ver 1.2.3 in the first post
  • Fix minor bags and optimized code (thanks tumba25).
  • Аdjusted BBCODE parsing in the thanklist search.
  • Аdjusted thankslist.php is viewable if "Can view list of thanks" is set to NO.
  • Updated files for English language (thanks knmt).
  • Added files for French (thanks zach').
  • Added files for Brazilian Portuguese (thanks Paulo França Lacerda).
Sorry for my bad english

Paulo França Lacerda
Registered User
Posts: 109
Joined: Wed Jun 03, 2009 9:17 am

Re: [RC] Thanks for post by Палыч

Post by Paulo França Lacerda » Sat Jun 13, 2009 12:59 am

Палыч wrote:
Paulo França Lacerda wrote:When using prosilver style (dunno about others), the thank list that appears on user's profile are wider than its parent box
And as it looks at this memberlist?
Bang! Hehehe... yes, tue bug seems to lie in phpBB code, as the usual memberlist too is wider than its parent. Sorry for the false-alarm. :D

Now, taking the oportunity, I have uploaded 3rd edition of the PTBR pack, with these changes:
1) Changed translated texts used as hints for the "Do Thank" and "Remove Thank" buttons.
2) Explained the confusion I did with the 3-key PK.
3) Included the image in the "subsilver2" style and its own folder, but didn't change the "hand" picture in these images (it's universal). 8-)

Thank4Post.v122.PTBR-3aEd.zip

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Sat Jun 13, 2009 11:52 am

Paulo França Lacerda wrote:Sorry for the false-alarm.
OK, all right. 8-)
Paulo França Lacerda wrote:Changed translated texts used as hints for the "Do Thank" and "Remove Thank" buttons.
Included in the archive ver 1.2.3.
A few observations:
Your files in WIN-format (must be in UNIX) and have a tag BOM (this is not acceptable).
Paulo França Lacerda wrote:) Included the image in the "subsilver2" style and its own folder
Included in the archive ver 1.2.3.

Thanks! :)
Sorry for my bad english

Paulo França Lacerda
Registered User
Posts: 109
Joined: Wed Jun 03, 2009 9:17 am

Re: [RC] Thanks for post by Палыч

Post by Paulo França Lacerda » Sat Jun 13, 2009 7:06 pm

Палыч wrote:Your files in WIN-format (must be in UNIX) and have a tag BOM (this is not acceptable).
1) Well, files must be UTF8 without BOM, but I cannot save in UTF8 without BOM in Windows. Is there any tool for that?
2) How to save it in UNIX format (with just CR instead of CRLF) from Windows 2003?
Last edited by Paulo França Lacerda on Sat Jun 13, 2009 8:53 pm, edited 1 time in total.

Paulo França Lacerda
Registered User
Posts: 109
Joined: Wed Jun 03, 2009 9:17 am

Suggestion

Post by Paulo França Lacerda » Sat Jun 13, 2009 7:15 pm

Two columns in the Thank List could also be clickable (for sorting by column): "Thanks Given" and "Thanks Received" (dunno the official names in english).

This would be very handy when user wants to see who is "best thanked" and who is "best grateful".

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Sat Jun 13, 2009 8:58 pm

Paulo França Lacerda wrote:Is there any tool for that?
http://wiki.phpbb.com/Text_Editors
use notepad++
Paulo França Lacerda wrote:This would be very handy when user wants to see who is "best thanked" and who is "best grateful".
I think about it. But to use the built-in sorting can not be - for that you need to add the fields in the phpbb_users or very heavy code. While I have no solutions.
Sorry for my bad english

Paulo França Lacerda
Registered User
Posts: 109
Joined: Wed Jun 03, 2009 9:17 am

Re: [RC] Thanks for post by Палыч

Post by Paulo França Lacerda » Sat Jun 13, 2009 9:02 pm

Paulo França Lacerda wrote:1) Well, files must be UTF8 without BOM, but I cannot save in UTF8 without BOM in Windows. Is there any tool for that?
Ok, found Notgepad++ (ops... I posted right before reading your advice. THanks.) :D

The CRLF issue I'll see if Notepad++ is able to save (I'm still downloading it).

Locked

Return to “[3.0.x] MODs in Development”