[DEV] Trade MOD -Under Redevelopment-

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment! No new topics are allowed in this forum.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: MOD Development Forum rules

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Buga
Registered User
Posts: 15
Joined: Sun Nov 09, 2003 5:54 pm

[DEV] Trade MOD -Under Redevelopment-

Post by Buga »

Well tell what you think or any errors you find. It is made for Eric's STORE MOD. Also tell me what I can improve.

Download: -No longer avaliablem, code being rewritten-
Last edited by Buga on Thu Jan 29, 2004 1:21 am, edited 1 time in total.

dennistt
Registered User
Posts: 271
Joined: Sat May 10, 2003 12:06 am
Location: DennisTT.Net
Contact:

Post by dennistt »

*edit
Last edited by dennistt on Thu Nov 20, 2003 3:54 am, edited 1 time in total.

dennistt
Registered User
Posts: 271
Joined: Sat May 10, 2003 12:06 am
Location: DennisTT.Net
Contact:

Post by dennistt »

*edit
Last edited by dennistt on Thu Nov 20, 2003 3:54 am, edited 1 time in total.

dennistt
Registered User
Posts: 271
Joined: Sat May 10, 2003 12:06 am
Location: DennisTT.Net
Contact:

Post by dennistt »

The functions page

Code: Select all

	if ( !$result = $db->sql_query($sql) )
    	{
      		message_die(GENERAL_ERROR, "Error sending item or you do not own that item", "", __LINE__, 						__FILE__, $sql);
    	}
Don't you have to use $lang[] for that and all the other texts?

The trade.php page

Code: Select all

if ( !$userdata['session_logged_in'] )
{
	$redirect = "magic.$phpEx";
	$redirect .= ( isset($user_id) ) ? '&user_id=' . $user_id : '';
	header('Location: ' . append_sid("login.$phpEx?redirect=$redirect", true));
}
I don't think I have magic.php

Code: Select all

	$main = "<center>Succesfully sent item!</center>";
I thought <center> wasn't in the specification anymore.

Please note, I'm not experienced in MODs, so I can be totally wrong.

BTW, I'm very interested in this MOD :)

Buga
Registered User
Posts: 15
Joined: Sun Nov 09, 2003 5:54 pm

Post by Buga »

Well your right about the magic thing thats a different mod I am workin on :D

Code: Select all

 if ( !$result = $db->sql_query($sql) ) 
       { 
            message_die(GENERAL_ERROR, "Error sending item or you do not own that item", "", __LINE__,                   __FILE__, $sql); 
       } 
Nope, you dont need to. If you need a translation you will have to get someone to translate the text in there

Code: Select all

$main = "<center>Succesfully sent item!</center>"; 

Well I try to use as little html as I can but it doesnt look good without it :?

Well all problems fixed redownload thanks for telling me :D

User avatar
morpheus2matrix
Former Team Member
Posts: 9171
Joined: Wed Apr 10, 2002 7:31 pm
Location: France
Contact:

Post by morpheus2matrix »

Buga wrote: Nope, you dont need to.


it's not necessary but it could be better for translations :wink:
Former phpBB MOD-Team Member -

Forgive my bad English :(

No support by PM/Email - Thanks - You can thanks me here :) - Pay me for installing MOD's :lol:

Buga
Registered User
Posts: 15
Joined: Sun Nov 09, 2003 5:54 pm

Post by Buga »

o ok :D

wGEric
Former Team Member
Posts: 8805
Joined: Sun Oct 13, 2002 3:01 am
Location: Friday
Name: Eric Faerber
Contact:

Post by wGEric »

morpheus2matrix wrote:
Buga wrote:
Nope, you dont need to.


it's not necessary but it could be better for translations :wink:


Its required if you are going to try to get this into the MOD Database.
Eric

dennistt
Registered User
Posts: 271
Joined: Sat May 10, 2003 12:06 am
Location: DennisTT.Net
Contact:

Post by dennistt »

:D You left your trade.php header as store.php :D

Code: Select all

/***************************************************************************
 *                              store.php
 *                            -------------------
 *   begin                : Wednesday, 19 November, 2003
 *   copyright            : (C) 2003 Buga
 *   email                : bugabog@hotmail.com
 *
 *   $Id: store.php,v 1.0.0.0 2003/11/19 Buga $
 *
 *
 ***************************************************************************/
----
trade.php

Code: Select all

	$stats="<form method='POST'>
		ItemName: <input type='text' name='iname'><br>
		User to Send to: <input type='text' name='usertosend'><br>
		<input type='submit' value='Update'>
		</form>";
Don't forms need actions?
----
trade.php

Code: Select all

if(!$_POST) {
isset()? (from phpBB coding standards)

Buga
Registered User
Posts: 15
Joined: Sun Nov 09, 2003 5:54 pm

Post by Buga »

oops I used the heading from the store.php and forgot to modify that!

Nope if you leave the action blank it just posts to the page your on which is what I needed :D

Yup I should have done that! I will in the next version

dennistt
Registered User
Posts: 271
Joined: Sat May 10, 2003 12:06 am
Location: DennisTT.Net
Contact:

Post by dennistt »

Oh so that covers the append_sid() thing?

Buga
Registered User
Posts: 15
Joined: Sun Nov 09, 2003 5:54 pm

Post by Buga »

What?

dennistt
Registered User
Posts: 271
Joined: Sat May 10, 2003 12:06 am
Location: DennisTT.Net
Contact:

Post by dennistt »


dennistt
Registered User
Posts: 271
Joined: Sat May 10, 2003 12:06 am
Location: DennisTT.Net
Contact:

Post by dennistt »

*bump*

dennistt
Registered User
Posts: 271
Joined: Sat May 10, 2003 12:06 am
Location: DennisTT.Net
Contact:

Post by dennistt »

Hellooo :)

Post Reply

Return to “[2.0.x] MODs in Development”