[ABD] phpbbchat 0.4.0 (facebook like chat)

[stathisch]

Will have to look into that.

I've got fixes for IE8+ btw, soon there will be style fixes for IE7 too.
For IE8+:

open up js/phpbbchat.js
Find

Code: Select all

					'typing': 0,

Replace-with

Code: Select all

					'typing': 0

Find

Code: Select all

		var UsersChatting = ($.cookie( 'phpBBchat_chatting' )).split( '.' );

Replace-with

Code: Select all

		var UsersChatting = ( $.cookie( 'phpBBchat_chatting' ) == undefined ) ? '' : ($.cookie( 'phpBBchat_chatting' )).split( '.' );

Find

Code: Select all

						'unread': ( Unread[ item.USER_ID ] == undefined ) ? 0 : Unread[ item.USER_ID ],

Replace-with

Code: Select all

						'unread': ( Unread[ item.USER_ID ] == undefined ) ? 0 : Unread[ item.USER_ID ]

That's it.

[darkonia]

the performance must be better in the future, so the mod is sinfree on a big board.

[master1986]

Will have to look into that.

I've got fixes for IE8+ btw, soon there will be style fixes for IE7 too.
For IE8+:

open up js/phpbbchat.js
Find

Code: Select all

					'typing': 0,

Replace-with

Code: Select all

					'typing': 0

Find

Code: Select all

		var UsersChatting = ($.cookie( 'phpBBchat_chatting' )).split( '.' );

Replace-with

Code: Select all

		var UsersChatting = ( $.cookie( 'phpBBchat_chatting' ) == undefined ) ? '' : ($.cookie( 'phpBBchat_chatting' )).split( '.' );

Find

Code: Select all

						'unread': ( Unread[ item.USER_ID ] == undefined ) ? 0 : Unread[ item.USER_ID ],

Replace-with

Code: Select all

						'unread': ( Unread[ item.USER_ID ] == undefined ) ? 0 : Unread[ item.USER_ID ]

That's it.

This fix did you also introduced on your board? if you need to login with IE8, by username tester, still gives me error.

[stathisch]

the performance must be better in the future, so the mod is sinfree on a big board.

Define performance
I mean, server requests can't be cut down too much. It is already lighter than facebook's, making less requests and transferring less data. A big board will need a big server with a big processor and a lot of ram.

Now, about client performance... I will try to fix things up, as much as I can and/or is possible. Don't forget the fact that, for example, when you browse facebook you usually have 1 tab open. When you're on a forum, it may be 10. How far can optimization go?

This fix did you also introduced on your board? if you need to login with IE8, by username tester, still gives me error.

No, this patch hasn't yet been applied on the demo board. I will do that now.

[keith10456]

This one is pretty fast (although buggy). Maybe you can compare and see where an improvement can be made on the performance/speed/lag issue:

http://www.phpbb.com/community/viewtopi ... &t=2008845

[stathisch]

This one is pretty fast (although buggy). Maybe you can compare and see where an improvement can be made on the performance/speed/lag issue:

http://www.phpbb.com/community/viewtopi ... &t=2008845

When you say 'lag', I guess you mean the lag when sending a message. Well, you see there are three techniques, mainly of doing this:
1) Post a message, show it to the user and parallel to that, send it to the server. End of story. If a message doesn't finally get sent, say, 'cause of a problem, nothing happens, the user thinks it's sent.
2) Post a message, send it to the server, and show it to the user when the server informs the client that it's sent. Makes the user think it lags.
3) Combination of the above 2. This way the user never knows it lags. There are of course, downsides of this, like in the above 2.

I am currently using #2. I will try to make it work like #3.

Now, about the mod you posted me. It may be using technique #1. Fixing bugs, in this kind of mod, or software, will involve error checking or other methods that will add server requests/client side code. This 'extra' code, can then, lead to 'lag'.

[darkonia]

@keith: on ya board with so many people it runs ok?

on my small board wirh only 1k people i have a much of probs with the performance...

[keith10456]

@keith: on ya board with so many people it runs ok?

on my small board wirh only 1k people i have a much of probs with the performance...

On my live board I'm using the mod I posted and referenced (I looking forward to using the one in this topic). No noticeable problem with performance... but as I said, it's quite buggy. Also, I don't know for sure if there would or wouldn't be a problem if a lot of people were chatting at the same time.

I tested this mod on the demo site. That's where I noticed the performance issue.

[stathisch]

On my live board I'm using the mod I posted and referenced (I looking forward to using the one in this topic). No noticeable problem with performance... but as I said, it's quite buggy. Also, I don't know for sure if there would or wouldn't be a problem if a lot of people were chatting at the same time.

I tested this mod on the demo site. That's where I noticed the performance issue.

Please, don't use the demo board as a performance-reference site.
It's running on my dev server, in my office with 1mbit of upload.

[master1986]

Will have to look into that.

I've got fixes for IE8+ btw, soon there will be style fixes for IE7 too.
For IE8+:

open up js/phpbbchat.js
Find

Code: Select all

					'typing': 0,

Replace-with

Code: Select all

					'typing': 0

Find

Code: Select all

		var UsersChatting = ($.cookie( 'phpBBchat_chatting' )).split( '.' );

Replace-with

Code: Select all

		var UsersChatting = ( $.cookie( 'phpBBchat_chatting' ) == undefined ) ? '' : ($.cookie( 'phpBBchat_chatting' )).split( '.' );

Find

Code: Select all

						'unread': ( Unread[ item.USER_ID ] == undefined ) ? 0 : Unread[ item.USER_ID ],

Replace-with

Code: Select all

						'unread': ( Unread[ item.USER_ID ] == undefined ) ? 0 : Unread[ item.USER_ID ]

That's it.

This fix did you also introduced on your board? if you need to login with IE8, by username tester, still gives me error.

Very good, the fix works, now I can see the chat with IE8. The strange thing is the chat bar. Google and Firefox with C output only on the right, under the open windows. While IE with the extended view from left to right. You could have the same result in firefox and google c?

[stathisch]

Very good, the fix works, now I can see the chat with IE8. The strange thing is the chat bar. Google and Firefox with C output only on the right, under the open windows. While IE with the extended view from left to right. You could have the same result in firefox and google c?

You mean, extended view with the bar spanning from left to right?
Thats a problem with IE, it's supposed to be like it is in Firefox or Chrome.

[master1986]

Very good, the fix works, now I can see the chat with IE8. The strange thing is the chat bar. Google and Firefox with C output only on the right, under the open windows. While IE with the extended view from left to right. You could have the same result in firefox and google c?

You mean, extended view with the bar spanning from left to right?
Thats a problem with IE, it's supposed to be like it is in Firefox or Chrome.

It is true. In IE bar expands from left to right. While in Firefox and Google C, is scaled down to the right, based on the number of open chat.

is a problem in IE?

[master1986]

would be interesting, if imported into the time that messages are delivered

[AndreasP]

Will this work with any other theme? I have quasar theme (http://www.students2share.com/quasar.zip)
Thanks

[stathisch]

is a problem in IE?

Yes, but I will figure out a workaround for it.

would be interesting, if imported into the time that messages are delivered

What?

Will this work with any other theme? I have quasar theme (http://www.students2share.com/quasar.zip)
Thanks

It probably will.