[ADB] Facebook For PhpBB Light

Any abandoned MODs will be moved to this forum.

WARNING: MODs in this forum are not currently being supported or maintained by the original MOD author. Proceed at your own risk.
Forum rules
IMPORTANT: MOD Development Forum rules

WARNING: MODs in this forum are not currently being supported nor updated by the original MOD author. Proceed at your own risk.
User avatar
keitzy
Registered User
Posts: 359
Joined: Thu Nov 12, 2009 6:32 am
Location: Esperance, Western Australia

Re: [RC] Facebook For PhpBB Light

Post by keitzy »

urednik wrote:
keitzy wrote:You downloaded the patch file.

Download below and install then install the patch file. :)
http://sourceforge.net/projects/fb2011/ ... p/download
In first post of this MOD there is WRONL DOWNLOAD LINK !!

I also download this patch first, so maybe there is good idea to repair link ....
It nice to see that the time and effort put into this mod is appreciated. Thank you.
Image
zaki@wer
Registered User
Posts: 2
Joined: Wed Nov 14, 2012 11:04 am

Re: [RC] Facebook For PhpBB Light

Post by zaki@wer »

Hi guys,

am prob being thick here... so apologies if i missed something downright stupid.

i installed phpbb a week or so ago but my people now want facebook connect on it. fine so i decided to install the mod. downloaded both patch and actual mod.
proceeded w installing the mod, got an error telling me that a div in overall_footer.html wasnt found. amended manually so the install went thru ok.
still no fb tab? i thought this was where i was supposed to enter fb app details and the like? clues as to why the tab isnt appearing before i do something i regret?
i havent actually been able to install the patch yet due to the errors below:
includes/functions_display.php

Code: Select all

Find
	return '<img src="' . ($avatar_type == AVATAR_REMOTE_FB) ? $avatar_img : (str_replace(' ', '%20', $avatar_img)) . '" width="' . $avatar_width . '" height="' . $avatar_height . '" alt="' . ((!empty($user->lang[$alt])) ? $user->lang[$alt] : $alt) . '" />';
Replace With
	$avatar_return = ($avatar_type == AVATAR_REMOTE_FB) ? $avatar_img : '<img src="' . (str_replace(' ', '%20', $avatar_img)) . '" width="' . $avatar_width . '" height="' . $avatar_height . '" alt="' . ((!empty($user->lang[$alt])) ? $user->lang[$alt] : $alt) . '" />';
	return $avatar_return;
The Find specified by the MOD could not be found
styles/prosilver/template/ucp_avatar_options.html

Find
	<!-- IF not S_AVATARS_ENABLED or not S_LINK_AVATAR_FB -->
Replace With
	<!-- IF not S_AVATARS_ENABLED -->
The Find specified by the MOD could not be found
but surely the tab should have appeared anyhow right?
SwT-CarbonzZ
Registered User
Posts: 575
Joined: Tue Oct 12, 2010 7:17 am

Re: [RC] Facebook For PhpBB Light

Post by SwT-CarbonzZ »

everything whent ok but i don't see a facebookbutton?

www.psntrophies.net
User avatar
keitzy
Registered User
Posts: 359
Joined: Thu Nov 12, 2009 6:32 am
Location: Esperance, Western Australia

Re: [RC] Facebook For PhpBB Light

Post by keitzy »

zaki@wer wrote:Hi guys,
To install the mod, download Facebook For PhpBB Light and install it first then download Facebook For PhpBB Light Patch and install after the main install.
SwT-CarbonzZ wrote:everything whent ok but i don't see a facebookbutton?

http://www.psntrophies.net
The problem is that Facebook ninja changed its languages XML file.
So what happened is the country locale(language) chosen no longer exists.
Please right click this link and save as FacebookLocales.xml.

Then upload to your_forum_root_dir/fb4phpbb_light.
Image
SwT-CarbonzZ
Registered User
Posts: 575
Joined: Tue Oct 12, 2010 7:17 am

Re: [RC] Facebook For PhpBB Light

Post by SwT-CarbonzZ »

Strange still not working.

Edit i changed in configuration the language to EN UK and the button shows up but now i get this when i try to login in.

Code: Select all

An error occurred. Please try later
Last edited by SwT-CarbonzZ on Thu Nov 15, 2012 10:11 am, edited 1 time in total.
fanys12
Registered User
Posts: 38
Joined: Tue Feb 16, 2010 5:33 pm

Re: [RC] Facebook For PhpBB Light

Post by fanys12 »

Thank you for mod. But when I try to link forum account and facebook account it fails.
I click login with facebook, auth with facebook, pop up closes and I am waiting. There appears another pop up (now with jquery on forum) and diseappears after about 5 seconds.

And I must note that installation to absolution style is a bit more complicated. There is conflict with jquery library, so you must delete this:

Code: Select all

<!--[if IE]><!-->
<script type="text/javascript" src="{T_SUPER_TEMPLATE_PATH}/jquery.min.js"></script>
<script type="text/javascript" src="{T_SUPER_TEMPLATE_PATH}/jquery-ui.min.js"></script>
<!--<![endif]-->
<!--[if !IE]><!-->
<script type="text/javascript" src="//ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>
<script type="text/javascript" src="//ajax.googleapis.com/ajax/libs/jqueryui/1.8.23/jquery-ui.min.js"></script>
<!--<![endif]-->
from fb4phpbbjfunctions.html and insert this:

Code: Select all

<!--[if IE]><!-->
<script type="text/javascript" src="{T_SUPER_TEMPLATE_PATH}/jquery-ui.min.js"></script>
<!--<![endif]-->
<!--[if !IE]><!-->
<script type="text/javascript" src="//ajax.googleapis.com/ajax/libs/jqueryui/1.8.24/jquery-ui.min.js"></script>
<!--<![endif]-->
to overall_header.html after this line:

Code: Select all

<script type="text/javascript" src="{T_SUPER_TEMPLATE_PATH}/forum_fn.js"></script>
But still i am not able to login/or use facebook api. I think that problem is somewhere in the configuration in facebook side according to error. My language of facebook and forum is czech. All files copied and language entires inserted.
Last edited by fanys12 on Thu Nov 15, 2012 11:58 am, edited 2 times in total.
zaki@wer
Registered User
Posts: 2
Joined: Wed Nov 14, 2012 11:04 am

Re: [RC] Facebook For PhpBB Light

Post by zaki@wer »

To install the mod, download Facebook For PhpBB Light and install it first then download Facebook For PhpBB Light Patch and install after the main install.
many thanks for your prompt answer.
yup did just that, got probs installing Facebook For PhpBB Light, fixed that so the install would go thru. more probs as highlighted in previous message w the patch itself which as of now i cannot install.

i guess i will have to figure out how to make the patch work and prob amend the code manually, but i thought at least even if the fb connect button wouldnt work/show due to lack of patch, i could see the tab without having to install the patch.
The problem is that Facebook ninja changed its languages XML file.
So what happened is the country locale(language) chosen no longer exists.
Please right click this link and save as FacebookLocales.xml.

Then upload to your_forum_root_dir/fb4phpbb_light.
curse fb and their constant changes.
thanks for flagging that.
Malou_pitawawa
Registered User
Posts: 21
Joined: Mon Sep 05, 2011 12:44 am

Re: [RC] Facebook For PhpBB Light

Post by Malou_pitawawa »

Thanks for the MOD! I was about to write one of my own, but now most of the job is done. I did a manual install on my custom theme (based on Subsilver) and everything went smooth.

Here are some note I've taken that could help you improve the MOD:
  • Some languages keys are missing in the Javascript part of the loggin.
  • Since the login code (added in index_body, login_body, login_forum I think) is the same, wouldn't it be easier to add the code to a new template file (fb_login.html) and include this file in each pages? It's easier after that when you have corrections to do, you don't have to correct the same code 3 times.
  • Not a big deal, but in the ACP code, the Secret Key could be a password field, for "privacy"
  • I use a lot of MODs on my site and created a lot alos. I like when MODs add comments in the code changes . I don't know it it's a phpBB Mod standards (I never published one of my mods), but it help find the modified code when you look back at your code.
  • On the login javascript page, you replace "#page-body". Subsilver or customs doen't have this. Not big deal again since subsilver support is not included, but as a note.
  • I translated in French for my site, lot of old stuff in the lang files.
  • Like fanys12 said, some installations are already using Jquery or even jQuery-UI. I would personally add both of them separately in the install instructions so it can be skipped if necessary.
  • That being said, I already had a dialog on my index using "dialog-confirm". Not a good idea to keep the default name in the case of a MOD. Since I often use those dialog on my site, I created a nice javascript function that create dialog on the fly ("Div" created on the fly). I could send you the function
  • Also, with your dialog, what you can do is bind the page redirect on the "OK" button sometimes, so the user have time to read the stuff before the page is redirect.

Very nice mod anyway. Do you have a GitHub account? I would like to contribute to your MOD.


EDIT: Added on last thing to the list
Malou_pitawawa
Registered User
Posts: 21
Joined: Mon Sep 05, 2011 12:44 am

Re: [RC] Facebook For PhpBB Light

Post by Malou_pitawawa »

Sorry if it has already been asked, I didn't read all the pages.

The MOD currently associate phpBB users with their Facebook profile using the email address. What if two phpBB users have the same address? I activated this function on my board, so it is going to cause problems for me.


Also, let say I have two users: User A with email [email protected] and user B with email [email protected]. The browser is logged into Facebook with email [email protected], but on phpBB the user B is currently connected. When the link is created in UCP, it will work, but it's actually phpBB user A who's account will be linked...
SwT-CarbonzZ
Registered User
Posts: 575
Joined: Tue Oct 12, 2010 7:17 am

Re: [RC] Facebook For PhpBB Light

Post by SwT-CarbonzZ »

An error occurred. Please try later

API Error Code: 191
API Error Description: The specified URL is not owned by the application
Error Message: Invalid redirect_uri: Given URL is not permitted by the application configuration.

This is when you try to login with facebook

www.psntrophies.net
User avatar
keitzy
Registered User
Posts: 359
Joined: Thu Nov 12, 2009 6:32 am
Location: Esperance, Western Australia

Re: [RC] Facebook For PhpBB Light

Post by keitzy »

@SwT-CarbonzZ

Please go into your app settings on facebook developer and input your domain url.

@Malou_pitawawa

The fb-init I set up checks if the current user browsing the forum is also the one connected via facebook.
The mod needs quite a bit of tweaks atm.
I'm waiting on a direction from PhpBB to see what move next is from them.
I also am rewriting the mod to be 100% hooked.
The alternate login mod is on github and looking for people to contribute.

@fanys12

I do apologize for the conflicts caused but trying to detect another instance and run this dynamically just causes more problems.
In the next release I will inlcude a switch to turn the JS scripts off to stop conflict.
Just delete those lines of code.
Image
SwT-CarbonzZ
Registered User
Posts: 575
Joined: Tue Oct 12, 2010 7:17 am

Re: [RC] Facebook For PhpBB Light

Post by SwT-CarbonzZ »

It would be nice to some pics how app settings look on facebook and other things because its still not working for me. do you need a heroku ? What do you all need to do to get this working i don't understand it www.psntrophies.net/test
Malou_pitawawa
Registered User
Posts: 21
Joined: Mon Sep 05, 2011 12:44 am

Re: [RC] Facebook For PhpBB Light

Post by Malou_pitawawa »

keitzy wrote:@Malou_pitawawa
The fb-init I set up checks if the current user browsing the forum is also the one connected via facebook.
Yes, but it does so by comparing the emails from phpBB and Facebook. Two phpbb user can have the same email.
User avatar
rudolfpietersma
Registered User
Posts: 69
Joined: Sat Nov 01, 2008 8:01 pm

Re: [RC] Facebook For PhpBB Light

Post by rudolfpietersma »

All the avatars show up like

./download/file.php?avatar=2_1273511955.jpg

**EDIT: used the patch now the avatars are back.
User avatar
rudolfpietersma
Registered User
Posts: 69
Joined: Sat Nov 01, 2008 8:01 pm

Re: [RC] Facebook For PhpBB Light

Post by rudolfpietersma »

How to get my FB avatar on my phpbb forum?

Return to “[3.0.x] Abandoned MODs”