[RC3] eMosbat TinyMCE Integration (WYSIWYG editor)

[emosbat]

On your demo board, I'm having a problem left-aligning an inserted image with text (so the text is wraps around the image).

I'm attempting align the image via the Insert options (upon clicking the image icon).

When I preview, sometime I get a server error, and sometime it just goes back to the default setting.

I'm not sure if it actually posts correctly or not because posts must be approved by the admin before they are displayed.

Otherwise, it's looks pretty good

I think you send your post just in same time I uploaded new version
you may try testing again and should be able to post without approvement, let me know
alignment is not possible using tinymce's image dialogbox because phpBB have not alignment bbcodes by default. for this case you should define a bbcode to align contents and use it in editor.

[elazard]

Hi i use a custom template inherited from subsilver 2 i have no posting_editor.html for both of them.
Could you please help me?

Thanks for your help and for your work


edit anyway i tried to make the changes in posting_body.html it's now not showing any buttons after installation (no new or old bbcodes buttons) and i cant check config because of an error when clicking the acp tab

Code: Select all

[phpBB Debug] PHP Warning: in file [ROOT]/includes/acp/acp_emotinymce.php on line 159: Invalid argument supplied for foreach()

thanks again for your help

Hello my friend
this mod is not compatible with subsilver template yet, but it will be available very soon (hope in next minor reversion).
edit: subsilver2 support added in new version
/

regarding error message, did you run `emotinymce_install.php` installation proccess? and what is your phpbb version? do you use any other language rather than english? and did you copied language files (in case of manual installation)?

Hi thanks for your answer i made the changes to posting_body.html but it's still not showing any buttons neither the old ones (default) or the new ones. I sent the language files in my french language directory so now i'm able to use the acp tab and it says it's activated but still no luck

My version of phpbb is 3.0.10, language french and i ve run the installation file

[keith10456]

The admin approval thingy is now fixed. However, inserted images still cannot be aligned (wrapped around text). As before, it displays correctly at first but if you preview or make a post it goes back to the default (no alignment).

[emosbat]

Hi thanks for your answer i made the changes to posting_body.html but it's still not showing any buttons neither the old ones (default) or the new ones. I sent the language files in my french language directory so now i'm able to use the acp tab and it says it's activated but still no luck

My version of phpbb is 3.0.10, language french and i ve run the installation file

I think you didn't copied tiny_mce folder, emo_tinymce.js and emotinymce_editor.html in custom theme folder. first copy original post_body theme from your backup then download latest version and try applying subsilver2 changes to your theme again. do not forget to copy files from subsilver2 folder to your theme folder. finaly refresh your theme from acp. hope this help

[emosbat]

The admin approval thingy is now fixed. However, inserted images still cannot be aligned (wrapped around text). As before, it displays correctly at first but if you preview or make a post it goes back to the default (no alignment).

in phpBB we need custom bbcodes to align texts/images. there is no default bbcode for alignment in a clean installation. as I said (end-user) should add custom alignment bbcode to make it possible
actually I could remove alignment option in that dialogbox

[keith10456]

The admin approval thingy is now fixed. However, inserted images still cannot be aligned (wrapped around text). As before, it displays correctly at first but if you preview or make a post it goes back to the default (no alignment).

in phpBB we need custom bbcodes to align texts/images. there is no default bbcode for alignment in a clean installation. as I said (end-user) should add custom alignment bbcode to make it possible
actually I could remove alignment option in that dialogbox

On my site I currently have custom bbcode from alignment... No biggie there.

As you stated though, I think you should remove the alignment options from the dialog box. Otherwise, members will think they can use them when they can't.

[elazard]

ok working i had to deactivate and reactivate the mod in acp as strange as it sounds thanks again for the time you spent helping me and for that mod

[emosbat]

On my site I currently have custom bbcode from alignment... No biggie there.

As you stated though, I think you should remove the alignment options from the dialog box. Otherwise, members will think they can use them when they can't.

yes I should remove them

ok working i had to deactivate and reactivate the mod in acp as strange as it sounds thanks again for the time you spent helping me and for that mod

great hope you like it.

[misiek90]

@emosbat In the future, plans to add options to choose fonts?

[emosbat]

@emosbat In the future, plans to add options to choose fonts?

there is no default BBCode for fonts in clean phpBB installation so we can not add it by default. but if you add a custom font bbcode, will automatically show on toolbar

[emosbat]

quick quote feature added and I think current features are enough for a release version.
will change it to RC after some more testing.

[misiek90]

@emosbat In the future, plans to add options to choose fonts?

there is no default BBCode for fonts in clean phpBB installation so we can not add it by default. but if you add a custom font bbcode, will automatically show on toolbar

It's a shame: (A could be done, the allowance of an additional instruction? In commercial scripts is therefore available for phpBB3 would be nice

[emosbat]

@emosbat In the future, plans to add options to choose fonts?

there is no default BBCode for fonts in clean phpBB installation so we can not add it by default. but if you add a custom font bbcode, will automatically show on toolbar

It's a shame: (A could be done, the allowance of an additional instruction? In commercial scripts is therefore available for phpBB3 would be nice

if phpbb include it in next version I can easily add it to MOD

[EXreaction]

posting_editor.html

Code: Select all

rg = new RegExp(escapeReg("{smiley.A_SMILEY_CODE}"),"g");

replace with

Code: Select all

rg = new RegExp("^"+escapeReg("{smiley.A_SMILEY_CODE}")+"$","g");

oh I forgot to add this fix.
this just occured on this smiley ( ) for me.
I just added your fix, thanks!
/
edit:
seems not working well
your suggestion process whole string for match and this will cause problem in previewing/resubmiting posts. this will not process smilies/custom bbcodes when clicking preview button because then we send whole entered text to regex for match and replacement. hope find a better solution for this problem.

Did you ever figure out a solution? Could you show me an example of where this caused issues? I dont have my computer setup right now because I am in the middle of moving, but I can maybe get this figured out with you.

You also mentioned custom bbcodes, I cant remember if I asked you, but are the custom bbcodes parsed or just displayed as bbcode?

[emosbat]

Did you ever figure out a solution? Could you show me an example of where this caused issues? I dont have my computer setup right now because I am in the middle of moving, but I can maybe get this figured out with you.

You also mentioned custom bbcodes, I cant remember if I asked you, but are the custom bbcodes parsed or just displayed as bbcode?

hi Exreaction,
yes I fixed that. it was a mistake that I trimed out strings before replacement so regex didn't works correctly because we have two spaces around smiley codes! here is new code:

Code: Select all

function custom_phpbb_bbcode2html(s)
{
		s = (s[0]!=' ' || s==''?' ':'')+s+(s[s.length-1]!=' ' || s==''?' ':'');

		<!-- BEGIN smiley -->
		s = build_bbcode_regex(s,escapeReg(" {smiley.A_SMILEY_CODE} ")," <img src=\"{smiley.SMILEY_IMG}\" /> ");
		<!-- END smiley	-->

		return s; 
}

regarding custom bbcodes:
display them. can not parse them without exta code.
acually we then need an AI to do this to understand
how should parse a custom bbcode without exta code
but it is easy to add customized parsing for a bbcode using custom_phpbb_bbcode2html and custom_phpbb_html2bbcode functions.