[RC] Index Tabbed

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Anti-Spam Guide
User avatar
Jorup16
Registered User
Posts: 426
Joined: Sun Dec 14, 2008 5:13 am
Location: Zacapa, Guatemala
Name: Jorge
Contact:

Re: [RC] Index Tabbed

Post by Jorup16 »

Spanish Translations for Ext phpBB :D - Traducciones al español para Ext phpBB :)
>>>>> https://github.com/Jorup16 <<<<<
Saske1
Registered User
Posts: 263
Joined: Wed Feb 02, 2011 7:41 pm
Location: Spain/España
Name: Salva
Contact:

Re: [RC] Index Tabbed

Post by Saske1 »

Jessica wrote: it was set as a category, changed it to 'module'
Thanks for report it
As expected, there was some failure
I mod I added manually to the ACP (had not yet created the install.php) why not I realized

Fixed here :)
Saske1
Registered User
Posts: 263
Joined: Wed Feb 02, 2011 7:41 pm
Location: Spain/España
Name: Salva
Contact:

Re: [RC] Index Tabbed

Post by Saske1 »

Answered.

I made ​​a small change in the tabs.css for version 3.0.1

Code: Select all

.nav {
  padding-left: 0;
  margin-bottom: 0;
  list-style: none;
}
Replace with

Code: Select all

.nav {
  padding-left: 0;
  margin-bottom: 1px;
  list-style: none;
}
And add in the first post 2 addons to "change" a little tabb style, customize it a little.
The 2 addons in the package github now.
User avatar
Jessica
Former Team Member
Posts: 4342
Joined: Sun Jul 18, 2010 2:53 pm
Location: Pennsylvania, USA
Name: Jessica
Contact:

Re: [RC] Index Tabbed

Post by Jessica »

On your image of the pill tabs, there's a small white space between the blue "pills" and the tab box/content. On my tabs, the blue pills seem to be a bit too close; is there anyway I could get a little bit of white space?

Image
Pro-choice, Atheist, Pro-LGBT rights
Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid. - Albert Einstein
Saske1
Registered User
Posts: 263
Joined: Wed Feb 02, 2011 7:41 pm
Location: Spain/España
Name: Salva
Contact:

Re: [RC] Index Tabbed

Post by Saske1 »

Jessica wrote: is there anyway I could get a little bit of white space?
Saske1 wrote: I made ​​a small change in the tabs.css for version 3.0.1

Code: Select all

.nav {
  padding-left: 0;
  margin-bottom: 0;
  list-style: none;
}
Replace with

Code: Select all

.nav {
  padding-left: 0;
  margin-bottom: 1px;
  list-style: none;
}
When you downloaded the 3.0.1 version on Github, that change had not yet :P
User avatar
Jessica
Former Team Member
Posts: 4342
Joined: Sun Jul 18, 2010 2:53 pm
Location: Pennsylvania, USA
Name: Jessica
Contact:

Re: [RC] Index Tabbed

Post by Jessica »

I made that change manually. Guess I should refresh browser. Never mind then
Pro-choice, Atheist, Pro-LGBT rights
Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid. - Albert Einstein
Saske1
Registered User
Posts: 263
Joined: Wed Feb 02, 2011 7:41 pm
Location: Spain/España
Name: Salva
Contact:

Re: [RC] Index Tabbed

Post by Saske1 »

Jessica wrote:I made that change manually. Guess I should refresh browser. Never mind then
If you think the space is too small, you can change 1px for 3px

Other error:
adm/style/acp_index_tabbed.html
Find

Code: Select all

			<dd><input type="radio" class="radio" name="index_tabbed_topic" value="1" <!-- IF INDEX_TABBED_FORUM -->checked="checked"<!-- ENDIF -->/> {L_YES} &nbsp; 
				<input type="radio" class="radio" name="index_tabbed_topic" value="0" <!-- IF not INDEX_TABBED_FORUM -->checked="checked"<!-- ENDIF --> /> {L_NO}</dd>
Reeplace with

Code: Select all

			<dd><input type="radio" class="radio" name="index_tabbed_topic" value="1" <!-- IF INDEX_TABBED_TOPIC -->checked="checked"<!-- ENDIF -->/> {L_YES} &nbsp; 
				<input type="radio" class="radio" name="index_tabbed_topic" value="0" <!-- IF not INDEX_TABBED_TOPIC -->checked="checked"<!-- ENDIF --> /> {L_NO}</dd>
Saske1
Registered User
Posts: 263
Joined: Wed Feb 02, 2011 7:41 pm
Location: Spain/España
Name: Salva
Contact:

Re: [RC] Index Tabbed

Post by Saske1 »

Officially Upgraded to 3.0.1 (The version was only available on Github)
leschek
Registered User
Posts: 791
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Re: [RC] Index Tabbed

Post by leschek »

User avatar
Jessica
Former Team Member
Posts: 4342
Joined: Sun Jul 18, 2010 2:53 pm
Location: Pennsylvania, USA
Name: Jessica
Contact:

Re: [RC] Index Tabbed

Post by Jessica »

Seems to have been fixed on viewforum, but not viewtopic.
Pro-choice, Atheist, Pro-LGBT rights
Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid. - Albert Einstein
Saske1
Registered User
Posts: 263
Joined: Wed Feb 02, 2011 7:41 pm
Location: Spain/España
Name: Salva
Contact:

Re: [RC] Index Tabbed

Post by Saske1 »

Fixed here
leschek
Registered User
Posts: 791
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Re: [RC] Index Tabbed

Post by leschek »

Thank you.
User avatar
Jessica
Former Team Member
Posts: 4342
Joined: Sun Jul 18, 2010 2:53 pm
Location: Pennsylvania, USA
Name: Jessica
Contact:

Re: [RC] Index Tabbed

Post by Jessica »

"Si Index Tabbed se activa en el indice y usted tiene modificaciones en el index_body, usted las perderá" roughly translates to "If Index Tabbed index is activated and you have index_body modifications, you will lose them"

It doesn't really make sense, unless it's supposed to be like this? If it's activated and I have the modifications...how will I "lose" them? Or does it mean something else? (Trying to translate it to English. I know Spanish but just wanted to make sure it's supposed to mean this). I think the translation is right, but the "you will lose them" part doesn't make sense. Can you explain it?
Last edited by Jessica on Sun Aug 25, 2013 2:02 am, edited 1 time in total.
Pro-choice, Atheist, Pro-LGBT rights
Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid. - Albert Einstein
User avatar
Jessica
Former Team Member
Posts: 4342
Joined: Sun Jul 18, 2010 2:53 pm
Location: Pennsylvania, USA
Name: Jessica
Contact:

Re: [RC] Index Tabbed

Post by Jessica »

Also, there's a mistake in /language/en/mods/info_acp_index_tabbed.php

It says:

Code: Select all

* Share On [Español]
*
* @package language
* @version $Id: info_acp_shareon.php
* @copyright (c) Saske ( http://www.phpbbsaske.es )
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
It's not the Share On mod; think you'll need to change that ;)
Pro-choice, Atheist, Pro-LGBT rights
Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid. - Albert Einstein
Locked

Return to “[3.0.x] MODs in Development”