[ABD] [3.1] [pre]fixed - Topic Prefixes extension

[PayBas]

Nice extension.

I'm wondering if you could add an option to the ACP module. It might be nice to able to simply select (multiple by holding CTRL) forums and user groups from a list when creating/managing new prefixes. Having to look up forum IDs can be a pain in the @ss.

[RAGEstacker]

it doesn't work on phpbb 3.1 b2

[tbackoff]

Considering beta 2 came out only 10 hours ago and David hasn't visited the site for 19 hours. He most likely hasn't had time to update it to work with the newest beta yet.

[Meis2M]

hi:

Code: Select all

Parse error: syntax error, unexpected '[' in /home/zohallco/public_html/3.1.dev/ext/imkingdavid/prefixed/migrations/v10x/m3_remove_settings_module.php on line 39

[imkingdavid]

hi:

Code: Select all

Parse error: syntax error, unexpected '[' in /home/zohallco/public_html/3.1.dev/ext/imkingdavid/prefixed/migrations/v10x/m3_remove_settings_module.php on line 39

PHP 5.4 is required for this extension. In PHP 5.4, a new syntax for arrays was introduced (i.e. ['a','b','c'] instead of array('a','b','c')) and I am using that.

Please note that this extension is still waiting on some events that are currently waiting on some discussion about implementation, so some things still don't work (i.e. the prefixes don't appear before topic titles in most locations)

it doesn't work on phpbb 3.1 b2

In the future when reporting issues, please explain what specifically is not working. Are you getting an error?

That being said, I haven't had a chance to work on or test this recently so I can't promise that it will work with any changes that may have been made to the phpBB code since I last updated this extension.

[RAGEstacker]

simply when i activate the extension i get a white page

[imkingdavid]

Hey can you try again with the latest commit on the extension's develop branch? After changing "licence" to "license" in the composer.json file, I have been able to install the extension without any issue at all on the latest version of phpBB's develop branch.

NOTE: I haven't made any further progress on this.

Off the top of my head, still left to do is:
- Get those template events into 3.1 for displaying prefixes before the topic title in viewforum, etc. (there's discussion about the proper implementation but it's pretty stalled). For now, you can get it to work by adding them manually (I forgot the names and exact locations at the moment)
- Use group and forum multi-select in admin area when choosing who can use the prefix and where. There had been some work on an autocompletion thing for users that I was going to use once merged, but that may be a while off. For now, I may change the text field to accept usernames instead of user IDs just to make it a bit more user-friendly.
- Improve the drag and drop UI look and feel. Right now it works but I need to figure out exactly how it should look. I am open to suggestions and if anyone wants to work on a pretty UI for it, I appreciate any help! (Anyone whose code gets into the release of the extension will of course get their name in the credits.)
- Test a bit

Planned features for later versions:
- Search by prefix
- Sort/filter topic listing by prefix
- Prefixes in more locations (how much work this will be depends on how we get the events set up now)
- What else?

Also, anyone with great ideas for extending this extension in their own extension is welcome to get in touch. I have added some of my own events, and you can easily add tokens so that more dynamic prefixes can be created (e.g. countdowns, etc.). I want to keep the default feature set fairly small but allow expansion to be trivial.

Finally, let me know any feature requests you have. As I just said, I want to keep the extension lightweight, but if I like your idea enough (or if enough other people like your idea enough) I may consider adding it.

[imkingdavid]

FYI, if you want to see topic prefixes on viewforum, you'll need to do the following until the event is actually added:
Open: styles/prosilver/template/viewforum_body.html
Find:

Code: Select all

<!-- IF topicrow.S_UNREAD_TOPIC and not S_IS_BOT --><a href="{topicrow.U_NEWEST_POST}">{NEWEST_POST_IMG}</a> <!-- ENDIF --><a href="{topicrow.U_VIEW_TOPIC}" class="topictitle">{topicrow.TOPIC_TITLE}</a>

Replace with

Code: Select all

<!-- IF topicrow.S_UNREAD_TOPIC and not S_IS_BOT --><a href="{topicrow.U_NEWEST_POST}">{NEWEST_POST_IMG}</a> <!-- ENDIF --><!-- EVENT topiclist_topic_title_before --><a href="{topicrow.U_VIEW_TOPIC}" class="topictitle">{topicrow.TOPIC_TITLE}</a>

I'm probably not going to show the topic prefix on the last post title on the index forum list because:
1) Right now it requires a new query for each forum to get the topic ID using the last post ID
2) The post doesn't have a prefix, the topic does. because it's a last post title and not a last topic title, it makes more sense not to show it.

[PayBas]

FYI, if you want to see topic prefixes on viewforum, you'll need to do the following until the event is actually added

I couldn't find your PR. Was it submitted yet?

[imkingdavid]

FYI, if you want to see topic prefixes on viewforum, you'll need to do the following until the event is actually added

I couldn't find your PR. Was it submitted yet?

I actually just closed it. https://github.com/phpbb/phpbb/pull/1924 EXreaction is wanting a more efficient implementation (i.e. applying to topic titles in more places) so that is still needing some discussion.

[aldink]

after enable the extension got on forum this error:

Code: Select all

Catchable fatal error: Argument 1 passed to imkingdavid\prefixed\core\manager::__construct() must be an instance of phpbb\db\driver\driver, instance of phpbb\db\driver\factory given in C:\xampp\htdocs\ext\imkingdavid\prefixed\core\manager.php on line 82

[imkingdavid]

Thanks for the info. I haven't updated/tested this extension in a while so it is likely out of date with the latest phpBB changes.

[imkingdavid]

FYI that error has been fixed. The extension should install just fine on RC5. Let me know if you have issues.

Note that this is still awaiting template events to add the prefix before the topic title on the viewforum.php page and a few other places. RIght now, it basically only shows on viewtopic.php.

There may be an error while trying to apply prefixes to a topic. I'll work on fixing that as well.

[masterronnow]

When I try to activate that Extension i get followeing error:

Code: Select all

Parse error: syntax error, unexpected '[' in /var/www/web123094/html/phpBB3/ext/imkingdavid/prefixed/migrations/v10x/m3_remove_settings_module.php on line 39

[Mauron]

Hello,
while trying to open a new topic after installing [pre]fixed, I got the following error: Fatal error: Call to a member function variable() on a non-object in ***\phpBB\ext\imkingdavid\prefixed\event\listener.php on line 197