[ABD] [3.1] [pre]fixed - Topic Prefixes extension

[imkingdavid]

When I try to activate that Extension i get followeing error:

Code: Select all

Parse error: syntax error, unexpected '[' in /var/www/web123094/html/phpBB3/ext/imkingdavid/prefixed/migrations/v10x/m3_remove_settings_module.php on line 39

Make sure you're on PHP 5.4 or higher.

Hello,
while trying to open a new topic after installing [pre]fixed, I got the following error: Fatal error: Call to a member function variable() on a non-object in ***\phpBB\ext\imkingdavid\prefixed\event\listener.php on line 197

Thanks, I''ll take a look.

[moviehive]

Now that 3.1.0 is gold what is the EST for a beta?

[Cable Player]

Hi there, is this Extension similar to Quick Title Edition? If so, what will be different on this one different to that?

[imkingdavid]

Now that 3.1.0 is gold what is the EST for a beta?

Because I can only work on this in my free time and I'm not sure what availability I will have from day to day (and because this extension relies on template events that are not yet part of the phpBB core), I can't really give an estimate. However, now that 3.1 has been released, I do plan on making a more concentrated effort to finish this. You can follow development on the GitHub repository that is linked in the first post.

Hi there, is this Extension similar to Quick Title Edition? If so, what will be different on this one different to that?

I believe they perform similar functions, but the implementation is somewhat different. I haven't really used QTE much at all, so I'm not exactly sure what all of the similarities/differences are. Once I release a more stable, working version, you're welcome to try them both out to see which one best meets your needs. I may also take some time to try that one out a create a feature comparison when I get closer to a release.

----

For reference:
From what I can tell, the Fatal Error posted by Mauron is due to my use of an event in posting.php that occurs before $user->setup() is called (the structure of that file is somewhat different than the structure of most of the other top-level files). I will need to take another look at posting.php to see if there have been any events added since the last time I checked that will be able to better suit my needs.

Also, I've been considering a jQuery drag and drop approach for setting prefixes on a topic (this is the current implementation if you test out the extension now, though that is just a quick proof of concept), but I'm wondering if that is practical or intuitive. In any case it would need to be tidied up a bit. I may revert back to a less complex multi-select box or something.

[imkingdavid]

FYI I've fixed the error with applying topic prefixes. I finally had a chance to look at the events available in posting.php and I found a better one to use so I switched to that. After testing, I was able to to successfully apply a prefix to a topic without any errors or notices.

Note that the prefix still only shows up in front of the topic title on viewtopic.php because that is the only place in the core that currently has a template event in front of topic titles. I still need to see what needs to be done to add template events for the various other topic titles.

[Kailey]

Not sure how you feel about a viewforum solution like this:



All I did was create a file topiclist_row_append.html with the following code:

Code: Select all

<span>{topicrow.TOPIC_PREFIX}</span>

I also noticed a few bugs:

1. The prefixes only show on edit, they don't appear when creating a new topic.
2. When submitting or editing a post other than the first post, the prefix boxes show. There are no prefixes listed, but seems like a waste of screen space.
3. In addition to the previous bug, submitting said post will remove the prefixes.

[MattF]

Not sure how you feel about a viewforum solution like this:



All I did was create a file topiclist_row_append.html with the following code:

Code: Select all

<span>{topicrow.TOPIC_PREFIX}</span>

I also noticed a few bugs:

1. The prefixes only show on edit, they don't appear when creating a new topic.
2. When submitting or editing a post other than the first post, the prefix boxes show. There are no prefixes listed, but seems like a waste of screen space.
3. In addition to the previous bug, submitting said post will remove the prefixes.

Topic Prefixes would not be prefixes unless they are in front of the topic. This has always been the case and is common among other board software as well, so what you are proposing here is just awkward, and looks more like a topic tags type of thing...not a topic prefix type of thing.

[Kailey]

It was a thought. =)

[imkingdavid]

Hi kinerity, and thanks for the feedback!

I have just pushed some logic changes to make sure the blue boxes that contain the prefixes show up when 1) posting a new topic, or 2) editing the first post of a topic, but not in any other case (such as editing a post that isn't the first in a topic, or replying to a topic). It should also only show up in forums in which there are prefixes available for the current user. Additionally, it shouldn't clear prefixes when replying to topics. You're welcome to pull in my changes and test again to verify that it is working as intended.
Edit: Thinking about it, I just realized that there is probably a bug in which a user that doesn't have permission to use a certain prefix could end up inadvertently removing that prefix from a topic because it wouldn't show up in the prefix management boxes, so the code as it is now would effectively *forget* about it. I'll need to keep this in mind as I improve the logic. I can also think of a bug where tokens (e.g. {DATE}) might get re-applied during edit instead of keeping their state, but I haven't tested for that yet, so I can't confirm it.
Edit 2: further testing revealed that all of the currently applied prefixes will be removed if anyone edits the post and doesn't re-apply them. This is likely related to the logic changes I just made, so I'll work out a fix soon, hopefully. Fixed!

As for the presentation of the prefixes, while that is something you are welcome to implement for yourself, that is not ideal for a topic prefix extension, as VSE mentioned. I do plan to work on getting the appropriate template events in place in front of topic titles in as many places as possible, but when I first tried to do this, there was some disagreement on implementation (trying to be as efficient as possible) so I sort of gave up on it in favor of moving forward with other aspects of the extension. I do plan to revisit that, however, unless someone else beats me to it.

---

Along with that, other improvements I plan to make before bumping this up to ALPHA or BETA include a more user-friendly admin experience (i.e. selecting forums and groups from a multi-select field, and allowing administrators to specify users by username, rather than user ID), as well as most likely some changes to the prefix manager on the posting screen. The two blue boxes that are there right now are mainly just a placeholder, but they aren't very user-friendly or aesthetically pleasing. Of course, if a design-oriented person wishes to help out in that regard, either by providing a mockup of how it could work or by actually providing a pull request with a better implementation, I would be most appreciative, and that person's name would be included in the appropriate places to give him or her credit.

[lavachapi]

Please find French translation…
But just a thought… I guessed {POSTER} token means “Author of topic” as I couldn't understand anyone could modify a prefix excepted moderators and author. i.e. to mark topic as [solved].
Right ?

[moviehive]

I am needing something that will apply Read Me prefixes in some of the threads I create.If I was to use this in it's current form is there permissions to revoke members from using it or should I use the IF_ACP function?

[imkingdavid]

Please find French translation…
But just a thought… I guessed {POSTER} token means “Author of topic” as I couldn't understand anyone could modify a prefix excepted moderators and author. i.e. to mark topic as [solved].
Right ?

Thanks for the translation, though I think it might be best to wait until the extension is closer to being released in case any of the language strings change. Yes, POSTER is the topic poster, i.e. the author of the topic.

I am needing something that will apply Read Me prefixes in some of the threads I create.If I was to use this in it's current form is there permissions to revoke members from using it or should I use the IF_ACP function?

Well, prefixes can only be added or removed by users with moderator permissions (and maybe the topic author as well, I can't remember). However, prefixes are only able to be set if the user is whitelisted to use it, either by user ID or group ID, in the ACP.

I don't recommend trying this on a live board unless you're willing to work around whatever bugs may still be in the code. I won't be providing support for the extension.

If you only need to be able to add "Read Me" in front of topic titles, you might also want to take a look at this extension, though I haven't tried to myself, and I'm not sure if it is any more complete than mine (or any more stable, since it still has the DEV tag).

[Tuqe]

Didn't work for me.
I wrote prefixs, doesn't come

[Volksdevil]

Any news on this one? Don't suppose anybody has any screen shots?

Will it do what I hope? I just want my users (In chosen forums) to be able to use a prefix of 'Solved'?

[biblexcursion]

Is it possible to have the prefix as a coloured tag? Where we can choose the colour of the tag. To make it more visible the topics with the same prefix.