[ABD] [DEV] Post Love

[noth]

I believe that this extension should have the Permissions system incorporated with it

so in the final event in ACP an Admin could go to a User's permissions and "unset" their permission to "love a Post"

as with all these additions, they are open to abuse and although you may think now, that this couldn't possibly be used for annoyance of other users, it only takes 1 user to be a complete idiot with it and we will wish we had a permission to "unset"

[Satanasov]

I will think about this.

[jeepwhisperer]

Just got this installed, and I like! One observation... I have one forum using the subsilver2 style, and when I click on the heart I get a blank window with "{"togle_action":"add","togle_post":"2"}" at the top. If I go back and refresh the screen, the heart has been toggled.
I use Firefox, FYI. I don't know if this is me, but I thought you should know...
Joe Sand

[Satanasov]

OK... This appears to be an issue related to ajax-data part of the link. I don't know is subsilver supports ajax ... I will check and get back to you.

[lws96]

Has this been updated for phpBB RC5? It installed just fine and I see the hearts, but if I click on it in Chrome or IE 11, a window pops up for a brief second with an image of Java thinking or something and then disappears. The heart count does not increase, even after I refresh it.

[Satanasov]

Hello there - just restarted all TRAVIS-CI tests (as it works on my dev install). It is all grean. So it works ok.

If you can provide me with console erro message I can debug it.

[mrgtb]

Two things I just spotted with this. if you allow guests to post on the forum (which I do) and a member gives a LOVE to a guest post made, then the heart does not show up (to a guest viewing that post, but still does to a logged-in member). But the guest viewing can still see the heart in other guests posts (not been given a love). Look at the image below, I give a guest poster a LOVE and it only shows the X mark when viewing that thread as a guest on my board (see heart as a member logged-in though). You can see the other heart in the guest post made (as a guest) because that post wasn't loved unlike other one was.

1.PNG

Second thing I've noticed also. Try minimizing the browser so the template goes to mobile viewing state and you can see the "return to top" of forum image is sitting too close below the heart image. Maybe it would be best to not align the heart image on right-side, instead display it on left to avoid that happening. Again that was viewing my forum minimized so ProSilver goes into mobile viewing state, so that "return to top" icon gets displayed below the heart.

2.PNG

[Satanasov]

The issue with liking Guests post is resolved in develop version.

I'm implementing tests.

Then I will see what can be done for the love button.

[mrgtb]

I've been talking a lot to you in PM messages. OK, I've been looking at the DEV package installed messing around changing some things to try and help out with this. As I didn't think it works well being aligned to left-side now in DEV package.

You was using two images of different formats (PNG and GIF) before (named same image), one being 32x32px and other 16x16px (but both used 16x16px size, so PNG one got resized down to 16px. I've created two new heart images, both are 16px and in GIF format. One of them is GOLD coloured used for LIKED posts, other is RED.

I've made some changes to CSS and aligned it back to RIGHT side again, fix the problem with heart having no spacing below it - I added 5px margin-bottom space to hearts in CSS (so that solves problem with some spacing added between signature bar and love image - and "back to top" image "in mobile viewing state"). I've changed image path in CSS to heart_gold.gif and heart_red.gif, so you can use both images as GIF's (and both are same size now).

I also fixed the problem with you using "Style ID" in a template to float it right because it fails W3C validation, in that you cannot have same "ID" style repeated multiple times on one page, so changed it from

Code: Select all

<div style="float: right;" id="postlove">

to

Code: Select all

<div style="float: right;" class="postlove">

Using CLASS passes validation because it can be used multiple times as a style on a page, unlike style ID that can only be used once. I've uploaded the full changed DEV package I'm using for you to have look at and test .

[Satanasov]

Thank you.

So I've changed the id to class (the tests are running now (and passed)).
margin-bottom: 5px; added.

I will add the 5px margin bottom as you suggested and I will redo the images. I like the white heart as it looks like it's pressed. That's why I think I will stick with it.

[mrgtb]

Can I asked, why are members allowed to LIKE their own posts. It doesn't make sense to me that? It would also be open for abusing with members LIKING their own post on purpose because it doesn't actually show who liked who's post- so nobody can even know a person liked their own post on purpose.

I did also spot another thing yesterday, which is making me wonder now if it's best having the heart displayed in the post itself? If you quote a person with a reply (but add no text after the quote), you add text before the quote. There is no spacing below the quote and heart image. Suspect same thing is going to happen when posting CODE as well. I tried adding some margin-top but it's not working well, it knocks the heart image out of alignment with the text count displayed at side of it.


Why not put the heart under the avatar on right near profile fields, like I put my twitter button in this image below rank code.

Snap1.png

[mrgtb]

I show the twitter button there by doing this with viewtopic_body.html template.

<!-- IF postrow.RANK_TITLE or postrow.RANK_IMG --><dd class="profile-rank">{postrow.RANK_TITLE}<!-- IF postrow.RANK_TITLE and postrow.RANK_IMG --><br /><!-- ENDIF -->{postrow.RANK_IMG}</dd><!-- ENDIF -->

<dd>Twitter code goes here</dd>

<!-- IF postrow.POSTER_POSTS != '' --><dd class="profile-posts"><strong>{L_POSTS}{L_COLON}</strong> <!-- IF postrow.U_SEARCH !== '' --><a href="{postrow.U_SEARCH}"><!-- ENDIF -->{postrow.POSTER_POSTS}<!-- IF postrow.U_SEARCH !== '' --></a><!-- ENDIF --></dd><!-- ENDIF -->
<!-- IF postrow.POSTER_JOINED --><dd class="profile-joined"><strong>{L_JOINED}{L_COLON}</strong> {postrow.POSTER_JOINED}</dd><!-- ENDIF -->
<!-- IF postrow.POSTER_WARNINGS --><dd class="profile-warnings"><strong>{L_WARNINGS}{L_COLON}</strong> {postrow.POSTER_WARNINGS}</dd><!-- ENDIF -->

Because you use <dd></dd>, all this margin-top and bottom wouldn't be needed because that spaces the profile fields apart vertically from one another anyway (creating even space). Plus you avoid the problem of things in posts clashing - making things difficult having to use CSS to get things displayed right (against other things in post content). By having it in sidebar instead, a lot of that isn't necessary.

Also, when you go to mobile viewing state the LIKE button will not get displayed having it there because all profile fields in right-sidebar vanish in mobile mode. Like my twitter button doesn't get displayed in mobile view avoiding cramping things up (too much displayed) for mobile users

[Satanasov]

Let me start answering questions one by one:

1. it displays who liked the post - the span's title contains useranames, so if you go with the mouse over the count you will see it.
2. I don't see this with the quote. You have some small margin. I will try some css fu, but mine is weak!
3. I wan't the heart (love) button on the post exactly because going mobile destroys the little profile field.

[File_Submit]

браво за екстенжъна!!! / Good work with this extension!

[carineteles2563]

Thanks for it, its help me very, i add it to my blog