[ABD] Trader extension

[rfdy]

The option to specify which types are available in each forum is nearly completion and will be released soon. There are other improvements being made.

The release will be made in the next week or two.

Thanks!

[Volksdevil]

That sounds perfect!

[nextgen]

Any news?

I am really interested in this extension

[keith10456]

Looking forward to the release

[rfdy]

The code has been updated. The list of most recent changes is here https://github.com/rfdy/trader/blob/master/CHANGELOG.md

We have implemented Volksdevil's request 2
Also adjusted the way ratings are calculated so that they make more sense as well as fixed a few bugs.

The extension has now been moved to beta, suggestions, comments or bug reports are quite welcome.

[nextgen]

I like this running the extension.

Here my suggestions:

1. That the itrader configuration has its own section in the Extensions tab and there select the ids of the forums in which to be enabled http://easycaptures.com/fs/uploaded/819/3485053363.png
2. Be given the option to rating in any message and not just the first http://easycaptures.com/fs/uploaded/819/4976784043.png

A few errors that I found

1. The image is where added the rating is not showing http://easycaptures.com/fs/uploaded/819/4244042896.png
2. When making a rating it shows this error

   Code: Select all

   [phpBB Debug] PHP Notice: in file [ROOT]/ext/rfd/trader/Controller/Trader.php on line 132: Undefined index: short
   [phpBB Debug] PHP Notice: in file [ROOT]/ext/rfd/trader/Controller/Trader.php on line 132: Undefined index: long

For the moment only it would be that

PS: I love this extension

[Volksdevil]

The fact you can now choose 'Buy, Sell, Trade' in the setup is awesome, thnks for implementing.

Request:
1/ A notification for Feedback Received, this would be fantastic!

2/ A different 'Feedback' Icon, maybe even the word 'Feedback'?

3/ I notice that when the screen is small, the icon isn't fully responsive. Instead of still being an icon, the word 'Feedback' like the other links in the hamburger menu?

@NextGen, the icon shows OK for me, did you clear cache? I don't get any errors either.

[rfdy]

@Volksdevil

Thanks for the suggestions. The icon is indeed an issue. If you can provide with some html/css to make the fix, or an image we can use (we have our own image as part of our custom theme), then please do so and we'll include it.

Thanks!

[Volksdevil]

I'm not great at this kind of thing, just had a quick look at the css and I see that the <li> end up with display:none; once the theme becomes smaller, but I can't tell where it's coming from

Had a quick go at an icon and this is about the best I can come up with, it's shown here with the hover effect.
I can give you the image if you'd like to use it.
Edit: Ive added the icon in a zip file.

feedvack-icon-phpbb.png

feedback-icon.zip

EDIT2: Oh and I wonder if it's best not to show the icon to guests/bots? I've done it simply by adding <if report> statement like so (In red):
viewtopic_body_post_buttons_after.html
{% if postrow.U_GIVE_FEEDBACK %}
[color=#FF0000][b]<!-- IF postrow.U_REPORT -->[/b][/color]
<li>
<a class="button" id="post_row_give_feedback" href="{postrow.U_GIVE_FEEDBACK}" title="Give Feedback" id="giveFeedback">
<img style="padding-top: 3px" src="./../../styles/prosilver/theme/images/feedback-icon.png">
</a>
</li>
[color=#FF0000][b]<!-- ENDIF -->[/b][/color]
{% endif %}

EDIT again lol:
I also wonder if best not to have links on viewtopic for bots/guests? Again, changes in red:
viewtopic_body_postrow_custom_fields_after.html
{% if postrow.user_trader_rating is defined %}
<dd title="{{ postrow.title }}" class="post_row_feedback_rating">
<strong>
Trader Score{L_COLON}
</strong>
[color=#FF0000][b]<!-- IF not S_IS_BOT and not S_USER_LOGGED_IN -->
{postrow.user_trader_rating}
{% if postrow.user_trader_percentage %}
({{ postrow.user_trader_percentage }}% Positive)
{% endif %}
<!-- ELSE -->[/b][/color]
<a href="{{ postrow.U_VIEW_FEEDBACK }}">
{postrow.user_trader_rating}
{% if postrow.user_trader_percentage %}
({{ postrow.user_trader_percentage }}% Positive)
{% endif %}
</a>
[color=#FF0000][b]<!-- ENDIF -->[/b][/color]
</dd>
{% endif %}

[FoFa]

Hello,

Sent just now French Translation on GitHub

Cheers

[FoFa]

Hi all,

French translation: https://github.com/ForumsFaciles/trader ... anguage/fr

xxx

[rfdy]

Merged, thank you ForumsFaciles!

A translation for our infractions viewtopic.php?f=456&t=2249516 extension would also be great

[rfdy]

I'm not great at this kind of thing, just had a quick look at the css and I see that the <li> end up with display:none; once the theme becomes smaller, but I can't tell where it's coming from

Had a quick go at an icon and this is about the best I can come up with, it's shown here with the hover effect.
I can give you the image if you'd like to use it.
Edit: Ive added the icon in a zip file.

Nice icon, we will try to merge it in shortly.

EDIT2: Oh and I wonder if it's best not to show the icon to guests/bots? I've done it simply by adding <if report> statement like so (In red):
viewtopic_body_post_buttons_after.html
{% if postrow.U_GIVE_FEEDBACK %}
[color=#FF0000][b]<!-- IF postrow.U_REPORT -->[/b][/color]
<li>
<a class="button" id="post_row_give_feedback" href="{postrow.U_GIVE_FEEDBACK}" title="Give Feedback" id="giveFeedback">
<img style="padding-top: 3px" src="./../../styles/prosilver/theme/images/feedback-icon.png">
</a>
</li>
[color=#FF0000][b]<!-- ENDIF -->[/b][/color]
{% endif %}

EDIT again lol:
I also wonder if best not to have links on viewtopic for bots/guests? Again, changes in red:
viewtopic_body_postrow_custom_fields_after.html
{% if postrow.user_trader_rating is defined %}
<dd title="{{ postrow.title }}" class="post_row_feedback_rating">
<strong>
Trader Score{L_COLON}
</strong>
[color=#FF0000][b]<!-- IF not S_IS_BOT and not S_USER_LOGGED_IN -->
{postrow.user_trader_rating}
{% if postrow.user_trader_percentage %}
({{ postrow.user_trader_percentage }}% Positive)
{% endif %}
<!-- ELSE -->[/b][/color]
<a href="{{ postrow.U_VIEW_FEEDBACK }}">
{postrow.user_trader_rating}
{% if postrow.user_trader_percentage %}
({{ postrow.user_trader_percentage }}% Positive)
{% endif %}
</a>
[color=#FF0000][b]<!-- ENDIF -->[/b][/color]
</dd>
{% endif %}

Thank you! Will try to follow what you suggest

[rfdy]

Edit: Ive added the icon in a zip file.

Thank you! Code updated with the new icon.

[Mathieu M.]

Hello,

I don't know if this bug was still report, but on my localhost test, topic title is not shown on "Last post" column (just for board index) and the icon for going to newer reply is a 404 (there's no "id" for t= : domain/forum/viewtopic.php?f=18&t=#p1010).

Thanks.